• last updated 15 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Avoid calls to deprecated NaviServer functions

Initializing a formfield with an invalid spec fails as expected, however, it appears to leave behind the formfield object, which many automated tests will now consider a failure

Ensure the formfield object is destroyed when reading the spec fails

Make the search datasource callback more robust in case pages are broken or otherwise invalid (but complain about it)

Cast to correct datatypes, delete broken placeholder query

Better initialize the datasource for those object that won't return the full set of expected fields

    • -1
    • +4
    /openacs-4/packages/search/tcl/search-procs.tcl
Add missing return

Tolerate non-existing files, but throw a warning

removed deprecated "ns_set new" by "ns_set create"

moved stuff for AOLserver 2 emulation to deprecated procs, mark it explicitly as deprecated

Allow HTML in the default value for parameters, as this could contain markup, e.g. , if the value is some kind of snippet.

Further collect callback logics into procs and test them

    • -2
    • +2
    /openacs-4/packages/search/search.info
    • -4
    • +44
    /openacs-4/packages/search/tcl/search-procs.tcl
    • -21
    • +13
    /openacs-4/packages/search/www/search.tcl
Further cleanup of the indexer logics

- unindexing an object in an own proc

- clarified idioms

- cleanup redundant operations

    • -56
    • +60
    /openacs-4/packages/search/tcl/search-procs.tcl
Claim coverage, bump version number

    • -2
    • +2
    /openacs-4/packages/search/search.info
Factor some of the logic in the indexer into own procs for the purpose of:

- being able to tell programmatically if an object can be indexed

- being able to index an object programmatically using a simpler api

- better test operations

    • -87
    • +126
    /openacs-4/packages/search/tcl/search-procs.tcl
Rework file-to-text conversion with the goal of:

- also for LibreOffice documents, strip the XML from extracted content

- handle errors all at once outside the switch, as the behavior would always be the same

- avoid creating a tempfile

Fix more confusion

Fix rather confusing name of javascript library file

Ensure the namespace exists for template::form::export

Fixed runtime error, when "ns_cache" is viewed over the API browser

The problem was the method "flush", which is implemented via

alias to ::ns_cache__flush. In this case, "ns_cache info lookup syntax flush"

fails, because "info parameter" fails on the alias in command:

"::nsf::cmd::info parameter -context ::ns_cache ::ns_cache::flush"

prefer more efficient approach to iterate over all key/values of an ns_set

use case-insensitive access to configuration values

prefer more efficient "ns_set array" over single item ns_set access

use consistently case-insensitive access to attributes of tags

moved deprecated proc to deprecated-procs.tcl

documentation update: advertise more efficient and recent idiom

Extend user_message feature so that a "severity" information can be passed alongside the message

This allows theme templates to color code messages according to their severity. Severity follows the Bootstrap nomenclature of "info", "success", "warning" and "danger".

Default severity has been set to "success" consistent with styling applied so far by OpenACS to the user messages.

    • -3
    • +3
    /openacs-4/packages/acs-tcl/acs-tcl.info
Bring existing doc into the object's documentation, so that tests would not fail...

    • -16
    • +20
    /openacs-4/packages/xowf/tcl/iprange-init.tcl
Deprecate template::list::csv_quote and replace its usages in packages that we have been supporting

Introduce a new "label_headers" flag for template::list::write_csv that allows to revert to behavior before https://cvs.openacs.org/changelog/OpenACS?cs=MAIN%3Adaveb%3A20080908165252, e.g. use the column names as headers rather than the labels

For some use cases is in fact more useful to have machine-readable headers, e.g. when processing the csv via software

Rely on the csv Tcllib package to generate a csv from a template::list