OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 5
Total Committers: 146
Last Commit: 20 Dec
Commits this week: 5
Total Lines of Code (LoC): 7,561,347
Net change in LoC this week: 335

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 29 May 2018
11:13 am

antoniop

Use API when retrieving user info

Options
    • -2
    • +4
    /openacs-4/packages/acs-tcl/lib/page-error.tcl
    • -11
    • +2
    /openacs-4/packages/acs-tcl/lib/page-error.xql
11:09 am

antoniop

Remove unnecessary xql

Options
    • -9
    • +11
    /openacs-4/packages/acs-subsite/www/pvt/alerts.tcl
    • -40
    • +0
    /openacs-4/packages/acs-subsite/www/pvt/alerts.xql
11:05 am

antoniop

Reduce divergencies between oracle and postgres codebase

Options
    • -35
    • +0
    /openacs-4/packages/dotlrn/www/admin/users-oracle.xql
    • -36
    • +0
    /openacs-4/packages/dotlrn/www/admin/users-postgresql.xql
    • -2
    • +4
    /openacs-4/packages/dotlrn/www/admin/users.tcl
    • -0
    • +30
    /openacs-4/packages/dotlrn/www/admin/users.xql
10:56 am

antoniop

Don't pass fine tcl variables through the query, avoid unnecessary quoting (bulk-mail api would pass variable to the stored procedure using ':' notation)

Options
    • -9
    • +4
    /openacs-4/packages/dotlrn/www/spam.tcl
    • -7
    • +2
    /openacs-4/packages/dotlrn/www/spam.xql
10:44 am

antoniop

Reduce divergencies between oracle and postgres codebase

Options
    • -42
    • +0
    /openacs-4/packages/dotlrn/www/register-oracle.xql
    • -43
    • +0
    /openacs-4/packages/dotlrn/www/register-postgresql.xql
    • -0
    • +37
    /openacs-4/packages/dotlrn/www/register.xql
10:34 am

antoniop

Use more API when retrieving user info

Options
    • -7
    • +5
    /openacs-4/packages/acs-admin/www/users/user-batch-add.tcl
10:27 am

antoniop

Replace leftover Naviserver-only cache idioms with retro compatible ones

Options
    • -5
    • +5
    /openacs-4/packages/chat/tcl/chat-procs.tcl
Monday 28 May 2018
8:26 pm

antoniop

Put this last query also in the code as the others, so no xql is required

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/admin/users/new.tcl
    • -10
    • +0
    /openacs-4/packages/acs-subsite/www/admin/users/new.xql
8:23 pm

antoniop

Use more API, reduce divergency between postgres and oracle code

Options
    • -13
    • +0
    /openacs-4/packages/acs-subsite/www/admin/users/new-oracle.xql
    • -13
    • +0
    /openacs-4/packages/acs-subsite/www/admin/users/new-postgresql.xql
    • -14
    • +8
    /openacs-4/packages/acs-subsite/www/admin/users/new.tcl
    • -35
    • +5
    /openacs-4/packages/acs-subsite/www/admin/users/new.xql
8:10 pm

antoniop

Use more API

Options
    • -6
    • +4
    /openacs-4/packages/acs-tcl/tcl/defs-procs.tcl
7:53 pm

antoniop

Use more API

Options
    • -12
    • +18
    /openacs-4/packages/acs-subsite/www/shared/portrait.tcl
    • -10
    • +8
    /openacs-4/packages/acs-subsite/www/pvt/alerts.tcl
    • -6
    • +3
    /openacs-4/packages/acs-admin/www/users/user-add-2.tcl
7:45 pm

antoniop

Prefer API over handcrafted queries

Options
    • -6
    • +6
    /openacs-4/packages/acs-subsite/www/user/portrait/index.tcl
7:32 pm

antoniop

Create chat room cache in a way to provide compatibility with AOLserver

make timeout and cache size configurable.

Options
    • -1
    • +20
    /openacs-4/packages/chat/tcl/chat-init.tcl
    • -7
    • +1
    /openacs-4/packages/chat/tcl/chat-procs.tcl
6:07 pm

trenner

make require_test_folder more configurable

Options
    • -3
    • +9
    /openacs-4/packages/xowiki/tcl/test/test-procs.tcl
5:49 pm

trenner

use address from driver_info

Options
    • -2
    • +3
    /openacs-4/packages/acs-automated-testing/acs-automated-testing.info
    • -4
    • +4
    /openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
5:46 pm

trenner

add address to driver_info

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -6
    • +6
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
4:05 pm

antoniop

Remove unneded dict creation

Options
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl
    • -2
    • +2
    /openacs-4/packages/dotlrn/www/spam.tcl
3:46 pm

gustafn

modernize tcl

Options
    • -2
    • +2
    /openacs-4/packages/assessment/lib/assessment.tcl
3:36 pm

gustafn

modernize tcl

Options
    • -2
    • +2
    /openacs-4/packages/acs-lang/www/admin/message-list.tcl
    • -6
    • +10
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
3:29 pm

antoniop

Reduce code duplication, exploit API when retrieving user info

Options
    • -73
    • +0
    /openacs-4/packages/dotlrn/www/spam-oracle.xql
    • -73
    • +0
    /openacs-4/packages/dotlrn/www/spam-postgresql.xql
    • -2
    • +6
    /openacs-4/packages/dotlrn/www/spam.tcl
    • -8
    • +63
    /openacs-4/packages/dotlrn/www/spam.xql
3:13 pm

antoniop

Remove redundant queries: user name is already retrieved above from cached user api

Options
    • -15
    • +1
    /openacs-4/packages/dotlrn-fs/tcl/dotlrn-fs-procs.tcl
3:06 pm

antoniop

Reuse person API instead of querying by hand

Options
    • -2
    • +2
    /openacs-4/packages/notifications/tcl/notification-email-procs.tcl
    • -8
    • +0
    /openacs-4/packages/notifications/tcl/notification-email-procs.xql
2:48 pm

antoniop

Modernize idiom

Options
    • -3
    • +2
    /openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl
2:33 pm

antoniop

Restore previous behavior: when a person is not found by email, just return empty string instead of an error

Options
    • -1
    • +7
    /openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl
2:29 pm

antoniop

Reduce code duplication when retrieving person info

TODO centralize caching

Options
    • -14
    • +12
    /openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl
    • -41
    • +0
    /openacs-4/packages/acs-tcl/tcl/community-core-procs.xql
Saturday 26 May 2018
6:40 pm

gustafn

provide compatibility with AOLserver

make timeout cnd cache size configurable

follow usual naming conventions

Options
    • -0
    • +23
    /openacs-4/packages/acs-tcl/tcl/community-core-init.tcl
    • -22
    • +7
    /openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl
Friday 25 May 2018
7:08 pm

antoniop

Pass to a ns_cache implementation to avoid race conditions

Options
    • -14
    • +22
    /openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl
3:36 pm

antoniop

Implement acs_user:: cache through nsv, instead of the util_memoize cache. Note that now this information won't expire anymore unless explicitly flushed.

Options
    • -12
    • +19
    /openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl
2:53 pm

antoniop

Remove unnecessary backslashes, remove leftover usages of get_from_username_not_cached cache, minimize catch wrapping

Options
    • -9
    • +11
    /openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl
10:43 am

antoniop

Reuse acs_user::get_by_username to retrieve user_id in order to reduce query duplication and cache entries for acs_user::get, simplify idiom

Options
    • -32
    • +11
    /openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl
    • -38
    • +1
    /openacs-4/packages/acs-tcl/tcl/community-core-procs.xql