• last updated 10 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
silences log entries during regression test

fixed incorrect message key

    • -1
    • +1
    ./packages/acs-templating/tcl/file-procs.tcl
New API call: aa_silence_log_entries

The new function silences expected messages in the system log. The

proc deactivates the specified severity levels during the code in the

last arguemnt is executed. After it has finished, the severity levels

are reset to their previous values.

The purpose of this function is to make test system log clean from

error messages and the like during the regression test, such it

contains only errors which have to be looked at.

    • -7
    • +5
    ./packages/search/tcl/test/search-procs.tcl
Small upgrade for aa_testing reports

- added used memory and memory differences to before a test case Be

aware that this is the memory of the full process, differences can

be negative.

- cleanup after reporting errors (we have the leaked objects in the aa_log)

use just "Adminitration" in the label of the menubar

    • -1
    • +1
    ./packages/acs-subsite/acs-subsite.info
make this package installable via .apm (install from repository)

add hstore to acs_attribute_types, when hstore is activated

    • -1
    • +8
    ./packages/xowiki/tcl/xowiki-procs.tcl
make this packages installable via .apm (install from repository)

    • -2
    • +3
    ./packages/dotlrn-chat/dotlrn-chat.info
acs-admin/install: provide a hint that we never offer a package with maturity 0 via "install from repository"

    • -1
    • +6
    ./packages/acs-admin/www/install/install.tcl
upgrade maturity to 2, such it is offered via "install from repository"

silence expected error messages in the log file during regression test

make sure to delete temporary objects

    • -2
    • +2
    ./packages/chat/tcl/xotcl-chat-procs.tcl
    • -2
    • +2
    ./packages/chat/tcl/test/chat-test-procs.tcl
flush dirty editor buffer

    • -1
    • +2
    ./packages/search/tcl/test/search-procs.tcl
fix typo and silence intended SQL error

    • -3
    • +6
    ./packages/search/tcl/test/search-procs.tcl
don't raise warnings on requests for non-existing pages

    • -4
    • +14
    ./packages/edit-this-page/tcl/etp-procs.tcl
Improved safety of memize call, improve warning message

    • -4
    • +6
    ./packages/edit-this-page/tcl/etp-procs.tcl
reduce verbosity

    • -2
    • +2
    ./packages/xotcl-core/tcl/cr-procs.tcl
Fix potential problems when calling polymorphic SQL functions from Tcl

Some functions are defined in the database with the same number of

arguments but different types, e.g., first argument "package_key"

(type text) or "package_id" (type integer). This is fine from the SQL

standpoint, but when calling from Tcl via bind-vars

(e.g. ":package_id"), everything is passed as a string, and

potentially, the wrong function is called.

Now, all the automatically generated subs are generated with casts,

when the integer based variant must be called.

Some examples:

Before:

set s [ns_pg_bind 0or1row $__DB {select apm__set_value(:package_id,:parameter_name,:attr_value)}]

set s [ns_pg_bind 0or1row $__DB {select apm__get_value(:package_id,:parameter_name)}]

Now:

set s [ns_pg_bind 0or1row $__DB {select apm__set_value(CAST(:package_id AS integer),:parameter_name,:attr_value)}]

set s [ns_pg_bind 0or1row $__DB {select apm__get_value(CAST(:package_id AS integer),:parameter_name)}]

- bumped version number to 5.10.1b11

    • -13
    • +110
    ./packages/acs-tcl/tcl/acs-db-12-procs.tcl
    • -2
    • +2
    ./packages/acs-tcl/tcl/utilities-procs.tcl
More function_args cleanup

- removed one more definition referring to a deleted function

- make sure we always get argument names via PostgreSQL

- aligned argument names with stubs (apm__set_value and apm__get_value)

- bumped version number to 5.10.1b7

file upgrade-5.10.1b6-5.10.1b7.sql was initially added on branch oacs-5-10.

removed duplicate define_function_args

made regression test more robust

The test was failing, when the preferred language in the browser

was not "en". The test is now slightly better, but one should

use CSS classes (or data attributes) to pick the bulk actions

    • -5
    • +26
    ./packages/file-storage/tcl/test/webtest-procs.tcl
cleanup of cmd '?'

fixed resource leak

    • -45
    • +45
    ./packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
reduced verbosity

    • -2
    • +2
    ./packages/acs-tcl/tcl/acs-cache-procs.tcl
fixed resource leaks

dom trees were not deleted

    • -1
    • +3
    ./packages/acs-lang/tcl/lang-catalog-procs.tcl
avoided duplicated loading of procs

moved functionality to automated testing

    • -28
    • +0
    ./packages/xotcl-core/tcl/test/xotcl-test-procs.tcl
Added automated testing for resource leaks

- new API function "aa_check_leftovers": This function is typically

called automatically at the end of every test case in

"aa_run_testcase" but it also makes sense to call it manually in

between of test cases.

- set aa_test_end to private (see no reason why this was public)

- bumped to 5.10.1b2

fixed leaked dom trees