• last updated 6 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Moved dotlrn permission kludges into a permission kludge callback, with

an implementation in dotlrn-lorsm. This keeps lorsm free of the dotlrn

specific permissions kludges while maintaining them within dotlrn (the only

supported way to add lorsm to a community or class is through the dotlrn-lorsm

applet package)

    • -4
    • +4
    ./packages/dotlrn-lorsm/dotlrn-lorsm.info
    • -0
    • +122
    ./packages/dotlrn-lorsm/tcl/dotlrn-lorsm-callback-procs.tcl
    • -0
    • +38
    ./packages/dotlrn-lorsm/tcl/dotlrn-lorsm-callback-procs.xql
    • -1
    • +15
    ./packages/lorsm/tcl/lorsm-callback-procs.tcl
    • -116
    • +9
    ./packages/lorsm/tcl/lorsm-import-procs.tcl
    • -118
    • +8
    ./packages/lorsm/www/admin/course-add-3.tcl
    • -38
    • +0
    ./packages/lorsm/www/admin/course-add-3.xql
Changed stupid dotlrn_users reference to users

    • -4
    • +4
    ./packages/lorsm/tcl/lorsm-callback-procs.tcl
Added "-include_self" boolean to the application group package search

procs.

Include the current dotlrn instance in the application group search, since

portlets run in that context and need their community id.

Fixed broken IMG SRC attribute URLs to the "completed" status flag icons.

Someone put white space in them, leading to the safari "blue ?" image not

found being displayed. Fortunately this was new on HEAD, not in 2.4.1.

    • -15
    • +8
    ./packages/lorsm/lib/user-lorsm.tcl
Changed constraint to fit our convention for abbreviation

Package extends change.

Moving to app group community id stuff (so lorsm can work outside .lrn), some

of this got committed accidently in an earlier bug fix commit.

    • -5
    • +5
    ./packages/lorsm/tcl/lorsm-import-procs.tcl
    • -10
    • +0
    ./packages/lorsm/tcl/lorsm-procs.xql
    • -2
    • +2
    ./packages/lorsm/www/delivery/applet.tcl
    • -2
    • +2
    ./packages/lorsm/www/delivery/body.tcl
    • -3
    • +2
    ./packages/lorsm/www/delivery/bottom.tcl
    • -3
    • +3
    ./packages/lorsm/www/delivery/index.tcl
    • -5
    • +7
    ./packages/lorsm/www/delivery/index.vuh
    • -4
    • +3
    ./packages/lorsm/www/delivery/menu-mk.tcl
  1. … 20 more files in changeset.
Fixed broken URL for admin'ing course permissions. This was broken as far

back as 2.4.1 for sure (UNED tested on their instance, too).

    • -3
    • +3
    ./packages/lorsm/www/admin/course-add-3.tcl
    • -3
    • +3
    ./packages/lorsm/www/admin/course-add.tcl
    • -2
    • +2
    ./packages/lorsm/www/admin/enabler.tcl
    • -2
    • +2
    ./packages/lorsm/www/admin/formater.tcl
    • -2
    • +2
    ./packages/lorsm/www/admin/tracker.tcl
    • -2
    • +2
    ./packages/lorsm/www/admin/tracking/index.tcl
  1. … 3 more files in changeset.
Partially fixed assessment for oracle.

Jeffd's new constraints had names too long for oracle.

Fixed daveb's connect by and nextval, for initial install and upgrade (change

to acs_group.new)

- fix typo in method-name 'value_if_nothing_is_returned_from_form'

- improve indexing, when a large number of tags is used

    • -4
    • +4
    ./packages/xowiki/tcl/form-field-procs.tcl
    • -1
    • +4
    ./packages/xowiki/tcl/xowiki-procs.tcl
    • -12
    • +15
    ./packages/xowiki/tcl/xowiki-www-procs.tcl
Update put the index creation before the table creation.

don't omit nls_language in forms when creating new pages

    • -4
    • +5
    ./packages/xowiki/tcl/xowiki-www-procs.tcl
typo

use content::extlink instead of the deprecated content_extlink:: api, add content::extlink::edit function

    • -2
    • +2
    ./packages/attachments/www/simple-add-2.tcl
    • -2
    • +2
    ./packages/dotlrn-fs/tcl/dotlrn-fs-procs.tcl
    • -2
    • +2
    ./packages/file-storage/www/simple-add-2.tcl
    • -2
    • +2
    ./packages/file-storage/www/simple-add.tcl
    • -3
    • +3
    ./packages/file-storage/www/simple-delete.tcl
    • -2
    • +2
    ./packages/file-storage/www/simple-edit.tcl
the arg is -paramter not -name to parameter::get_from_package_key, not sure how this ever worked...

    • -6
    • +6
    ./packages/acs-mail-lite/tcl/bounce-procs.tcl
improve documentation

    • -6
    • +34
    ./packages/xowiki/tcl/xowiki-www-procs.tcl
use parameter::get rather than ad_parameter

    • -2
    • +2
    ./packages/search/tcl/search-procs.tcl
    • -1
    • +1
    ./packages/search/www/advanced-search.tcl
get rid of the rest of the proc_doc calls

  1. … 5 more files in changeset.
- fixing string range parameter

- iterate over input and textarea

    • -2
    • +2
    ./packages/xowiki/tcl/xowiki-procs.tcl
    • -2
    • +7
    ./packages/xowiki/tcl/xowiki-www-procs.tcl
change all core proc_doc calls to ad_proc calls

    • -2
    • +2
    ./packages/acs-admin/tcl/apm-admin-procs.tcl
    • -3
    • +3
    ./packages/acs-tcl/tcl/apm-install-procs.tcl
    • -12
    • +12
    ./packages/acs-tcl/tcl/document-procs.tcl
    • -19
    • +19
    ./packages/acs-tcl/tcl/table-display-procs.tcl
    • -15
    • +15
    ./packages/acs-tcl/tcl/utilities-procs.tcl
    • -15
    • +15
    ./packages/acs-tcl/tcl/widgets-procs.tcl
print a call stack when emitting a deprecated/warn message

    • -2
    • +2
    ./packages/acs-tcl/tcl/utilities-procs.tcl
use template::multirow foreach rather that the deprecated version; fix template::multirow so it works when adp_level is undefined

    • -3
    • +3
    ./packages/acs-lang/tcl/lang-catalog-procs.tcl
    • -3
    • +6
    ./packages/acs-templating/tcl/query-procs.tcl
remove duplicate procs bounce_prefix and address_domain which live in incoming-mail-procs.tcl and bounce-procs.tcl

- Add two missing indices to improve performance of permission system

and the object context hierarchy significantly (these two indices

improved the performance of e.g. /projects/openacs/download/ and

/projects/openacs/download/one-revision?revision_id=2089636 by more

than a factor of 10; these indices are now among the most used on

openacs.org)

- Bump version number

- fix for the exponential time bug that brought down openacs.org on forum queries

    • -1
    • +49
    ./packages/acs-tcl/tcl/text-html-procs.tcl
Missing XQL files for insert group rels query

    • -0
    • +20
    ./packages/dotlrn/tcl/apm-callback-procs-oracle.xql
    • -0
    • +29
    ./packages/dotlrn/tcl/apm-callback-procs-postgresql.xql
    • -1
    • +4
    ./packages/dotlrn/tcl/apm-callback-procs.tcl
    • -3
    • +3
    ./packages/dotlrn/tcl/community-procs.tcl
    • -0
    • +6
    ./packages/dotlrn/tcl/community-procs.xql
remove old debug statement