• last updated 11 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fix handling of HTML comments in util_close_html_tags. Fixes bug #1386.

Moved setting of ad_conn subsite_id to the ad_conn proc itself, so it'll always be set, and not just for tcl/adp files

    • -13
    • +32
    ./tcl/request-processor-procs.tcl
  1. … 1 more file in changeset.
Changing most Returns to @return in proc docs

added test for @returns

Marked util_unlist public

Got rid of the 3 ds_comment's always present, and moved them into RP-info structure

    • -20
    • +20
    ./tcl/request-processor-procs.tcl
TODO comment

Don't pass in IP address to whos_online, it can grab it itself

- Count number of online users

- Started work to keep track of anonymous users online

Changed ad_quotehtml to use "string map", which is faster than the old

regexp approach. Thanks to Daniel Mantione...

Made templated server error page more robust against errors during parsing of the error page template

Make a copy of global errorInfo, otherwise it'll get overwritten before we get to use it

Fixed bug: global ad_to_sql/af_from_sql/af_to_html weren't global'd, causing ad_form to forget from call to call (e.g. when you -extend a form)

site_node::get_children - return element

Templated ad_return_complaint page

Experimental fix for login timeout problem

Templated another error page

Committed experimental fix for untrusted_user_id problem mentioned in forums posting at http://openacs.org/forums/message-view?message_id=152083

Templated some error pages

    • -0
    • +6
    ./lib/ad-return-error.adp
all TCL's clock clicks always with the -milliseconds option. The TCL manual

explicitly states that without this switch the return result is platform

dependant. The OpenACS code works at the millisecond granulartiy and silently

assumes that 1 millisecond equals 1000 clicks which is not necessarily true.

I used this shell script to automatize the replacing:

#!/bin/bash

for file in `grep -lsr "\[clock clicks\]" /web/openacs-head/packages/ `; do

echo "repairing $file"

sed "s/\[clock clicks\]/\[clock clicks -milliseconds\]/g" $file > fout

mv fout $file

done

And then grepped for

grep -r "expr.*clock clicks" /web/openacs-head/packages/

to manually remove the divisions by 1000.

    • -22
    • +22
    ./tcl/request-processor-procs.tcl
  1. … 7 more files in changeset.
Template the ad_page_contract complain page

Template the error page

    • -0
    • +17
    ./lib/page-error.adp
Added test case for ad_html_security_check_href_allowed

adding proc party::approved_members

Added util::randomize_list, including automated test case

Slight hack to make HTMLified text not have whitespace at the end

Allow -anchor switch to export_vars

add -public and -private for some procs, minor bug in acs_object::get some @see notes

  1. … 7 more files in changeset.
fix entity namespace default

Added util::array_list_spec_pretty proc