• last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Added an explicit blank body to two callbacks added by Malte, so automated

tests will pass. This is about the third release in which I've had to do

this. Simply adding "-" after the empty doc comment block is sufficient,

ad_proc treats that as an empty body.

Removed these two procs entirely, since a search of packages and contrib shows

that nothing in our tree uses them (and no package outside of acs-mail-lite

should've used them in the first place).

Use DCC header instead of the BCC one in call to ::smtp::sendmessage

Move complex_smtp to smtp. Mark ::sendmail and ::deliver_mail as deprecated

Upgrade scripts and fix datamodel consistency

  1. … 4 more files in changeset.
Remove duplicated proc

Remove unused queries. Remove from generic xql queries that are different for each db and already in the appropriate xql

Remove sendmail procs to use smtp only. Remove SendmailBin parameter (not used anymore)

    • -0
    • +34
    ./apm-callback-procs.tcl
  1. … 1 more file in changeset.
Replace send procs with a refactored version of complex_send, allowing cc, bcc and attachments

    • -23
    • +52
    ./acs-mail-lite-callback-procs.tcl
    • -25
    • +47
    ./acs-mail-lite-procs-oracle.xql
    • -25
    • +48
    ./acs-mail-lite-procs-postgresql.xql
  1. … 1 more file in changeset.
Update calls to utils procs adding the namespace

Move helper procs for sending email to acs-mail-lite

    • -0
    • +157
    ./utils-procs.tcl
  1. … 1 more file in changeset.
Rolling back to the working version (decided during informal OCT in IRC today)

  1. … 1 more file in changeset.
Add missing join

Fix typo, llength spelled incorrectly.

Cleaned up complex_send, broke it down into multiple parts, refactored repetitive things into foreach loops, made sure rollout support is handled in complex_smtp, thopugh I have no idea how to do the filters there.... This is in need of testing and should only act as a commit for the OCT to decide if this is going in the right direction.

Fix message initialization. Was failing in case the message has no alternative and no attachament. In case the message has an alternative and no attachment, it was initialized twice.

I think I fixed the problem with multipart/mixed of e-mails with no attachments. This should be tested though. I am putting this out to see if I might have a mismatch in my train of thought.

Fixed the confusion about single_email_p in complex_send_immediately using the defaults which make most sense. Fixed documentation accordingly

Fix malformed date and encode subject (using helper procs). Set the charset for message body (utf-8)

Turn ds_comment into ns_log debug

Indent code

Fixed the cmd_string

Fixed bug with missing mail_package_id variable

Merged 5.3 to HEAD

  1. … 60 more files in changeset.
Added checking for valid emails and record bounces when the email is not valid

Fixing minor bugs with regards to parameters and started to split up the code a little bit more to make it readable

Remove duplicated proc with_finally (also exists in acs-tcl/tcl/utilities-procs.tcl) and remove unnecessary with_finally block in the sweeper procs

Catch errors when sweeping the mail queue to avoid notifications to remain unsent until the bad message has been manually removed. With the catch, the bad message remains in the queue and an error message sent to the log, and the sweeper proceeds with the next ones.

Applied patch #841 fixes bug #3087

Made sure that you are only sending if the to_addr is not empty after working on it