• last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
- Thanks to the invaluable help from daveb, custom fields now working,

including updating of values, which wasn't working in the original version,

so fixed that bug too.

- Revert widget-procs.tcl to generating template::element calls instead

of an ad_form -extend block, because that gives users customizing the

package (in the future) to have their own -validate block in the

ad_forms present.

    • -4
    • +4
    ./classified-ads/tcl/classified-ads-init.tcl
    • -8
    • +2
    ./classified-ads/tcl/classified-ads-procs.tcl
    • -45
    • +26
    ./classified-ads/tcl/widget-procs.tcl
- Problems with ad_form (custom element not visible)

- Modified get_widget_param to generate ad_form statements instead of

template::element::create in attempt to fix the problem. Worked partially.

- Modified ad-one accordingly.

Now the problem seems to be that a custom element is available in the

-edit_request block, but for some reaons that element (which was

added through ad_form -extend) is not available in the -edit_data block.

Does anyone know why??

    • -2
    • +14
    ./classified-ads/tcl/classified-ads-procs.tcl
    • -27
    • +46
    ./classified-ads/tcl/widget-procs.tcl
    • -8
    • +16
    ./classified-ads/www/admin/ad-one.tcl
- Remove unneeded query.

- Fixed bug I introduced in ::ads::get

- Per-category custom field support added.

- ad-one and ad-new doing the right thing with custom fields.

    • -26
    • +49
    ./classified-ads/tcl/widget-procs.tcl
- Added support for per-category custom fields.

- Modified create files accordingly.

- No update scripts yet.

- Can't remember what I fixed here.

    • -7
    • +7
    ./classified-ads/tcl/classified-ads-procs.tcl
- Changed ns_log notice -> Debug

- Reformatted a bit for legibility.

    • -10
    • +23
    ./classified-ads/tcl/classified-ads-init.tcl
- Continuing to improve UI

- ad-delete now ad_form with confirmation

- ad-one handles deletion correctly

- Updated TODO.

    • -12
    • +10
    ./classified-ads/tcl/ads-procs.tcl
    • -701
    • +705
    ./classified-ads/tcl/classified-ads-procs.tcl
    • -0
    • +6
    ./classified-ads/www/admin/ad-delete.adp
    • -15
    • +30
    ./classified-ads/www/admin/ad-delete.tcl
    • -16
    • +17
    ./classified-ads/www/admin/ad-one.tcl
- Updated user categories page. Not final.

- Moved posgresql-specific queries to field-addedit-postgresql.xql

- Update TODO in documentation.

    • -47
    • +120
    ./classified-ads/www/categories.adp
    • -1
    • +2
    ./classified-ads/www/admin/categories.tcl
    • -0
    • +16
    ./classified-ads/www/admin/field-addedit-postgresql.xql
    • -12
    • +0
    ./classified-ads/www/admin/field-addedit.xql
- Added procs to get context trail for ads.

- ad_one displays and edits ads.

- ad-delete with confirmation (still needs work).

- categories.* now link ads to ad-one

- Everything ad_form'ized.

    • -3
    • +4
    ./classified-ads/tcl/categories-procs.tcl
    • -10
    • +24
    ./classified-ads/www/admin/ad-delete.tcl
    • -0
    • +6
    ./classified-ads/www/admin/ad-one.adp
    • -0
    • +83
    ./classified-ads/www/admin/ad-one.tcl
    • -2
    • +2
    ./classified-ads/www/admin/categories.adp
- Fixing ads::new

- Reformatted classified-ads-procs.tcl for legibility

- ad-new will be merged into ad-one which will take care of adding,

editing and displaying ads.

- Improved category administration.

    • -11
    • +0
    ./classified-ads/tcl/ads-procs-postgresql.xql
    • -114
    • +84
    ./classified-ads/tcl/classified-ads-procs.tcl
    • -6
    • +13
    ./classified-ads/www/admin/ad-new.tcl
    • -11
    • +11
    ./classified-ads/www/admin/categories.adp
- Updated .info file

- Converted category-new and ad-new to use ad_form, hence getting rid of

a couple FIXME's.

    • -100
    • +9
    ./classified-ads/classified-ads.info
    • -58
    • +25
    ./classified-ads/www/admin/ad-new.tcl
- Made assigned and unassigned ads return published date.

- Placing new ads now lets you know which category it's going into.

- More improvements to field-addedit

- Updated TODO

- Removed category-assign-2, since it had no point and to have

consistent behavior with category-remove

- Much better admin UI to manage categories and ads.

    • -3
    • +27
    ./classified-ads/www/admin/ad-new.tcl
    • -24
    • +80
    ./classified-ads/www/admin/categories.adp
    • -16
    • +0
    ./classified-ads/www/admin/category-assign-2.tcl
    • -13
    • +0
    ./classified-ads/www/admin/category-assign.adp
    • -10
    • +5
    ./classified-ads/www/admin/category-assign.tcl
- Improving categories UI.

- Improved documentation.

- Improved how ads are assigned to categories.

    • -10
    • +48
    ./classified-ads/www/admin/categories.adp
    • -4
    • +7
    ./classified-ads/www/admin/categories.tcl
    • -2
    • +1
    ./classified-ads/www/admin/category-assign.adp
    • -57
    • +27
    ./classified-ads/www/admin/category-new.tcl
- Improved categories page (still need a prettier UI)

- Improved documentation to filed-addedit

- Added proc to verify ISBN numbers.

    • -5
    • +30
    ./classified-ads/tcl/classified-ads-procs.tcl
    • -23
    • +29
    ./classified-ads/www/categories.adp
    • -1
    • +1
    ./classified-ads/www/admin/field-addedit.adp
- Initial revision of the classified-ads package written by Deds Castillo

and Paul Doerwalds.

- Some modifications and improvements by Roberto Mello.

- Added Bugs and Features to the www/doc/index page.

- Will be committing more changes soon.

    • -0
    • +120
    ./classified-ads/classified-ads.info
    • -0
    • +67
    ./classified-ads/sql/postgresql/ads-create.sql
    • -0
    • +54
    ./classified-ads/sql/postgresql/ads-drop.sql
    • -0
    • +40
    ./classified-ads/sql/postgresql/ads-package-create.sql
    • -0
    • +8
    ./classified-ads/sql/postgresql/ads-package-drop.sql
    • -0
    • +102
    ./classified-ads/sql/postgresql/attributes-create.sql
    • -0
    • +11
    ./classified-ads/sql/postgresql/attributes-drop.sql
    • -0
    • +270
    ./classified-ads/sql/postgresql/attributes-package-create.sql
    • -0
    • +13
    ./classified-ads/sql/postgresql/attributes-package-drop.sql
    • -0
    • +25
    ./classified-ads/sql/postgresql/classified-ads-create.sql
    • -0
    • +25
    ./classified-ads/sql/postgresql/classified-ads-drop.sql
    • -0
    • +53
    ./classified-ads/sql/postgresql/cr-classifieds-create.sql
    • -0
    • +75
    ./classified-ads/sql/postgresql/cr-classifieds-drop.sql
    • -0
    • +58
    ./classified-ads/sql/postgresql/cr-classifieds-package-create.sql
    • -0
    • +9
    ./classified-ads/sql/postgresql/cr-classifieds-package-drop.sql
  1. … 63 more files in changeset.
Remove old file.

    • -28
    • +0
    ./general-comments/www/comment-ae-2.adp
Remove comment-edit files, add replacement add-edit files.

    • -0
    • +27
    ./general-comments/www/comment-add-edit-oracle.xql
    • -43
    • +0
    ./general-comments/www/comment-edit-2.tcl
    • -47
    • +0
    ./general-comments/www/comment-edit-3-oracle.xql
    • -52
    • +0
    ./general-comments/www/comment-edit-3-postgresql.xql
    • -57
    • +0
    ./general-comments/www/comment-edit-3.tcl
    • -13
    • +0
    ./general-comments/www/comment-edit-oracle.xql
    • -13
    • +0
    ./general-comments/www/comment-edit-postgresql.xql
    • -1
    • +1
    ./general-comments/www/url-add-edit.tcl
    • -2
    • +2
    ./general-comments/www/view-comment-oracle.xql
    • -2
    • +2
    ./general-comments/www/view-comment-postgresql.xql
    • -66
    • +7
    ./general-comments/www/view-comment.tcl
    • -1
    • +1
    ./general-comments/www/view-comment.xql
Remove generic xql file, move to database specific xql. Comment-add-edit now

works for add and edit.

    • -0
    • +25
    ./general-comments/www/comment-add-edit-postgresql.xql
    • -15
    • +31
    ./general-comments/www/comment-add-edit.tcl
    • -20
    • +0
    ./general-comments/www/comment-add-edit.xql
Added xql file. Fixed datamodel to reflect general_comments subtype of

content_item. Added plsql api for adding a new revision of a comment.

    • -82
    • +117
    ./general-comments/sql/postgresql/general-comments-plsql-create.sql
    • -1
    • +1
    ./general-comments/tcl/general-comments-procs-postgresql.xql
    • -5
    • +5
    ./general-comments/tcl/general-comments-procs.tcl
    • -0
    • +20
    ./general-comments/www/comment-add-edit.xql
General_comments references cr_items. None of the attributes in general_comments should be versioned.

Fix noquote problems. Move comment-edit.xql to comment-add-edit.xql

    • -4
    • +10
    ./general-comments/www/comment-add-edit.tcl
    • -20
    • +0
    ./general-comments/www/comment-edit.xql
    • -2
    • +2
    ./general-comments/www/admin/index.adp
Recover lost file.

    • -1
    • +129
    ./general-comments/www/comment-add-edit.tcl
    • -0
    • +0
    ./general-comments/www/comment-add.tcl
Adding missing adp file.

    • -0
    • +1
    ./general-comments/www/comment-add-edit.adp
Moved to comment-add-edit.

    • -0
    • +1
    ./general-comments/www/comment-add-edit.tcl
    • -1
    • +0
    ./general-comments/www/comment-add.adp
Rename comment-add to comment add-edit. Using ad_form one can do add and edit.

    • -129
    • +0
    ./general-comments/www/comment-add.tcl
    • -0
    • +2
    ./general-comments/www/url-add-edit.tcl
Added database specific xql files for url add/edit.

    • -25
    • +0
    ./general-comments/www/url-add-2-oracle.xql
    • -0
    • +25
    ./general-comments/www/url-add-edit-oracle.xql
    • -0
    • +31
    ./general-comments/www/url-add-edit-postgresql.xql
Replaced seperate url add and edit files with url-add-edit ad_form based

script.

    • -31
    • +0
    ./general-comments/www/url-add-2-postgresql.xql
    • -54
    • +0
    ./general-comments/www/url-add-2.tcl
    • -4
    • +18
    ./general-comments/www/url-add-edit.tcl
    • -0
    • +13
    ./general-comments/www/url-add-edit.xql
    • -34
    • +0
    ./general-comments/www/url-edit-2.tcl
    • -16
    • +0
    ./general-comments/www/url-edit-2.xql
    • -40
    • +0
    ./general-comments/www/url-edit.tcl
Update form to use ad_form, combine add and edit into one tcl/adp pair.

    • -0
    • +5
    ./general-comments/www/url-add-edit.adp
    • -0
    • +83
    ./general-comments/www/url-add-edit.tcl
    • -0
    • +14
    ./general-comments/www/url-add-edit.xql
Move adp file too!

    • -0
    • +8
    ./general-comments/templates/comments.adp