OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 6
Total Committers: 146
Last Commit: 21 Nov
Commits this week: 6
Total Lines of Code (LoC): 7,560,943
Net change in LoC this week: 122

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 19 Jul 2018
1:43 pm

gustafn

improve testcases by removing useless expr commands

Options
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
    • -7
    • +7
    /openacs-4/packages/acs-tcl/tcl/test/ad-proc-test-procs.tcl
    • -14
    • +14
    /openacs-4/packages/acs-tcl/tcl/test/application-data-link-procs.tcl
    • -3
    • +6
    /openacs-4/packages/acs-tcl/tcl/test/doc-check-procs.tcl
    • -16
    • +16
    /openacs-4/packages/acs-tcl/tcl/test/test-permissions-procs.tcl
    • -5
    • +5
    /openacs-4/packages/acs-tcl/tcl/test/whos-online-procs.tcl
1:42 pm

gustafn

make feedback from testruns nicer (remove redundant messages)

Options
    • -10
    • +8
    /openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
1:17 pm

antoniop

Declass constraint names breaking the very strict OpenACS naming convention from errors to warnings

Rationale: it is sometimes impossible to have constraint names that are both < 30 chars and consistent with the naming scheme 'table_name'_'column_name'_'constraint_type' for all those defined on a particular table (see e.g. acs_named_objects).

Breaking this convention might be suboptimal, but is not harmful in itself.

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/test/datamodel-test-procs.tcl
12:17 pm

gustafn

flush per-request cache (fixes regression test properly)

Options
    • -1
    • +6
    /openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
12:16 pm

gustafn

simplify code

Options
    • -3
    • +2
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-apm-procs.tcl
11:59 am

gustafn

improve testcase viewing page:

- use syntax highlighting to testcase body

- fix label for body:

* just use numbering when appropriate

* start numbering of bodies with 1

Options
    • -2
    • +3
    /openacs-4/packages/acs-automated-testing/www/admin/testcase.adp
    • -12
    • +11
    /openacs-4/packages/acs-automated-testing/www/admin/testcase.tcl
11:55 am

gustafn

improve test cases: align comment with operations, remove useless "expr" commands

Options
    • -25
    • +26
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-apm-procs.tcl
11:52 am

gustafn

improve log message to be able to distinguish between multiple commands with different parameters

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
11:09 am

antoniop

Make string_truncate behave as before (looking for spaces at end_position + 1) and therefore not breaking tests for ad_html_text_convert. Update docs so this property of being less or equal than len is clearly specified

Options
    • -13
    • +5
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
10:20 am

antoniop

Revert change... more investigation needed

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
9:59 am

antoniop

Trim whitespace

Options
    • -34
    • +33
    /openacs-4/packages/acs-tcl/tcl/acs-cache-procs.tcl
9:57 am

antoniop

node_id shoudl probably be parent_id (fixes automated tests)

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
9:45 am

antoniop

Trim whitespace

Options
    • -10
    • +10
    /openacs-4/packages/acs-tcl/tcl/test/site-nodes-test-procs.tcl
12:33 am

gustafn

improve startuptime for large sites

Options
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/xowf-init.tcl
    • -1
    • +3
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
    • -0
    • +4
    /openacs-4/packages/xowf/tcl/test/xowf-test-procs.tcl
Wednesday 18 Jul 2018
8:54 pm

hectorr

Whitespace cleanup

Options
    • -22
    • +22
    /openacs-4/packages/acs-tcl/tcl/test/html-conversion-procs.tcl
8:51 pm

hectorr

Add '-equal' parameter to 'string_truncate', which allows to truncate a string to a length shorter or *equal* than a specified length.

The fact that 'string_truncate' was producing strings strictly shorter than the specified length, was making the behavior of 'ad_html_text_convert' inconsistent, and breaking automated tests.

This small addition fixes both the behavior and the tests, while retaining compatibility.

Options
    • -4
    • +13
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
7:26 pm

hectorr

Add 'Markdown' tests for 'ad_html_text_convert'

Options
    • -0
    • +14
    /openacs-4/packages/acs-tcl/tcl/test/html-conversion-procs.tcl
7:09 pm

antoniop

Replace deprecated header_stuff with head

Options
    • -1
    • +1
    /openacs-4/packages/news-aggregator/www/index.adp
7:08 pm

antoniop

Give some feedback in case of error

Options
    • -5
    • +8
    /openacs-4/packages/news-aggregator/www/opml.tcl
7:04 pm

antoniop

Repair broken opml export, exploit new api to streamline query, fix typo

Options
    • -17
    • +0
    /openacs-4/packages/news-aggregator/tcl/aggregator-procs-postgresql.xql
    • -6
    • +22
    /openacs-4/packages/news-aggregator/tcl/aggregator-procs.tcl
6:41 pm

antoniop

Return 0 also when a default is there but is the empty string

Options
    • -1
    • +1
    /openacs-4/packages/news-aggregator/tcl/aggregator-procs.tcl
6:36 pm

antoniop

Bring other sql inline, simplify idioms

Options
    • -49
    • +0
    /openacs-4/packages/news-aggregator/tcl/aggregator-procs-postgresql.xql
    • -18
    • +35
    /openacs-4/packages/news-aggregator/tcl/aggregator-procs.tcl
6:23 pm

antoniop

Bring sql for this proc inline, remove unused statements

Options
    • -41
    • +0
    /openacs-4/packages/news-aggregator/tcl/aggregator-procs-postgresql.xql
    • -6
    • +19
    /openacs-4/packages/news-aggregator/tcl/aggregator-procs.tcl
6:13 pm

antoniop

Document public procs (fixes automated tests), rework code, remove leftover statements

Options
    • -3
    • +8
    /openacs-4/packages/news-aggregator/tcl/aggregator-procs.tcl
    • -21
    • +4
    /openacs-4/packages/news-aggregator/tcl/aggregator-procs.xql
    • -0
    • +5
    /openacs-4/packages/news-aggregator/tcl/subscription-procs.tcl
5:43 pm

antoniop

Modernize tcl

Options
    • -9
    • +8
    /openacs-4/packages/news-aggregator/www/index.vuh
4:11 pm

antoniop

Trim whitespace

Options
    • -4
    • +1
    /openacs-4/packages/news-aggregator/tcl/news-aggregator-procs.tcl
4:09 pm

antoniop

Remove obsolete xql files

Options
    • -34
    • +0
    /openacs-4/packages/news-aggregator/tcl/subscription-procs-postgresql.xql
    • -32
    • +0
    /openacs-4/packages/news-aggregator/tcl/subscription-procs.xql
4:08 pm

antoniop

Make all sql portable and bring it in line, remove code duplication

Options
    • -5
    • +30
    /openacs-4/packages/news-aggregator/tcl/subscription-procs.tcl
3:51 pm

antoniop

Further UI fixing after tests to make so that actions are displayed only when the proper conditions are met

Options
    • -2
    • +4
    /openacs-4/packages/news-aggregator/www/index.adp
    • -8
    • +13
    /openacs-4/packages/news-aggregator/www/index.tcl
3:36 pm

antoniop

Revision of the index page:

- pass template properties according to conventions

- streamline boolean expressions

- fix UI, show purge button and its explanation when the actual form is generated

- make sql portable and bring it inline

- better exploit api

Options
    • -36
    • +0
    /openacs-4/packages/news-aggregator/www/index-postgresql.xql
    • -8
    • +16
    /openacs-4/packages/news-aggregator/www/index.adp
    • -50
    • +43
    /openacs-4/packages/news-aggregator/www/index.tcl
    • -14
    • +0
    /openacs-4/packages/news-aggregator/www/index.xql