OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 6
Total Committers: 146
Last Commit: 21 Nov
Commits this week: 6
Total Lines of Code (LoC): 7,560,943
Net change in LoC this week: 122

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 52 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 14 Jun 2018
11:16 am

gustafn

Use subst instead of string quoting to improve readability (syntax highlighting)

Drop -postgresql.xql for "create_table" since there is no -oracle.xql and the -postgresql.xql is identical to inline code.

Options
    • -18
    • +0
    /openacs-4/packages/acs-subsite/tcl/group-type-procs-postgresql.xql
    • -12
    • +13
    /openacs-4/packages/acs-subsite/tcl/group-type-procs.tcl
    • -11
    • +0
    /openacs-4/packages/acs-subsite/tcl/rel-types-procs-postgresql.xql
    • -11
    • +10
    /openacs-4/packages/acs-subsite/tcl/rel-types-procs.tcl
10:46 am

gustafn

make code more robust, when connection is already closed

Options
    • -1
    • +2
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
Wednesday 13 Jun 2018
6:37 pm

antoniop

fix non-existing call to dotlrn_community::type_exists

Options
    • -8
    • +7
    /openacs-4/packages/dotlrn/www/admin/community-type.tcl
6:27 pm

antoniop

Remove duplicated queries and logic, simplify idioms

Options
    • -168
    • +5
    /openacs-4/packages/dotlrn/www/communities-chunk-oracle.xql
    • -188
    • +6
    /openacs-4/packages/dotlrn/www/communities-chunk-postgresql.xql
    • -1
    • +1
    /openacs-4/packages/dotlrn/www/communities-chunk.adp
    • -18
    • +11
    /openacs-4/packages/dotlrn/www/communities-chunk.tcl
5:16 pm

antoniop

Remove sql that was not effective since 2004 (http://cvs.openacs.org/changelog/OpenACS?cs=dotlrn-2-0%3Adonb%3A20040321010640)

Options
    • -30
    • +0
    /openacs-4/packages/fs-portlet/www/fs-contents-portlet-oracle.xql
    • -33
    • +0
    /openacs-4/packages/fs-portlet/www/fs-contents-portlet-postgresql.xql
4:55 pm

antoniop

Remove redundant query definitions

Options
    • -19
    • +0
    /openacs-4/packages/acs-mail-lite/tcl/acs-mail-lite-procs-oracle.xql
    • -20
    • +0
    /openacs-4/packages/acs-mail-lite/tcl/acs-mail-lite-procs-postgresql.xql
4:22 pm

antoniop

Make filters consistent with what the list displays (approved means live_revision not nulll and latest revision = live_revision)

Options
    • -6
    • +4
    /openacs-4/packages/general-comments/www/index.xql
4:14 pm

antoniop

UI improvements and fix

- make sql portable

- bring all sql inline

- reduce query duplication

- simplify if idioms

- fix UI by unclobbering revision_id variable and allowing to select revision correctly

Options
    • -64
    • +0
    /openacs-4/packages/general-comments/www/view-comment-oracle.xql
    • -63
    • +0
    /openacs-4/packages/general-comments/www/view-comment-postgresql.xql
    • -32
    • +47
    /openacs-4/packages/general-comments/www/view-comment.tcl
    • -55
    • +0
    /openacs-4/packages/general-comments/www/view-comment.xql
3:40 pm

antoniop

Improvement and fixes for this UI

- improve localization

- exploit builtin multirow feature

- reduce divergencies between oracle and postgres codebase

- remove unused sql columns

- invert boolean logics for approved and live to reflect sql clause behavior

Options
    • -30
    • +0
    /openacs-4/packages/general-comments/www/index-oracle.xql
    • -28
    • +0
    /openacs-4/packages/general-comments/www/index-postgresql.xql
    • -11
    • +10
    /openacs-4/packages/general-comments/www/index.tcl
    • -0
    • +22
    /openacs-4/packages/general-comments/www/index.xql
1:43 pm

hectorr

Whitespace changes

Options
    • -12
    • +12
    /openacs-4/packages/assessment/tcl/as-item-answer-procs.tcl
    • -50
    • +50
    /openacs-4/packages/assessment/tcl/as-item-choice-procs.tcl
1:39 pm

hectorr

Fix duplicated words

Options
    • -1
    • +1
    /openacs-4/packages/assessment/tcl/as-item-answer-procs.tcl
    • -1
    • +1
    /openacs-4/packages/assessment/tcl/as-item-choice-procs.tcl
    • -2
    • +2
    /openacs-4/packages/cookie-consent/tcl/cookie-consent-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xotcl-core/tcl/50-protocol-handler-procs.tcl
1:14 pm

antoniop

Bugfix

forcing this db_multirow to be executed, I found out {} idiom was missing and therefore shadowing extended columns to the template::list

Options
    • -3
    • +4
    /openacs-4/packages/fs-portlet/www/fs-portlet.tcl
1:13 pm

hectorr

Remove duplicated words

Options
    • -1
    • +1
    /openacs-4/packages/acs-subsite/www/resources/core.js
    • -2
    • +2
    /openacs-4/packages/acs-templating/acs-templating.info
12:07 pm

antoniop

Use more portable sql idioms and simplify query using api, remove unused query

Options
    • -30
    • +4
    /openacs-4/packages/fs-portlet/www/fs-portlet-oracle.xql
    • -37
    • +5
    /openacs-4/packages/fs-portlet/www/fs-portlet-postgresql.xql
    • -6
    • +4
    /openacs-4/packages/fs-portlet/www/fs-portlet.tcl
9:39 am

gustafn

remove unreferences and broken files depending on data model changed more than 10 years ago

Options
    • -69
    • +0
    /openacs-4/packages/acs-admin/www/apm/version-parameter-values.tcl
    • -34
    • +0
    /openacs-4/packages/acs-admin/www/apm/version-parameter-values.xql
9:28 am

gustafn

fix adp expressions

Options
    • -1
    • +1
    /openacs-4/packages/acs-lang/www/admin/batch-editor.adp
    • -1
    • +1
    /openacs-4/packages/notifications/www/subscribers.adp
    • -2
    • +2
    /openacs-4/packages/xowiki/www/xinha/insert-wlink.adp
Tuesday 12 Jun 2018
4:27 pm

antoniop

Fix regression when checking member state

Options
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/users/member-state-change.tcl
11:29 am

gustafn

replace calls to depreacted proc "fs::remove_special_file_system_characters"

Options
    • -3
    • +2
    /openacs-4/packages/lorsm/www/delivery/menu-mk.tcl
    • -3
    • +2
    /openacs-4/packages/lorsm/www/delivery/menu.tcl
    • -4
    • +2
    /openacs-4/packages/lorsm/www/delivery-scorm/menu.tcl
    • -4
    • +5
    /openacs-4/packages/survey-reports/www/index.tcl
11:13 am

gustafn

replace calls to depreacted proc "fs::remove_special_file_system_characters"

Options
    • -4
    • +4
    /openacs-4/packages/acs-templating/www/scripts/xinha/file-selector.tcl
    • -4
    • +4
    /openacs-4/packages/xowiki/www/xinha/file-selector.tcl
    • -4
    • +4
    /openacs-4/packages/acs-templating/www/resources/xinha-nightly/plugins/OacsFs/popups/file-selector.tcl
    • -4
    • +4
    /openacs-4/packages/richtext-xinha/www/resources/xinha-nightly/plugins/OacsFs/popups/file-selector.tcl
11:07 am

gustafn

always use @see when procs are deprecated to show, what to use instead

Options
    • -2
    • +4
    /openacs-4/packages/file-storage/tcl/file-storage-procs.tcl
10:54 am

gustafn

removing uncalled pages based on non-existing tables and on deprecated calls

Options
    • -72
    • +0
    /openacs-4/packages/acs-admin/www/users/session-history.tcl
    • -60
    • +0
    /openacs-4/packages/acs-admin/www/users/sessions-one-month.tcl
10:39 am

gustafn

content-portlet/www/resources/calendar-full-portlet.tcl was actually content-portlet/www/resources/up.png

Options
    • -14
    • +0
    /openacs-4/packages/content-portlet/www/resources/calendar-full-portlet.tcl
10:33 am

gustafn

only lowercase proc meta-data is recognized

Options
    • -1
    • +3
    /openacs-4/packages/acs-developer-support/www/shell.tcl
    • -2
    • +2
    /openacs-4/packages/workflow/tcl/role-procs.tcl
10:29 am

gustafn

only lowercase meta-data is recognized

Options
    • -3
    • +3
    /openacs-4/packages/acs-mail-lite/tcl/bounce-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-mail-lite/tcl/incoming-mail-procs.tcl
10:09 am

gustafn

improve Tcl code

Options
    • -7
    • +6
    /openacs-4/packages/acs-mail-lite/tcl/imap-inbound-procs.tcl
    • -5
    • +5
    /openacs-4/packages/acs-mail-lite/tcl/maildir-inbound-procs.tcl
9:59 am

gustafn

acs_mail_lite::incoming_email calls deprecated acs_mail_lite::parse_bounce_address. Comment, that this should not stay so.

Options
    • -1
    • +12
    /openacs-4/packages/acs-mail-lite/tcl/acs-mail-lite-callback-procs.tcl
12:04 am

gustafn

move template cacheing function "cache" into template namespace (resulting in template::cache)

Options
    • -11
    • +11
    /openacs-4/packages/acs-templating/tcl/paginator-procs.tcl
    • -6
    • +6
    /openacs-4/packages/acs-templating/tcl/query-procs.tcl
    • -2
    • +2
    /openacs-4/packages/forums/tcl/forums-procs.tcl
12:02 am

gustafn

modernize tcl idioms

Options
    • -2
    • +2
    /openacs-4/packages/acs-templating/tcl/list-procs.tcl
12:00 am

gustafn

remove obsolete page "paramter-set" as indicated by vguerra several years ago

Options
    • -37
    • +0
    /openacs-4/packages/acs-subsite/www/admin/site-map/parameter-set-2.tcl
    • -14
    • +0
    /openacs-4/packages/acs-subsite/www/admin/site-map/parameter-set-2.xql
    • -15
    • +0
    /openacs-4/packages/acs-subsite/www/admin/site-map/parameter-set-oracle.xql
    • -15
    • +0
    /openacs-4/packages/acs-subsite/www/admin/site-map/parameter-set-postgresql.xql
    • -5
    • +0
    /openacs-4/packages/acs-subsite/www/admin/site-map/parameter-set.adp
    • -106
    • +0
    /openacs-4/packages/acs-subsite/www/admin/site-map/parameter-set.tcl
    • -23
    • +0
    /openacs-4/packages/acs-subsite/www/admin/site-map/parameter-set.xql
Monday 11 Jun 2018
10:51 pm

gustafn

make code more robust against invalid input

Options
    • -2
    • +6
    /openacs-4/packages/xotcl-core/tcl/03-doc-procs.tcl