OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 6
Total Committers: 146
Last Commit: 21 Nov
Commits this week: 6
Total Lines of Code (LoC): 7,560,943
Net change in LoC this week: 122

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 06 Nov 2013
8:33 am

gustafn

- brace expressions

- favor tcl-compilable string comparisons

- replace deprecated "ad_get_user_id" by "ad_conn user_id"

- replace deprecated "export_url_vars" by "export_vars"

- replace deprecated "export_form_vars" by "export_vars"

- replace deprecated "philg_quote_double_quotes" "by ad_quotehtml"

- replace deprecated "ad_parameter" by "parameter::get"

- replace deprecated "ad_require_permission" by "permission::require_permission"

- use $$ quoting in postgres SQL

- use named parameters for SQL functions

- provide compatility with pg9

- fix/complete define_function_args

- bumped version number to 5.8.0

Options
    • -2
    • +2
    /openacs-4/packages/survey/survey.info
    • -7
    • +7
    /openacs-4/packages/survey/lib/portlet.tcl
    • -151
    • +254
    /openacs-4/packages/survey/sql/postgresql/survey-create.sql
    • -27
    • +27
    /openacs-4/packages/survey/sql/postgresql/survey-drop.sql
    • -16
    • +22
    /openacs-4/packages/survey/sql/postgresql/survey-notifications-drop.sql
    • -25
    • +31
    /openacs-4/packages/survey/sql/postgresql/survey-notifications-init.sql
    • -31
    • +31
    /openacs-4/packages/survey/tcl/survey-procs.tcl
    • -2
    • +2
    /openacs-4/packages/survey/www/index.tcl
    • -2
    • +2
    /openacs-4/packages/survey/www/one-respondent.tcl
    • -3
    • +3
    /openacs-4/packages/survey/www/one-survey.tcl
    • -22
    • +22
    /openacs-4/packages/survey/www/process-response.tcl
    • -5
    • +5
    /openacs-4/packages/survey/www/respond.tcl
    • -2
    • +2
    /openacs-4/packages/survey/www/view-attachment.tcl
    • -4
    • +4
    /openacs-4/packages/survey/www/admin/description-edit.tcl
    • -2
    • +2
    /openacs-4/packages/survey/www/admin/index.tcl
  16. … 36 more files in changeset.
Saturday 02 Nov 2013
8:11 pm

gustafn

- change exception to a warning to get rid of error message when xotcl-core or dependent packages are installed the frist time from repository or local

Options
    • -2
    • +6
    /openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl
7:26 pm

gustafn

- move initialization of nsv_arrays for apm

from -proc file of bootstapper to -init file in acs-tcl

(as suggested by Peter Marklund, but never implemented)

- protect rename of "exec" against multiple renamings

- bump version number to 5.8.1d3

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -0
    • +13
    /openacs-4/packages/acs-tcl/tcl/apm-init.tcl
    • -3
    • +4
    /openacs-4/packages/acs-tcl/tcl/proxy-procs.tcl
7:26 pm

gustafn

file apm-init.tcl was initially added on branch oacs-5-8.

Options
    • -0
    • +0
    /openacs-4/packages/acs-tcl/tcl/apm-init.tcl
7:18 pm

gustafn

- allow to upgrade basic startup files (openacs-4/tcl/*tcl)

to be upgraded via "install from repository" by adding

and after-upgrade callback to bootstrap-installer and

copying the files from there.

- move initialization of nsv_arrays for apm to -init file in acs-tcl

(as suggested by Peter Marklund, but never implemented)

- use double colon prefix rather than "global" statement

to denote global variables

- bump version number to 5.8.1d3

Options
    • -10
    • +8
    /openacs-4/packages/acs-bootstrap-installer/acs-bootstrap-installer.info
    • -0
    • +51
    /openacs-4/packages/acs-bootstrap-installer/installer/tcl/0-acs-init.tcl
    • -0
    • +53
    /openacs-4/packages/acs-bootstrap-installer/installer/tcl/zz-postload.tcl
    • -19
    • +20
    /openacs-4/packages/acs-bootstrap-installer/tcl/30-apm-load-procs.tcl
7:18 pm

gustafn

file 0-acs-init.tcl was initially added on branch oacs-5-8.

Options
    • -0
    • +0
    /openacs-4/packages/acs-bootstrap-installer/installer/tcl/0-acs-init.tcl
7:18 pm

gustafn

file zz-postload.tcl was initially added on branch oacs-5-8.

Options
    • -0
    • +0
    /openacs-4/packages/acs-bootstrap-installer/installer/tcl/zz-postload.tcl
5:15 pm

gustafn

- use $$ quoting in postgres SQL

- use named parameters for SQL functions

- fix/complete define_function_args

- fix return type of trigger

- brace expressions

- favor tcl-compilable string comparisons

- bump version number

Options
    • -2
    • +2
    /openacs-4/packages/views/views.info
    • -2
    • +2
    /openacs-4/packages/views/lib/views-chunk.tcl
    • -14
    • +28
    /openacs-4/packages/views/sql/postgresql/views-procs.sql
    • -13
    • +17
    /openacs-4/packages/views/sql/postgresql/views-triggers.sql
    • -13
    • +22
    /openacs-4/packages/views/sql/postgresql/upgrade/upgrade-0.1d-0.1d2.sql
    • -26
    • +47
    /openacs-4/packages/views/sql/postgresql/upgrade/upgrade-0.1d2-0.1d3.sql
    • -10
    • +10
    /openacs-4/packages/views/tcl/test/views-procs.tcl
5:08 pm

gustafn

- use $$ quoting in postgres SQL

- use named parameters for SQL functions

- fix/complete define_function_args

Options
    • -25
    • +39
    /openacs-4/packages/news/sql/postgresql/news-create.sql
    • -42
    • +56
    /openacs-4/packages/news/sql/postgresql/news-drop.sql
    • -170
    • +258
    /openacs-4/packages/news/sql/postgresql/news-package-create.sql
    • -8
    • +18
    /openacs-4/packages/news/sql/postgresql/upgrade/upgrade-4.1.0b-4.6.sql
    • -14
    • +23
    /openacs-4/packages/news/sql/postgresql/upgrade/upgrade-4.6-5.0d1.sql
    • -69
    • +86
    /openacs-4/packages/news/sql/postgresql/upgrade/upgrade-5.2.0d1-5.2.0d2.sql
    • -51
    • +66
    /openacs-4/packages/news/sql/postgresql/upgrade/upgrade-5.2.0d2-5.2.0d3.sql
    • -9
    • +19
    /openacs-4/packages/news/sql/postgresql/upgrade/upgrade-5.2.0d5-5.2.0d6.sql
    • -43
    • +52
    /openacs-4/packages/news/sql/postgresql/upgrade/upgrade-5.6.0d1-5.6.0d2.sql
Friday 01 Nov 2013
11:03 pm

gustafn

- get rid of some more empty_string_p

Options
    • -9
    • +7
    /openacs-4/packages/acs-tcl/tcl/table-display-procs.tcl
11:03 pm

gustafn

- use common parameter definition conventions (get rid of old-style nonpos args)

Options
    • -8
    • +10
    /openacs-4/packages/acs-tcl/tcl/apm-procs.tcl
11:02 pm

gustafn

- do not raise error on duplicate dependencies

- follow formatting conventions

Options
    • -14
    • +17
    /openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl
10:54 pm

gustafn

- remove some more "empty_string_p" occurances

Options
    • -1
    • +1
    /openacs-4/packages/dotlrn/tcl/applets-procs.tcl
    • -4
    • +4
    /openacs-4/packages/dotlrn/tcl/community-procs.tcl
    • -6
    • +7
    /openacs-4/packages/dotlrn/www/community-edit-2.tcl
    • -2
    • +2
    /openacs-4/packages/dotlrn/www/dotlrn-master-kelp.tcl
    • -2
    • +2
    /openacs-4/packages/dotlrn/www/dotlrn-master.tcl
10:45 pm

gustafn

- use $$ quoting in postgres SQL

- use name parameter for SQL functions

- favor tcl-compilable string comparisons

- brace expressions

- replace deprecated "acs_sc_call" by "acs_sc::invoke"

- bump version number to indicate compatibility with 5.8.1

Options
    • -2
    • +2
    /openacs-4/packages/new-portal/new-portal.info
    • -197
    • +336
    /openacs-4/packages/new-portal/sql/postgresql/api-create.sql
    • -77
    • +77
    /openacs-4/packages/new-portal/sql/postgresql/datasource-sc-create.sql
    • -34
    • +34
    /openacs-4/packages/new-portal/sql/postgresql/datasource-sc-drop.sql
    • -40
    • +47
    /openacs-4/packages/new-portal/sql/postgresql/defaults.sql
    • -6
    • +15
    /openacs-4/packages/new-portal/sql/postgresql/upgrade/upgrade-2.0.3-2.1.0a1.sql
    • -12
    • +30
    /openacs-4/packages/new-portal/sql/postgresql/upgrade/upgrade-2.1.0a1-2.1.0a2.sql
    • -38
    • +54
    /openacs-4/packages/new-portal/sql/postgresql/upgrade/upgrade-2.1.2d1-2.1.2d2.sql
    • -38
    • +69
    /openacs-4/packages/new-portal/sql/postgresql/upgrade/upgrade-2.3.0d2-2.3.0d3.sql
    • -39
    • +53
    /openacs-4/packages/new-portal/sql/postgresql/upgrade/upgrade-2.3.0d3-2.3.0d4.sql
    • -22
    • +31
    /openacs-4/packages/new-portal/sql/postgresql/upgrade/upgrade-2.3.1d1-2.3.1d2.sql
    • -36
    • +54
    /openacs-4/packages/new-portal/sql/postgresql/upgrade/upgrade-2.6.0d1-2.6.0d2.sql
    • -89
    • +89
    /openacs-4/packages/new-portal/tcl/portal-procs.tcl
    • -2
    • +2
    /openacs-4/packages/new-portal/www/show-here.tcl
    • -2
    • +2
    /openacs-4/packages/new-portal/www/template-place-element.tcl
  16. … 5 more files in changeset.
10:08 pm

gustafn

- use $$ quoting in postgres SQL

- use name parameter for SQL functions

- provide compatility with pg9

- replace deprecated "acs_sc_call" by "acs_sc::invoke"

- replace deprecated "ad_maybe_redirect_for_registration" by "auth::require_login"

- brace expressions

- favor tcl-compilable string comparisons

- don't use numeric comparison operator for non-numeric arguments

- use numeric comparison operator for truth value comparisons

- use "in" or "ni" expression instead of "lsearch"

- bump version number to indicate compatibility with 5.8.1

Options
    • -10
    • +11
    /openacs-4/packages/dotlrn/dotlrn.info
    • -13
    • +16
    /openacs-4/packages/dotlrn/install.xml
    • -1
    • +1
    /openacs-4/packages/dotlrn/lib/member-email-confirm.tcl
    • -3
    • +3
    /openacs-4/packages/dotlrn/lib/member-email.tcl
    • -1
    • +1
    /openacs-4/packages/dotlrn/lib/toolbar.tcl
    • -25
    • +25
    /openacs-4/packages/dotlrn/sql/postgresql/admin-profile-provider-create.sql
    • -20
    • +27
    /openacs-4/packages/dotlrn/sql/postgresql/admin-profile-provider-drop.sql
    • -22
    • +29
    /openacs-4/packages/dotlrn/sql/postgresql/admins-init.sql
    • -18
    • +31
    /openacs-4/packages/dotlrn/sql/postgresql/admins-package-create.sql
    • -20
    • +34
    /openacs-4/packages/dotlrn/sql/postgresql/admins-sanitize.sql
    • -140
    • +140
    /openacs-4/packages/dotlrn/sql/postgresql/applet-sc-create.sql
    • -57
    • +57
    /openacs-4/packages/dotlrn/sql/postgresql/applet-sc-drop.sql
    • -15
    • +15
    /openacs-4/packages/dotlrn/sql/postgresql/class-membership-drop.sql
    • -55
    • +55
    /openacs-4/packages/dotlrn/sql/postgresql/class-memberships-create.sql
    • -57
    • +93
    /openacs-4/packages/dotlrn/sql/postgresql/classes-create.sql
  16. … 132 more files in changeset.
8:51 pm

gustafn

- fix partial SQL edit

Options
    • -18
    • +17
    /openacs-4/packages/faq/sql/postgresql/faq-package-create.sql
Thursday 31 Oct 2013
6:38 pm

gustafn

- use "lassign" instead of multiple "lindex" operations

Options
    • -28
    • +14
    /openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl
    • -3
    • +1
    /openacs-4/packages/acs-tcl/tcl/http-auth-procs.tcl
    • -3
    • +2
    /openacs-4/packages/acs-tcl/tcl/navigation-procs.tcl
    • -3
    • +2
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
    • -48
    • +19
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -8
    • +3
    /openacs-4/packages/acs-tcl/tcl/widgets-procs.tcl
2:23 pm

gustafn

- replace 3 further depreacted "ad_parameter" by parameter::get

Options
    • -4
    • +4
    /openacs-4/packages/lars-blogger/tcl/lars-blogger-procs.tcl
10:08 am

gustafn

- don't return "internal server error" in case the user id is missing

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/shared/community-member.tcl
Wednesday 30 Oct 2013
6:37 pm

gustafn

overhaul of package:

- favor tcl-compilable string comparisons

- don't use numeric comparison operator for non-numeric arguments

- brace expressions

- replace depreacted "ad_parameter" by parameter::get

- use "in" or "ni" expression instead of "lsearch"

- use tcl 8.5 extended index format for "string range"

Options
    • -5
    • +5
    /openacs-4/packages/lars-blogger/lib/blog-titles.tcl
    • -1
    • +1
    /openacs-4/packages/lars-blogger/lib/last-n-comments.tcl
    • -2
    • +2
    /openacs-4/packages/lars-blogger/tcl/blogger-api-procs.tcl
    • -3
    • +3
    /openacs-4/packages/lars-blogger/tcl/category-procs.tcl
    • -4
    • +4
    /openacs-4/packages/lars-blogger/tcl/entry-procs.tcl
    • -29
    • +29
    /openacs-4/packages/lars-blogger/tcl/lars-blogger-procs.tcl
    • -7
    • +7
    /openacs-4/packages/lars-blogger/tcl/metaweblog-api-procs.tcl
    • -7
    • +7
    /openacs-4/packages/lars-blogger/tcl/rss-procs.tcl
    • -3
    • +3
    /openacs-4/packages/lars-blogger/tcl/technorati-procs.tcl
    • -2
    • +2
    /openacs-4/packages/lars-blogger/tcl/test/blogger-api-procs.tcl
    • -1
    • +1
    /openacs-4/packages/lars-blogger/www/blog-months.tcl
    • -19
    • +19
    /openacs-4/packages/lars-blogger/www/blog.tcl
    • -2
    • +2
    /openacs-4/packages/lars-blogger/www/calendar.tcl
    • -3
    • +3
    /openacs-4/packages/lars-blogger/www/category-edit.tcl
    • -6
    • +6
    /openacs-4/packages/lars-blogger/www/entry-chunk.tcl
  16. … 6 more files in changeset.
10:46 am

gustafn

- make function more robust against invalid input

Options
    • -1
    • +3
    /openacs-4/packages/schema-browser/www/function-body.tcl
Tuesday 29 Oct 2013
11:19 am

gustafn

- add missing dollar symbols, otherwise api-code browser shows incomplete results for xotcl methods

Options
    • -12
    • +12
    /openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl
Sunday 27 Oct 2013
3:26 pm

gustafn

- replace mulitple "lindex" operations by "lassign"

Options
    • -11
    • +6
    /openacs-4/packages/acs-subsite/tcl/package-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-subsite/tcl/plpgsql-utility-procs.tcl
    • -3
    • +2
    /openacs-4/packages/acs-subsite/tcl/plsql-utility-procs.tcl
    • -3
    • +2
    /openacs-4/packages/acs-subsite/tcl/subsite-callback-procs.tcl
    • -6
    • +4
    /openacs-4/packages/acs-subsite/tcl/subsite-procs.tcl
    • -3
    • +2
    /openacs-4/packages/acs-subsite/www/admin/groups/new.tcl
    • -3
    • +2
    /openacs-4/packages/acs-subsite/www/admin/parties/new.tcl
    • -3
    • +2
    /openacs-4/packages/acs-subsite/www/admin/users/new.tcl
Saturday 26 Oct 2013
12:55 pm

gustafn

- don't call fings pairs, which have more than two elements

- use "lassign" instead of mulitple "set ... [lindex ...]" command

Options
    • -13
    • +9
    /openacs-4/packages/acs-subsite/tcl/attribute-procs.tcl
    • -5
    • +5
    /openacs-4/packages/acs-subsite/tcl/rel-types-procs.tcl
11:35 am

gustafn

- remove needless quotes from numeric comparisons

Options
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/apm/version-i18n.tcl
    • -2
    • +2
    /openacs-4/packages/acs-lang/www/admin/locale-new.tcl
11:35 am

gustafn

- quote pattern

Options
    • -2
    • +2
    /openacs-4/packages/acs-developer-support/www/request-info.tcl
11:33 am

gustafn

- use numeric comparison operator for truth value comparisons

Options
    • -1
    • +1
    /openacs-4/packages/acs-outdated/tcl/acs-tcl-admin-procs.tcl
11:31 am

gustafn

- use "lassign" instead of "foreach ... break" idiom

Options
    • -3
    • +3
    /openacs-4/packages/categories/tcl/category-trees-procs.tcl
11:29 am

gustafn

- use numeric comparison operator for truth value comparisons

Options
    • -2
    • +2
    /openacs-4/packages/acs-developer-support/www/css-edit.tcl
    • -2
    • +2
    /openacs-4/packages/calendar/www/cal-item-view.tcl
    • -1
    • +1
    /openacs-4/packages/calendar/www/mini-calendar.tcl
    • -1
    • +1
    /openacs-4/packages/faq/www/admin/q_and_a-new-2.tcl
    • -2
    • +2
    /openacs-4/packages/general-comments/www/comment-add-3.tcl
11:28 am

gustafn

- modernize tcl coding

Options
    • -5
    • +5
    /openacs-4/packages/intermedia-driver/tcl/intermedia-procs.tcl