• last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Applied patch #123: Added dropping of these objects and permissions removal. This should be rolled into acs_object.delete, but if this makes dropping work, that's better than nothing

    • -1
    • +37
    ./oracle/notifications-core-drop.sql
Merged 4.6.4d1 (unreleased) to HEAD. This marks the end of the life of the oacs-4-6 branch.

    • -68
    • +0
    ./oracle/delivery-method-sc-create.sql
    • -68
    • +0
    ./oracle/notification-type-sc-create.sql
    • -2
    • +5
    ./oracle/notifications-core-create.sql
    • -2
    • +4
    ./oracle/notifications-package-create.sql
    • -0
    • +99
    ./oracle/upgrade/upgrade-4.6.2-4.6.4.sql
    • -72
    • +0
    ./postgresql/delivery-method-sc-create.sql
    • -67
    • +0
    ./postgresql/email-sc-impl-create.sql
    • -73
    • +0
    ./postgresql/notification-type-sc-create.sql
    • -73
    • +67
    ./postgresql/notifications-core-create.sql
    • -53
    • +29
    ./postgresql/notifications-init.sql
    • -11
    • +12
    ./postgresql/notifications-package-create.sql
  1. … 802 more files in changeset.
Forgot to remove the call to notification-type-sc-create.sql. Can't believe I didn't catch this in my fresh-install test

Added support for notifications going out as the user who sent the notification. This required changing the delivery method service contract, so I moved all service contracts into tcl

    • -68
    • +0
    ./oracle/delivery-method-sc-create.sql
    • -68
    • +0
    ./oracle/notification-type-sc-create.sql
    • -1
    • +4
    ./oracle/notifications-core-create.sql
    • -2
    • +4
    ./oracle/notifications-package-create.sql
    • -0
    • +99
    ./oracle/upgrade/upgrade-4.6.2-4.6.4.sql
    • -72
    • +0
    ./postgresql/delivery-method-sc-create.sql
    • -67
    • +0
    ./postgresql/email-sc-impl-create.sql
    • -73
    • +0
    ./postgresql/notification-type-sc-create.sql
    • -72
    • +66
    ./postgresql/notifications-core-create.sql
    • -53
    • +29
    ./postgresql/notifications-init.sql
    • -11
    • +12
    ./postgresql/notifications-package-create.sql
  1. … 13 more files in changeset.
file upgrade-4.6.2-4.6.4.sql was initially added on branch oacs-4-6.

    • -0
    • +0
    ./oracle/upgrade/upgrade-4.6.2-4.6.4.sql
    • -0
    • +0
    ./postgresql/upgrade/upgrade-4.6.2-4.6.4.sql
merge of 4.6.3b1 to HEAD

    • -1
    • +10
    ./oracle/notifications-core-create.sql
    • -1
    • +8
    ./oracle/notifications-package-create.sql
    • -0
    • +4
    ./oracle/notifications-replies-create.sql
    • -0
    • +1
    ./oracle/upgrade/upgrade-0.2d-0.3d.sql
    • -0
    • +69
    ./oracle/upgrade/upgrade-0.4d-4.6.1.sql
    • -0
    • +156
    ./oracle/upgrade/upgrade-4.6.1-4.6.2.sql
    • -3
    • +12
    ./postgresql/notifications-core-create.sql
    • -6
    • +16
    ./postgresql/notifications-package-create.sql
    • -5
    • +5
    ./postgresql/notifications-package-drop.sql
    • -1
    • +6
    ./postgresql/notifications-replies-create.sql
    • -1
    • +1
    ./postgresql/notifications-replies-package-create.sql
    • -0
    • +1
    ./postgresql/upgrade/upgrade-0.2d-0.3d.sql
  1. … 28 more files in changeset.
file upgrade-4.6.1-4.6.2.sql was initially added on branch oacs-4-6.

    • -0
    • +0
    ./oracle/upgrade/upgrade-4.6.1-4.6.2.sql
    • -0
    • +0
    ./postgresql/upgrade/upgrade-4.6.1-4.6.2.sql
Upgrade to 4.6.2: Notifications extensions - dynamic notifications recipients.

    • -7
    • +16
    ./oracle/notifications-core-create.sql
    • -3
    • +6
    ./oracle/notifications-package-create.sql
    • -0
    • +156
    ./oracle/upgrade/upgrade-4.6.1-4.6.2.sql
    • -2
    • +3
    ./postgresql/notifications-core-create.sql
    • -12
    • +24
    ./postgresql/notifications-package-create.sql
  1. … 15 more files in changeset.
I've changed "timestamp" to "timestamptz" and have begun fixing some

code that used to be legal but as of PG 7.3 is not. You can no longer

subtract an integer from a timestamp but must cast to date, "timestamp"

disappeared (must use "interval" now), "datetime" disappeared ("timestamptz"),

and suchwhat.

Not done but closer than it was before ...

    • -3
    • +3
    ./postgresql/notifications-core-create.sql
    • -5
    • +5
    ./postgresql/notifications-package-create.sql
    • -5
    • +5
    ./postgresql/notifications-package-drop.sql
    • -1
    • +1
    ./postgresql/notifications-replies-create.sql
    • -1
    • +1
    ./postgresql/notifications-replies-package-create.sql
  1. … 35 more files in changeset.
file upgrade-0.4d-4.6.1.sql was initially added on branch oacs-4-6.

    • -0
    • +0
    ./oracle/upgrade/upgrade-0.4d-4.6.1.sql
    • -0
    • +0
    ./postgresql/upgrade/upgrade-0.4d-4.6.1.sql
A bunch of things

1. AOLserver 4.0's nsxml appears to expose a gcc bug which causes the

backwards-compatible "getattr" command to fail. I dug around nsxml

and it does appear to be a gcc bug. I changed to the proper nsxml v2

syntax.

2. In the course of exploring #1 above, I realized that the calls to

dom:: Tcl XML package commands were still being executed despite

being commented out. Typical Tcl misunderstanding on someone's part.

Net effect: we were parsing all APM .info files twice, once in Tcl

and once in ns_xml! Yuk!

3. Fixed a minor notifications bug - you couldn't delete a notification

request if any unsent notifications were pending, causing the homework

package to bomb if you deleted an uploaded homework file and the prof

hadn't yet received their notification.

4. Fixed an obscure corner case in my permissions denormalization code.

    • -1
    • +8
    ./oracle/notifications-package-create.sql
    • -0
    • +69
    ./oracle/upgrade/upgrade-0.4d-4.6.1.sql
    • -1
    • +10
    ./postgresql/notifications-package-create.sql
  1. … 12 more files in changeset.
Make Oracle version cascade in all the places that the PG version does

    • -0
    • +43
    ./oracle/upgrade/upgrade-0.4d-0.5d.sql
  1. … 1 more file in changeset.
Added support for dynamic notifications

    • -7
    • +16
    ./oracle/notifications-core-create.sql
    • -3
    • +6
    ./oracle/notifications-package-create.sql
    • -0
    • +112
    ./oracle/upgrade/upgrade-0.3d-0.4d.sql
    • -2
    • +3
    ./postgresql/notifications-core-create.sql
    • -12
    • +23
    ./postgresql/notifications-package-create.sql
    • -0
    • +89
    ./postgresql/upgrade/upgrade-0.3d-0.4d.sql
  1. … 27 more files in changeset.
file upgrade-0.2d-0.3d.sql was initially added on branch oacs-4-6.

    • -0
    • +0
    ./oracle/upgrade/upgrade-0.2d-0.3d.sql
    • -0
    • +0
    ./postgresql/upgrade/upgrade-0.2d-0.3d.sql
file upgrade-0.3d-0.4d.sql was initially added on branch oacs-4-6.

    • -0
    • +0
    ./oracle/upgrade/upgrade-0.3d-0.4d.sql
    • -0
    • +0
    ./postgresql/upgrade/upgrade-0.3d-0.4d.sql
adds indexes for foreign keys, bumps to version 0.4d, upgrade scripts added

    • -1
    • +10
    ./oracle/notifications-core-create.sql
    • -0
    • +4
    ./oracle/notifications-replies-create.sql
    • -0
    • +1
    ./oracle/upgrade/upgrade-0.2d-0.3d.sql
    • -0
    • +23
    ./oracle/upgrade/upgrade-0.3d-0.4d.sql
    • -1
    • +10
    ./postgresql/notifications-core-create.sql
    • -0
    • +5
    ./postgresql/notifications-replies-create.sql
    • -0
    • +1
    ./postgresql/upgrade/upgrade-0.2d-0.3d.sql
    • -0
    • +23
    ./postgresql/upgrade/upgrade-0.3d-0.4d.sql
  1. … 1 more file in changeset.
merge bartt PG 7.3 fixes from HEAD

    • -5
    • +5
    ./postgresql/notifications-package-create.sql
    • -1
    • +1
    ./postgresql/notifications-replies-package-create.sql
  1. … 53 more files in changeset.
Merge of all changes from oacs-4-6 to HEAD. All changes up to tag jcd-merge-2

on oacs-4-6 are included.

    • -1
    • +3
    ./oracle/notifications-core-create.sql
    • -3
    • +5
    ./postgresql/notifications-core-create.sql
  1. … 55 more files in changeset.
Patches to make OpenACS PG 7.3 compatible.

    • -5
    • +5
    ./postgresql/notifications-package-create.sql
    • -1
    • +1
    ./postgresql/notifications-replies-package-create.sql
  1. … 53 more files in changeset.
1. Changed cleanup sweep interval to 15 minutes

2. Fixed broken PostgreSQL and Oracle queries that were supposed to select

notifications for deletion but rather returned all notifications if any

were ripe for deletion, causing seemingly random failure to deliver

notifications. Sloan had hacked this with a kludge to only delete

notifications older than two days but this didn't work on openacs.org,

which supports weekly summaries of notifications.

3. Changed notification::new to not insert notifications that have no

pending requests. This avoids having to waste time deleting them

afterwards.

4. Added notification_request::request_exists which returns true if

there's at least one notification request for a given object and

notification type.

5. Added a couple of indexes to speed queries that ran slow on openacs.org.

    • -1
    • +3
    ./oracle/notifications-core-create.sql
    • -3
    • +5
    ./postgresql/notifications-core-create.sql
  1. … 8 more files in changeset.
Fixes from sloan

* Increase field sizes for subject

* adds a manage page

* adds a object_id redirect (object-goto.tcl)

* linking to manage page in outgoing message.

    • -2
    • +2
    ./oracle/notifications-core-create.sql
    • -2
    • +2
    ./postgresql/notifications-core-create.sql
  1. … 14 more files in changeset.
fixes bug 1731/patch 442 Tilman Singer

    • -1
    • +2
    ./postgresql/notifications-replies-package-create.sql
fixing

    • -1
    • +13
    ./postgresql/upgrade/upgrade-0.1d-0.2d.sql
1. updated .info file with some missing files for PG

2. fixed the notification.delete func in both DBs

3. bumped pacakge version to 0.2d

    • -0
    • +2
    ./oracle/notifications-package-create.sql
    • -0
    • +1
    ./oracle/upgrade/upgrade-0.1d-0.2d.sql
    • -0
    • +1
    ./postgresql/notifications-package-create.sql
    • -0
    • +1
    ./postgresql/upgrade/upgrade-0.1d-0.2d.sql
  1. … 1 more file in changeset.
removed parens from around select clause in for clause which barfs on pg 7.1. fix from davb

    • -3
    • +3
    ./postgresql/notifications-package-create.sql
copyright OpenForce -> MIT

    • -2
    • +2
    ./oracle/delivery-method-sc-create.sql
    • -2
    • +2
    ./oracle/notification-type-sc-create.sql
    • -2
    • +2
    ./oracle/notifications-core-create.sql
    • -1
    • +1
    ./oracle/notifications-package-create.sql
    • -1
    • +1
    ./oracle/notifications-package-drop.sql
    • -1
    • +1
    ./oracle/notifications-replies-create.sql
    • -1
    • +1
    ./oracle/notifications-replies-package-create.sql
    • -3
    • +3
    ./postgresql/delivery-method-sc-create.sql
    • -2
    • +2
    ./postgresql/notification-type-sc-create.sql
    • -2
    • +2
    ./postgresql/notifications-core-create.sql
  1. … 99 more files in changeset.
postgres port stuff

    • -41
    • +41
    ./postgresql/notifications-package-create.sql
  1. … 7 more files in changeset.
ported notifications to PG (the new stuff)

    • -2
    • +5
    ./postgresql/delivery-method-sc-create.sql
    • -0
    • +67
    ./postgresql/email-sc-impl-create.sql
    • -9
    • +11
    ./postgresql/notifications-init.sql
    • -39
    • +11
    ./postgresql/notifications-package-create.sql
reporting to PG

    • -0
    • +69
    ./postgresql/delivery-method-sc-create.sql
    • -0
    • +73
    ./postgresql/notification-type-sc-create.sql
    • -0
    • +10
    ./postgresql/notifications-create.sql
    • -0
    • +42
    ./postgresql/notifications-replies-create.sql
    • -0
    • +62
    ./postgresql/notifications-replies-package-create.sql
adding replies

  1. … 5 more files in changeset.