OpenACS / openacs-4 / packages

bookmarks

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 31 May
Commits this week: 0
Total Lines of Code (LoC): 9,245
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 10 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Saturday 09 Mar 2002
3:00 am

donb

1. Changed a lot of package info files to fix problems ...

2. Added Vinod's bboard patch

3. Rationalized party e-mail checking by putting a "before insert or update"

trigger on the table that lower-cases email (this was already done by the

party.new() func but at least one update missed this). Got rid of all

"lower(email) = " and "upper(email) = " checks and just made all use the

db email column directly and lower-cased Tcl vars. In this way the index

on the email column is always and consistently used without needing to

define functional indexes on the column (an EE feature for Oracle).

4. Rationalized naming of a couple of workflows and fixed a glossary PG bug

where apparently its workflow got overwritten by one from the CMS at some

point in time.

5. Made the .cmp/.dat/.frm filters in the template code usable though not

very beautiful nor exactly correct. But with practice you can use them

to debug pages in the packages/* hierarchy. I also turned these off by

default as there's no need to run these filters on a production site!

6. Performed minor surgery on templating, including adding a new

"ad_return_exception_template" that allows you to return a templated

error page and aborts the script.

7. ??? probably but I think this covers most stuff.

Options
    • -2
    • +7
    ./sql/oracle/bookmarks-create.sql
  2. … 74 more files in changeset.
Friday 15 Feb 2002
8:29 pm

neophytosd

in tree.tcl: removed extension .tcl from links

Options
    • -2
    • +2
    ./www/tree.tcl
8:25 pm

neophytosd

in index.adp: removed extension .tcl from tree.tcl

Options
    • -1
    • +1
    ./www/index.adp
Sunday 09 Dec 2001
5:21 am

donb

Added code to make use of David Walker's wonderfully abusive hack on the

pg_proc table that showed me how to write recursive SQL functions. We now

have good use of the index on tree_sortkey when climbing the tree, woo-hoo!

Options
    • -4
    • +10
    ./sql/postgresql/bookmarks-create.sql
  2. … 18 more files in changeset.
Saturday 08 Dec 2001
2:17 am

donb

Changed the representation of tree_sortkeys from "text" to "bit varying".

Options
    • -81
    • +47
    ./sql/postgresql/bookmarks-create.sql
    • -10
    • +6
    ./tcl/bookmarks-init-postgresql.xql
    • -38
    • +23
    ./tcl/bookmarks-procs-postgresql.xql
    • -9
    • +4
    ./www/bookmark-access-postgresql.xql
    • -8
    • +5
    ./www/bookmark-delete-postgresql.xql
    • -7
    • +5
    ./www/bookmarks-check-postgresql.xql
    • -2
    • +1
    ./www/bookmarks-user-list-postgresql.xql
    • -16
    • +13
    ./www/index-postgresql.xql
    • -6
    • +2
    ./www/most-popular-postgresql.xql
    • -14
    • +6
    ./www/permissions-reset-all-2-postgresql.xql
    • -14
    • +6
    ./www/permissions-reset-all-postgresql.xql
    • -11
    • +5
    ./www/search-postgresql.xql
    • -18
    • +10
    ./www/tree-dynamic-postgresql.xql
  14. … 50 more files in changeset.
Thursday 29 Nov 2001
3:04 am

donb

Some more speeding-up type activity...

Options
    • -2
    • +4
    ./sql/postgresql/bookmarks-create.sql
    • -3
    • +2
    ./www/bookmark-edit-2-oracle.xql
    • -8
    • +2
    ./www/bookmark-edit-2-postgresql.xql
    • -2
    • +2
    ./www/bookmark-edit-2.tcl
    • -0
    • +5
    ./www/bookmark-edit-2.xql
    • -60
    • +66
    ./www/index-oracle.xql
    • -87
    • +60
    ./www/index-postgresql.xql
Monday 29 Oct 2001
4:59 am

kenk

Fixed folder toggle to show/hide bookmarks under folders...

Options
    • -31
    • +31
    ./sql/postgresql/bookmarks-create.sql
Thursday 18 Oct 2001
9:38 pm

kenk

Adding my_bookmarks_select query to index-oracle.xql

Options
    • -0
    • +35
    ./www/index-oracle.xql
Saturday 13 Oct 2001
1:42 am

kenk

Added my_bookmarks_select query to index-postgresql.xql to allow views of own bookmarks to avoid permissions_p hit

Options
    • -0
    • +34
    ./www/index-postgresql.xql
    • -4
    • +8
    ./www/index.tcl
Friday 28 Sep 2001
6:26 am

kenk

Update to return type (integer to varchar) for bookmark__name

Options
    • -1
    • +1
    ./sql/postgresql/bookmarks-create.sql
5:33 am

kenk

Hmmm. Methinks an index on bm_bookmarks.tree_sortkey might help with the performance issues...*grin*

Options
    • -2
    • +5
    ./sql/postgresql/bookmarks-create.sql
Thursday 27 Sep 2001
3:37 am

kenk

Fixed insert with quotes, and started work on tweaking the regexes for bookmarks-import. The import_list variable was not being tested properly for existence; this is fixed.

Options
    • -10
    • +6
    ./www/bookmark-add-one-2-postgresql.xql
    • -5
    • +8
    ./www/bookmarks-import-postgresql.xql
    • -0
    • +8
    ./www/bookmarks-import.tcl
Sunday 23 Sep 2001
6:48 am

kenk

Fixing import from bookmarks.htmCVS: ----------------------------------------------------------------------

Options
    • -12
    • +3
    ./www/bookmarks-import-postgresql.xql
    • -2
    • +2
    ./www/bookmarks-import.tcl
Thursday 13 Sep 2001
10:27 pm

kenk

Finished global permissions setting

Options
    • -0
    • +4
    ./bookmarks.info
    • -0
    • +26
    ./www/permissions-reset-all-2-oracle.xql
    • -0
    • +50
    ./www/permissions-reset-all-2-postgresql.xql
    • -0
    • +16
    ./www/permissions-reset-all-oracle.xql
    • -0
    • +28
    ./www/permissions-reset-all-postgresql.xql
Wednesday 12 Sep 2001
3:10 am

kenk

Porting delete-dead-links

Options
    • -21
    • +10
    ./www/delete-dead-links-postgresql.xql
Tuesday 11 Sep 2001
9:53 pm

kenk

Updated one-host.xql

Options
    • -0
    • +1
    ./bookmarks.info
    • -0
    • +22
    ./www/one-host.xql
Sunday 09 Sep 2001
2:24 am

kenk

Ummmm...ok. NOW Most Popular hosts/URLs working! *grin*

Options
    • -15
    • +9
    ./www/most-popular-postgresql.xql
2:00 am

kenk

Most Popular hosts/URLs working.

Options
    • -0
    • +2
    ./bookmarks.info
    • -0
    • +31
    ./www/most-popular-oracle.xql
    • -0
    • +59
    ./www/most-popular-postgresql.xql
    • -1
    • +1
    ./www/most-popular.xql
1:05 am

kenk

Search functionality working.

Options
    • -3
    • +5
    ./bookmarks.info
    • -0
    • +63
    ./www/search-oracle.xql
    • -0
    • +77
    ./www/search-postgresql.xql
12:09 am

kenk

Javascript version working...successful w/ Opera 5 for Linux, Mozilla 0.9.1 and Galeon 0.11 on Linux. Konq isn't working yet (?? any ideas ??), and I haven't tested on WinX yet. I didn't change the actual js though (just the PG query), so hopefully it'll be ok.

Options
    • -4
    • +4
    ./bookmarks.info
    • -26
    • +31
    ./www/tree-dynamic-postgresql.xql
Friday 07 Sep 2001
4:04 am

kenk

Updating js tree...

Options
    • -0
    • +2
    ./www/tree-dynamic-postgresql.xql
Saturday 18 Aug 2001
4:57 am

kenk

Forgot to update bookmarks.info

Options
    • -0
    • +3
    ./bookmarks.info
4:56 am

kenk

Adding files for Javascript view

Options
    • -0
    • +33
    ./www/tree-dynamic-oracle.xql
    • -0
    • +37
    ./www/tree-dynamic-postgresql.xql
    • -0
    • +14
    ./www/tree-dynamic.xql
Thursday 16 Aug 2001
10:30 pm

kenk

Bookmark Import working

Options
    • -0
    • +3
    ./bookmarks.info
    • -15
    • +10
    ./www/bookmarks-check-postgresql.xql
    • -0
    • +66
    ./www/bookmarks-import-oracle.xql
    • -0
    • +70
    ./www/bookmarks-import-postgresql.xql
    • -0
    • +70
    ./www/bookmarks-import.xql
Wednesday 15 Aug 2001
7:40 am

kenk

Syncing with server after move; adding fixes to CONNECT BY replacements. Presently, some are broken once multiple users are added to site

Options
    • -22
    • +22
    ./bookmarks.info
    • -1
    • +1
    ./www/folder-selection.tcl
Monday 30 Jul 2001
2:00 am

kenk

Fixed error in bookmarks__new; context_id was not being set in acs_objects for all bookmarks -- added dead links checking

Options
    • -0
    • +4
    ./bookmarks.info
    • -1
    • +1
    ./sql/postgresql/bookmarks-create.sql
    • -1
    • +3
    ./tcl/bookmarks-procs-postgresql.xql
    • -0
    • +1
    ./www/bookmark-add-one-2.tcl
    • -0
    • +27
    ./www/bookmarks-user-list-oracle.xql
    • -0
    • +37
    ./www/bookmarks-user-list-postgresql.xql
    • -0
    • +42
    ./www/delete-dead-links-oracle.xql
    • -0
    • +55
    ./www/delete-dead-links-postgresql.xql
1:16 am

donb

1. Added a check that PG was initdb's with the collation order for

characters that we expect.

2. Jon added a "sql/common" directory for the insert statements which

load data for acs-references, so I added a new datamodel type "common"

to the APM.

3. Created a new db API routine that returns true if a given db_type is

compatible with the current RDBMS.

4. Added a workaround for a PL/pgSQL "execute" bug in acs-workflow (other

cases had been fixed previously by others but this one was missed)

5. Diddled a couple of .info files using the APM.

Options
    • -22
    • +22
    ./bookmarks.info
  2. … 10 more files in changeset.
Monday 23 Jul 2001
5:33 am

kenk

Check Links also working for individual users

Options
    • -7
    • +6
    ./www/bookmarks-check-postgresql.xql
5:01 am

kenk

Bookmarks administration (by Admin) working...

Options
    • -0
    • +2
    ./bookmarks.info
    • -0
    • +47
    ./www/bookmarks-check-oracle.xql
    • -0
    • +55
    ./www/bookmarks-check-postgresql.xql
    • -1
    • +3
    ./www/bookmarks-check.tcl
Thursday 19 Jul 2001
6:01 pm

kenk

Fixed error in actually selecting bookmarks to view. Hadn't tried that yet...you can use them now.

Options
    • -0
    • +2
    ./bookmarks.info
    • -5
    • +5
    ./tcl/bookmarks-init-postgresql.xql
    • -0
    • +16
    ./www/bookmark-access-oracle.xql
    • -0
    • +26
    ./www/bookmark-access-postgresql.xql