• last updated 21 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates

After importing openacs.org users, forums and messages I discovered that it

took literally several minutes to load the APM's home page. This was due

to a rather stupid subselect of the form:

select count(*)

from content_revisions r

where r.revision_id = content_item.get_latest_revision(item_id)

where item_id comes from the package versions table.

It's stupid in both PG and Oracle because get_latest_revision already

joins the latest_revision_id value from cr_items with the content

revisions table thus a simple check for a null return by get_latest_revision

would be sufficient.

It's *really* stupid in Oracle because Oracle won't use the index on

revision_id when checking NULLs so we get two sequential scans of the

cr_revisions table tucked into that one itty-bitty subquery (itself called

once for each package version in ths system).

Which explains why I hadn't noticed it while working on scalability testing

in PG - PG uses the index because its btree index structure handles NULLs.

Meaning this query only fell apart at a rate of O(log2(R)) rather than O(R)

as in Oracle (R being the number of revision objects in the system).

My solution was to rewrite the subselect using "case" rather than "count(*)"

and also to speed up get_latest_revision by having it check for NULL and

return NULL immediately rather than execute the query (in PG this is

accomplished by declaring the function "isstrict", and the executor won't

even call the function if the argument's NULL, making it REALLY fast!).

  1. … 3 more files in changeset.

1. Fixed permissions bug in the PG version (missing OR clause in a view)

2. Added (untested thus far) site-wide-search to glossary

3. Added centralized support for importing files into the CR (either into

the filesystem or the database).

4. Fixed wp-slim. Fixed it some more. Fixed it again. It still needs

more fixing.

  1. … 58 more files in changeset.

1. Typo in the alter table in the PG version ...

2. Just folded the alter tables into the cr_folders table definition. This

is still pre-beta ...

  1. … 1 more file in changeset.
added a constraint

added package_id to cr_folders

Dave Bauer's patches ...

fixed infinite recursion problem with cr_keywords update trigger

added support for multiple file storage areas

  1. … 7 more files in changeset.
added name method support for content_revision type

  1. … 4 more files in changeset.
moved CMS stuff to CR so that content can be displayed by the search interface without requiring the user to load cms

  1. … 21 more files in changeset.
updated search support to include templates and images

  1. … 5 more files in changeset.
added virtual url support for CR

  1. … 5 more files in changeset.
removed DataProvider Contract Temporarily

  1. … 1 more file in changeset.
added dependency for acs-service-contract

  1. … 1 more file in changeset.
modified CR to provide the FtsContentProvider interface

  1. … 2 more files in changeset.
added service content support to convert CR into a content provider for search

fixed definition of item relationships

fixed template functions

  1. … 2 more files in changeset.
fixed insertion order for insert statement in content_revision__copy routine

fixed image upload using lobs and file storage in CR

  1. … 5 more files in changeset.
fixed folder deletion problem caused by pg RI bug

more cleanup of cms - content upload and display

  1. … 9 more files in changeset.
modified content_item__get_path to match oracle version

removed circular dependency due to workflow

  1. … 4 more files in changeset.
fixed a couple of typos in content_type__drop_attribute

fixed get_path to match oracle version

fixed exception message in content_type__drop_attribute

reimplemented RI triggers for live_revision and latest_revision as user triggers

patch supplied by Dave Bauer to pass in security_inherit_p flag when creating new content_item. Work-around for data-change violation

workaround for content_item__delete problem related to pg RI problems