• last updated 20 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates

Applied Tilman Singer's patch that changes template <if> tag checks from

"ne 0" to the more meaningful "eq false", etc.

1. Changed a lot of package info files to fix problems ...

2. Added Vinod's bboard patch

3. Rationalized party e-mail checking by putting a "before insert or update"

trigger on the table that lower-cases email (this was already done by the

party.new() func but at least one update missed this). Got rid of all

"lower(email) = " and "upper(email) = " checks and just made all use the

db email column directly and lower-cased Tcl vars. In this way the index

on the email column is always and consistently used without needing to

define functional indexes on the column (an EE feature for Oracle).

4. Rationalized naming of a couple of workflows and fixed a glossary PG bug

where apparently its workflow got overwritten by one from the CMS at some

point in time.

5. Made the .cmp/.dat/.frm filters in the template code usable though not

very beautiful nor exactly correct. But with practice you can use them

to debug pages in the packages/* hierarchy. I also turned these off by

default as there's no need to run these filters on a production site!

6. Performed minor surgery on templating, including adding a new

"ad_return_exception_template" that allows you to return a templated

error page and aborts the script.

7. ??? probably but I think this covers most stuff.

    • -5
    • +27
    ./bboard/sql/oracle/bboard-create.sql
    • -7
    • +15
    ./bboard/sql/oracle/bboard-packages.sql
    • -5
    • +26
    ./bboard/sql/postgresql/bboard-create.sql
    • -4
    • +10
    ./bboard/sql/postgresql/bboard-drop.sql
    • -29
    • +24
    ./bboard/tcl/bboard-procs-postgresql.xql
    • -1
    • +1
    ./bboard/www/message-move-2-oracle.xql
    • -1
    • +1
    ./bboard/www/message-move-2-postgresql.xql
  1. … 60 more files in changeset.
adjusted wf_ticket to inherit from acs_object instead of null

fixed context_id reference

    • -1
    • +1
    ./ticket-tracker-lite/www/ticket-add-2-oracle.xql
    • -1
    • +1
    ./ticket-tracker-lite/www/ticket-add-2-postgresql.xql
    • -1
    • +2
    ./ticket-tracker-lite/www/ticket-add-2.tcl
1) Updated .info file to reality

3) Changed '= null' to 'is null' test

    • -1
    • +3
    ./ticket-tracker-lite/ticket-tracker-lite.info
    • -1
    • +1
    ./ticket-tracker-lite/www/index-postgresql.xql
    • -1
    • +1
    ./ticket-tracker-lite/www/ticket-postgresql.xql
removed excess files from .info file

cleaned up email check

    • -0
    • +9
    ./ticket-tracker/www/admin/install/index.xql
1) cleaned up workflows .info file

2) fixed error message in acs-workflow

3) fixed code to reassign tasks to users

4) send return_url to task-action.adp

5) fixed bug in ticket-tracker's clarify_fire callback

6) added return_url to ticket tracker's emails

    • -18
    • +28
    ./acs-workflow/acs-workflow.info
    • -1
    • +2
    ./acs-workflow/www/task-assignees-oracle.xql
    • -1
    • +2
    ./acs-workflow/www/task-assignees-postgresql.xql
1) added missing param to workflow_case__add_task_assignment

2) Fixed minor typos in workflow docs, ACS->OpenACS

    • -1
    • +2
    ./acs-workflow/www/assign-yourself-postgresql.xql
    • -1
    • +2
    ./acs-workflow/www/assignee-add-2-postgresql.xql
    • -2
    • +2
    ./acs-workflow/www/doc/advanced-workflow-builder.html
    • -3
    • +3
    ./acs-workflow/www/doc/concepts-reference.html
    • -2
    • +2
    ./acs-workflow/www/doc/coordination.html
    • -13
    • +13
    ./acs-workflow/www/doc/design.html
    • -2
    • +2
    ./acs-workflow/www/doc/future-plans.html
    • -28
    • +10
    ./acs-workflow/www/doc/installation.html
    • -2
    • +2
    ./acs-workflow/www/doc/maintainer.html
    • -2
    • +2
    ./acs-workflow/www/doc/release-notes.html
  1. … 3 more files in changeset.

I boo-booed when changing the notification callback signature.

1. Added session-update.tcl, a small utility which somewhat safely allows

you to put up a link that changes a session_property, for instance to

change the number of items displayed or that sort of thing. The caller

must sign their values and URL, which are verified by the callee via

ad_page_contract. If the referrer doesn't match the signed expected

referrer, you get bounced. I think this is reasonably secure (though

permissions should always be rigorously checked on all pages, of course)

2. acs_events had an html_p flag in the datamodel but no way to set it.

Fixed. It should really be a mime-type but since it's not using the

CR, and since I'm extremely busy with other stuff, I didn't fix it.

3. While doing #1 above I learned that signing and verifying arrays didn't

quite work. Fixed.

4. Found and fixed a small problem with my earlier work on the currency widget.

    • -8
    • +17
    ./acs-workflow/www/doc/developer.html
    • -11
    • +14
    ./ticket-tracker/sql/oracle/ticket-tracker-packages.sql
  1. … 8 more files in changeset.
use ad_acs_kernel_id to get package_id

    • -2
    • +2
    ./ticket-tracker/www/admin/install/index.tcl
send the proper date format to ad_dateentrywidget

    • -1
    • +1
    ./ticket-tracker-lite/www/ticket-postgresql.xql
adjusted install sequence to use ad_parameter instead of checking db directly

    • -2
    • +2
    ./ticket-tracker/www/admin/install/index.adp
    • -20
    • +17
    ./ticket-tracker/www/admin/install/index.tcl
    • -8
    • +4
    ./ticket-tracker/www/admin/install/index.xql

There were some inconsistencies in the way return_url was being set up...

Small change to wf_task_panels ...

fix bug that didn't allow for null charters

    • -3
    • +1
    ./bboard/sql/oracle/bboard-packages.sql
make it obvious that null charters are allowed

fix bug to allow for null charters

fix bug that dosen't allow null charters

Added a new proc to return the panels associated with a workflow ...

    • -4
    • +26
    ./acs-workflow/tcl/workflow-procs.tcl
    • -1
    • +38
    ./acs-workflow/tcl/workflow-procs.xql

Removed references to jobs-start and jobs-kill (it's done in Tcl now)

Added a new function that returns the task_id for a particular case/taskkey.

The only way to get this (needed to fire a message transition) was for one's

client code to poke into the datamodel directly with a select.

    • -1
    • +20
    ./acs-workflow/sql/oracle/workflow-case-package-body.sql

1. Changed a couple of ns_schedule_proc calls to ad_schedule_proc.

2. Moved job scheduling for workflow from the db to tcl, because PG doesn't

support in-db job scheduling.

    • -29
    • +0
    ./acs-workflow/sql/oracle/jobs-kill.sql
    • -47
    • +0
    ./acs-workflow/sql/oracle/jobs-start.sql
    • -0
    • +16
    ./acs-workflow/tcl/workflow-procs-oracle.xql
    • -14
    • +12
    ./acs-workflow/tcl/workflow-procs-postgresql.xql
    • -1
    • +18
    ./acs-workflow/tcl/workflow-procs.tcl
  1. … 4 more files in changeset.

1. Removed call to "schedule_proc" in acs-workflow. It's no longer needed.

2. Changed admin UI so you can enter the sort order when adding or editing

places.

3. Duplicated Bart Teeuwisse's glossary changes for Oracle.

    • -0
    • +1
    ./acs-workflow/www/admin/place-add-2.tcl
    • -2
    • +2
    ./acs-workflow/www/admin/place-add-2.xql
    • -0
    • +5
    ./acs-workflow/www/admin/place-add.adp
    • -1
    • +2
    ./acs-workflow/www/admin/place-edit-2.tcl
    • -1
    • +2
    ./acs-workflow/www/admin/place-edit-2.xql
    • -1
    • +6
    ./acs-workflow/www/admin/place-edit.adp
    • -1
    • +1
    ./acs-workflow/www/admin/place-edit.xql
  1. … 5 more files in changeset.
fix "cellpadding" typo that was causing bboard message list table to be very cluttered.

Fixed some errors in my earlier hacking on hierarchical queries...

    • -1
    • +1
    ./bboard/www/message-threaded-postgresql.xql
  1. … 3 more files in changeset.

Added code to make use of David Walker's wonderfully abusive hack on the

pg_proc table that showed me how to write recursive SQL functions. We now

have good use of the index on tree_sortkey when climbing the tree, woo-hoo!

    • -3
    • +3
    ./bboard/tcl/bboard-procs-postgresql.xql
  1. … 17 more files in changeset.

Oops - I'd previously committed a query with a literal substituted for

:forum_id, done back when I was hacking these queries for greater efficiency

using real test data. I was using psql so I was using literal values...

Changed the representation of tree_sortkeys from "text" to "bit varying".

    • -5
    • +3
    ./bboard/tcl/bboard-procs-postgresql.xql
    • -3
    • +10
    ./bboard/www/message-delete-2-postgresql.xql
    • -3
    • +3
    ./bboard/www/message-move-2-postgresql.xql
  1. … 57 more files in changeset.