• last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates

1. Made it possible to upgrade from acs-kernel 4.6.1 to acs-kernel 4.6.2

by using the APM rather than running the upgrade script by hand from

PSQL or SQL*Plus.

2. Changed a bunch of package .info files to depend on acs-kernel 4.6.2

to force the APM to upgrade acs-kernel (and therefore the APM datamodel)

before anything else. No guarantee on this though since not all

packages properly define their dependence on the kernel, it appears.

3. Whacked the release notes to suggest people use the APM to upgrade

acs-kernel first, other package later, just for safety's sake.

4. Fixed goof-up in acs-subsite I accidently introduced.

  1. … 35 more files in changeset.
Fixed bug #327: Tcl code in ADP file.

I've changed "timestamp" to "timestamptz" and have begun fixing some

code that used to be legal but as of PG 7.3 is not. You can no longer

subtract an integer from a timestamp but must cast to date, "timestamp"

disappeared (must use "interval" now), "datetime" disappeared ("timestamptz"),

and suchwhat.

Not done but closer than it was before ...

    • -14
    • +14
    ./sql/postgresql/wf-core-create.sql
  1. … 51 more files in changeset.
file upgrade-4.6-4.6.1.sql was initially added on branch oacs-4-6.

    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-4.6-4.6.1.sql
A bunch of things

1. AOLserver 4.0's nsxml appears to expose a gcc bug which causes the

backwards-compatible "getattr" command to fail. I dug around nsxml

and it does appear to be a gcc bug. I changed to the proper nsxml v2

syntax.

2. In the course of exploring #1 above, I realized that the calls to

dom:: Tcl XML package commands were still being executed despite

being commented out. Typical Tcl misunderstanding on someone's part.

Net effect: we were parsing all APM .info files twice, once in Tcl

and once in ns_xml! Yuk!

3. Fixed a minor notifications bug - you couldn't delete a notification

request if any unsent notifications were pending, causing the homework

package to bomb if you deleted an uploaded homework file and the prof

hadn't yet received their notification.

4. Fixed an obscure corner case in my permissions denormalization code.

    • -0
    • +243
    ./sql/postgresql/upgrade/upgrade-4.6-4.6.1.sql
  1. … 15 more files in changeset.
Merged changes on HEAD over to 4-6 branch: Make acs-workflow not part of initial install

merge bartt PG 7.3 fixes from HEAD

  1. … 54 more files in changeset.
Make it not part of initial install.

Patches to make OpenACS PG 7.3 compatible.

  1. … 54 more files in changeset.
merge from oacs-4-6

  1. … 130 more files in changeset.
cleanup on .xql files, add rdbms tags to db specific files, clean XML, etc

  1. … 29 more files in changeset.
ns_return->ad_return, ad_script_abort, redirect to absract urls

  1. … 21 more files in changeset.
fix some broken links

  1. … 23 more files in changeset.
fix calls to empty_string_p with missing $

  1. … 9 more files in changeset.
cleanup javadoc tags (eg @cvs_id @cvs @cvs-id: instead if @cvs-id)

  1. … 692 more files in changeset.
ad_context_bar calls which were removed in error

  1. … 4 more files in changeset.
remove superfluous package local masters and use sitewide master by default

  1. … 687 more files in changeset.
pass context_bar and title to master template, cleanup html

  1. … 60 more files in changeset.
updated version to 4.5

  1. … 15 more files in changeset.
added missing quote. patch 301. bug 1510.

Updated .info files of all core packages to version 4.5

  1. … 22 more files in changeset.
Merged with the 4.5 branch (oacs-4-5 tag "don-merge-1")

  1. … 58 more files in changeset.

I'd removed jobs-start.sql but hadn't removed the include from this file.

Merged with OpenACS 4.5 beta1 branch.

  1. … 88 more files in changeset.

Applied Lars Pind's patch #180, changing docs to reflect evolution in the

graphviz distribution.

1) cleaned up workflows .info file

2) fixed error message in acs-workflow

3) fixed code to reassign tasks to users

4) send return_url to task-action.adp

5) fixed bug in ticket-tracker's clarify_fire callback

6) added return_url to ticket tracker's emails

  1. … 1 more file in changeset.
1) added missing param to workflow_case__add_task_assignment

2) Fixed minor typos in workflow docs, ACS->OpenACS

    • -2
    • +2
    ./www/doc/advanced-workflow-builder.html
  1. … 3 more files in changeset.

I boo-booed when changing the notification callback signature.

    • -11
    • +8
    ./sql/oracle/sample-article-create.sql

1. Added session-update.tcl, a small utility which somewhat safely allows

you to put up a link that changes a session_property, for instance to

change the number of items displayed or that sort of thing. The caller

must sign their values and URL, which are verified by the callee via

ad_page_contract. If the referrer doesn't match the signed expected

referrer, you get bounced. I think this is reasonably secure (though

permissions should always be rigorously checked on all pages, of course)

2. acs_events had an html_p flag in the datamodel but no way to set it.

Fixed. It should really be a mime-type but since it's not using the

CR, and since I'm extremely busy with other stuff, I didn't fix it.

3. While doing #1 above I learned that signing and verifying arrays didn't

quite work. Fixed.

4. Found and fixed a small problem with my earlier work on the currency widget.

    • -6
    • +15
    ./sql/oracle/sample-article-create.sql
  1. … 9 more files in changeset.

There were some inconsistencies in the way return_url was being set up...