OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 12
Total Committers: 145
Last Commit: 26 Apr
Commits this week: 12
Total Lines of Code (LoC): 6,873,112
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 8 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 04 Apr 2010
4:51 pm

donb

Improved the queries for global/instance params ...

Options
    • -17
    • +10
    /openacs-4/packages/acs-subsite/www/shared/parameters.tcl
    • -39
    • +6
    /openacs-4/packages/acs-subsite/www/shared/parameters.xql
1:13 am

donb

1. First shot at sitewide admin ui for global parameters. You can edit them

from the sitewide admin page list that was previously built for packages

that have a sitewide-admin subdirectory. Package is now displayed for

either the existence of sitewide-admin or global parameters.

2. Did something I'd wanted to do for some time. When Nima added the

parameter_changed callback in acs subsite, he actually *moved* the

set_value call there. I've changed it so it more rationally sets the

value in the parameters page, then calls the parameter_changed callback.

3. Invented a global_parameter_changed callback that works as the regular

parameter_changed callback. This was necessary to avoid breaking existing

uses of parameter_changed.

More testing is required before release (which will hopefully happen

tomorrow, Sunday Apr 4).

Options
    • -5
    • +1
    /openacs-4/packages/acs-admin/www/index.adp
    • -2
    • +31
    /openacs-4/packages/acs-admin/www/index.tcl
    • -0
    • +9
    /openacs-4/packages/acs-admin/www/index.xql
    • -19
    • +9
    /openacs-4/packages/acs-subsite/tcl/subsite-callback-procs.tcl
    • -31
    • +56
    /openacs-4/packages/acs-subsite/www/shared/parameters.tcl
    • -2
    • +53
    /openacs-4/packages/acs-subsite/www/shared/parameters.xql
Friday 02 Apr 2010
4:17 am

donb

The instantiate callback would fail if search was mounted during initial

install (as in a custom install.xml file). It only indexes now if the

init file has been sourced, which will be after server restart if one is

doing an initial install.

Options
    • -1
    • +9
    /openacs-4/packages/search/tcl/apm-callback-procs.tcl
1:21 am

donb

Ugh ... finally got inherited parameters right.

Options
    • -3
    • +3
    /openacs-4/packages/acs-admin/www/apm/version-dependency-add-2.tcl
    • -4
    • +5
    /openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl
Thursday 01 Apr 2010
11:51 pm

donb

Needed to build the subsites package keys cache ...

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl
1:33 am

donb

Added a new "rename-instance" node, useful in particular for renaming

"Main Site" to something more useful.

Options
    • -3
    • +28
    /openacs-4/packages/acs-tcl/tcl/install-procs.tcl
12:40 am

donb

Allow for the specification of "scope" when registering a parameter from

an install xml file.

Options
    • -2
    • +3
    /openacs-4/packages/acs-tcl/tcl/install-procs.tcl
Wednesday 31 Mar 2010
10:35 pm

michaels

part 2 of (temp) fix - added bit to sweeper that clears out invalid (unauthorized) notif requests

Options
    • -1
    • +6
    /openacs-4/packages/notifications/tcl/sweep-procs.tcl
    • -0
    • +11
    /openacs-4/packages/notifications/tcl/sweep-procs.xql
8:08 pm

donb

Finished up PG semantics for global/instance parameters on package upgrade.

The Tcl API stuff to do this should technically be moved down into the

oracle/PG API but 1) it's a fair amount of db-specific work and 2) people

should be using the high level constructs in the first place (and why do

people explicitly register new parameters when they're registered from the

package info file on upgrade in the first place?)

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/apm-install-procs-oracle.xql
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/apm-install-procs-postgresql.xql
    • -18
    • +17
    /openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/apm-install-procs.xql
    • -1
    • +7
    /openacs-4/packages/acs-tcl/tcl/apm-procs.tcl
3:21 am

donb

Making global/instance changes work with Oracle

Options
    • -1
    • +35
    /openacs-4/packages/acs-kernel/sql/oracle/apm-create.sql
    • -0
    • +29
    /openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.6.0d7-5.6.0d8.sql
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/apm-install-procs-oracle.xql
2:46 am

donb

More code dealing with instance and global parameter semantics. I finally

have a reasonable model of inheritance and semantics implemented, not

perfect from a language-theoretic point of view, but works well without

having to rewrite every bit of parameter-handling code in acs-core.

Options
    • -2
    • +2
    /openacs-4/packages/acs-kernel/acs-kernel.info
    • -2
    • +3
    /openacs-4/packages/acs-kernel/sql/oracle/apm-create.sql
    • -0
    • +249
    /openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.6.0d7-5.6.0d8.sql
    • -1
    • +2
    /openacs-4/packages/acs-kernel/sql/postgresql/apm-create.sql
    • -0
    • +26
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.6.0d7-5.6.0d8.sql
    • -22
    • +22
    /openacs-4/packages/acs-tcl/tcl/apm-install-procs-oracle.xql
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/apm-install-procs-postgresql.xql
    • -0
    • +2
    /openacs-4/packages/acs-tcl/tcl/apm-install-procs.xql
    • -1
    • +2
    /openacs-4/packages/acs-tcl/tcl/apm-procs.xql
12:19 am

donb

Add UI to create global parameters from within the APM package builder.

Options
    • -2
    • +3
    /openacs-4/packages/acs-admin/www/apm/parameter-add-2.tcl
    • -2
    • +15
    /openacs-4/packages/acs-admin/www/apm/parameter-add.tcl
12:06 am

donb

Display "scope" of parameters on the version parameters page.

Options
    • -1
    • +2
    /openacs-4/packages/acs-admin/www/apm/version-parameters-oracle.xql
    • -2
    • +3
    /openacs-4/packages/acs-admin/www/apm/version-parameters-postgresql.xql
    • -1
    • +2
    /openacs-4/packages/acs-admin/www/apm/version-parameters.tcl
12:03 am

emmar

Add missing query

Options
    • -0
    • +11
    /openacs-4/packages/assessment/tcl/as-item-type-mc-procs.xql
12:00 am

emmar

Fix dave's fix :)

Options
    • -5
    • +8
    /openacs-4/packages/assessment/tcl/as-item-type-mc-procs.xql
Tuesday 30 Mar 2010
11:42 pm

donb

"object_type" was not defined at the point where a DELETE error was being

logged.

Options
    • -2
    • +2
    /openacs-4/packages/search/tcl/search-procs.tcl
4:19 pm

daveb

Add missing query for question choices stored in CR filesystem

Options
    • -0
    • +8
    /openacs-4/packages/assessment/tcl/as-item-type-mc-procs.xql
Sunday 28 Mar 2010
3:13 am

donb

More global parameters stuff: XML file parsing and package installation

Options
    • -11
    • +14
    /openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl
    • -3
    • +8
    /openacs-4/packages/acs-tcl/tcl/apm-xml-procs.tcl
    • -1
    • +2
    /openacs-4/packages/acs-tcl/tcl/apm-xml-procs.xql
1:30 am

donb

Added a test for global parameter set/get value.

Options
    • -1
    • +9
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
Saturday 27 Mar 2010
3:26 pm

michaels

added security check to notifications sweep query - without this check and with no mechanism to remove requests for users who are no longer authorized, notifications still go out. not good.

Options
    • -0
    • +5
    /openacs-4/packages/notifications/tcl/sweep-procs-oracle.xql
    • -0
    • +4
    /openacs-4/packages/notifications/tcl/sweep-procs-postgresql.xql
Friday 26 Mar 2010
8:43 pm

donb

The check for a blank tab was incorrect, because it didn't check to make

sure elements on the page were visible rather than hidden.

Options
    • -0
    • +1
    /openacs-4/packages/layout-managed-subsite/lib/tabbed-master.xql
Thursday 25 Mar 2010
9:36 pm

torbenb

adding vendorwebuid to list to expand web resource opportunities

Options
    • -0
    • +3
    /openacs-4/packages/ecommerce/tcl/ecds-procs.tcl
6:33 pm

donb

Oracle now passes the first set of global parameter tests. More to follow

for both PG and Oracle.

Options
    • -7
    • +9
    /openacs-4/packages/acs-kernel/sql/oracle/apm-create.sql
    • -2
    • +5
    /openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.6.0d6-5.6.0d7.sql
2:02 am

donb

Fixed up the apm parameter stuff to the point where I can at least

register and unregister, and cache values of, global parameters. There's

some really funky code here, I also took the time to have the unregister

code use the unregister API in PL/[pg]SQL rather than roll its own.

Options
    • -0
    • +7
    /openacs-4/packages/acs-tcl/tcl/apm-procs-oracle.xql
    • -18
    • +6
    /openacs-4/packages/acs-tcl/tcl/apm-procs-postgresql.xql
    • -26
    • +11
    /openacs-4/packages/acs-tcl/tcl/apm-procs.tcl
    • -0
    • +17
    /openacs-4/packages/acs-tcl/tcl/apm-procs.xql
    • -20
    • +17
    /openacs-4/packages/acs-tcl/tcl/defs-procs.tcl
    • -2
    • +12
    /openacs-4/packages/acs-tcl/tcl/defs-procs.xql
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/parameter-procs.tcl
    • -17
    • +11
    /openacs-4/packages/acs-tcl/tcl/test/apm-parameter-test-procs.tcl
1:57 am

donb

Victor had made an upgrade script for version d4, and committed it before

I got around to adding and committing mine. So now my tcl upgrade commits

and my datamodel ones aren't synchronized :( But they're dev versions so

no harm should result.

Options
    • -0
    • +262
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.6.0d6-5.6.0d7.sql
1:50 am

donb

If I'd known global parameters would be such a PITA, would I have TIP'd to

do them?

Turns out we must make a parameter value when a parameter is registered, else

all sorts of stuff dies. This is for PG. Oracle will come soon.

Options
    • -4
    • +9
    /openacs-4/packages/acs-kernel/sql/postgresql/apm-create.sql
Tuesday 23 Mar 2010
10:53 pm

donb

A bunch of stuff related to global/instance parameters.

Options
    • -6
    • +8
    /openacs-4/packages/acs-kernel/sql/oracle/apm-create.sql
    • -6
    • +9
    /openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.6.0d6-5.6.0d7.sql
    • -52
    • +19
    /openacs-4/packages/acs-kernel/sql/postgresql/apm-create.sql
    • -2
    • +3
    /openacs-4/packages/acs-kernel/sql/postgresql/apm-drop.sql
8:33 pm

donb

Added 'embeds' to allowable dependencies.

Options
    • -1
    • +6
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.6.0d3-5.6.0d4.sql
5:21 pm

donb

Restored the data links upgrade script I'd accidently overwritten earlier.

Options
    • -9
    • +12
    /openacs-4/packages/acs-kernel/sql/oracle/apm-create.sql
    • -0
    • +6
    /openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.6.0d3-5.6.0d4.sql
12:17 am

donb

1. added "bio" attribute to user rather than person (initial install was fine)

2. only make package instance parameter values for instance scope params

Options
    • -1
    • +4
    /openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.6.0d2-5.6.0d3.sql
    • -8
    • +11
    /openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.6.0d6-5.6.0d7.sql