OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 22
Total Committers: 146
Last Commit: 26 Nov
Commits this week: 22
Total Lines of Code (LoC): 7,560,945
Net change in LoC this week: 141

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 28 Nov 2016
6:57 pm

antoniop

Removed inline js in favor of explicit ones to comply with CSP

Options
    • -10
    • +9
    /openacs-4/packages/xowiki/www/xinha/insert-wlink.adp
    • -0
    • +1
    /openacs-4/packages/xowiki/www/xinha/insert-wlink.tcl
6:29 pm

antoniop

Removed inline js handlers in favor of explicit ones to comply with CSP

Options
    • -12
    • +6
    /openacs-4/packages/xowiki/www/xinha/insert-ilink.adp
    • -2
    • +19
    /openacs-4/packages/xowiki/www/xinha/insert-ilink.tcl
6:17 pm

antoniop

Removed inline js handlers, replaced with explicit ones

Options
    • -13
    • +9
    /openacs-4/packages/xowiki/www/xinha/insert-image.adp
    • -1
    • +25
    /openacs-4/packages/xowiki/www/xinha/insert-image.tcl
6:04 pm

antoniop

Remove handler which function was nowhere in the original javascript

Options
    • -4
    • +1
    /openacs-4/packages/xowiki/www/xinha/attach-file.tcl
5:45 pm

antoniop

Removed redundand body and html tags (they come already from master template)

Options
    • -4
    • +0
    /openacs-4/packages/xowiki/www/xinha/file-selector.adp
5:26 pm

antoniop

Removed inline js events into explicit handlers. Test and revamp of plugin to functional state.

Options
    • -3
    • +6
    /openacs-4/packages/richtext-xinha/www/resources/xinha-nightly/plugins/OacsAttach/oacs-attach.js
    • -95
    • +99
    /openacs-4/packages/xowiki/www/xinha/attach-file.adp
    • -6
    • +47
    /openacs-4/packages/xowiki/www/xinha/attach-file.tcl
12:25 pm

antoniop

Uniform cache for chat room infos to the established nomenclature.

Increase size so that 1000 maximum entries would fit in the cache.

Options
    • -6
    • +7
    /openacs-4/packages/chat/tcl/chat-procs.tcl
9:20 am

gustafn

- provide partial times to statistics (if available)

- add long-calls to navigation structure

- bump version number to 0.48

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-request-monitor/xotcl-request-monitor.info
    • -21
    • +43
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
    • -1
    • +2
    /openacs-4/packages/xotcl-request-monitor/www/index.adp
    • -0
    • +13
    /openacs-4/packages/xotcl-request-monitor/www/long-calls.adp
Sunday 27 Nov 2016
1:19 pm

gustafn

Some more Tcl cleanup

- use curly brackes to enable byte code compilation

- don't use "[expr ...]" when not needed

- prefer "incr i -1" over "set i [expr {$i - 1}] "

Options
    • -1
    • +1
    /openacs-4/packages/acs-admin/www/monitor.tcl
    • -3
    • +3
    /openacs-4/packages/acs-lang/tcl/lang-catalog-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-subsite/tcl/attribute-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-subsite/tcl/group-type-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/pvt/set-on-vacation-until.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/stack-trace-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-templating/tcl/currency-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-templating/tcl/parse-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-templating/tcl/tag-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-templating/tcl/util-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-templating/tcl/wizard-procs.tcl
    • -10
    • +8
    /openacs-4/packages/categories/tcl/category-xml-procs.tcl
    • -2
    • +2
    /openacs-4/packages/file-storage/www/file-add.tcl
    • -3
    • +3
    /openacs-4/packages/news/www/admin/revision-add-3.tcl
    • -1
    • +1
    /openacs-4/packages/rss-support/www/delete.tcl
11:14 am

gustafn

- set live and latest revision on one sweep (use is_latests setting when setting live_revision)

Options
    • -3
    • +3
    /openacs-4/packages/xotcl-core/xotcl-core.info
    • -1
    • +2
    /openacs-4/packages/xotcl-core/tcl/cr-procs.tcl
11:10 am

gustafn

Reduced generation of dead tuples in postgres.

Background: In the old version, the fields latest and live

revisions were updated always via two separate dmlDML statements.

Every update causes in PostgreSQL (tested to pg 9.6) one more dead

tuple, such that on busy systems, we see 30k + dead tuples per

hour. These dead tuples in turn cause more auto vacuum operations

and can lead to abandoned query plans.

This change can reduce the number of dead tuples on cr_items into

half, by allowing both fields to be set in one operation (namely

content_item__set_live_revision). This function has an optional 4th

argument that can cause this optimization. For legacy applications,

nothing changes.

Btw: since all commonly used applications use the live revision, the

fallback of the latest_revision is unused. One can consider to

remove the cr_revision_latest_tr, at least on on certain

installations.

bump revision to 5.1.9d23

Options
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/acs-content-repository.info
    • -23
    • +31
    /openacs-4/packages/acs-content-repository/sql/postgresql/content-item.sql
    • -6
    • +13
    /openacs-4/packages/acs-content-repository/sql/postgresql/content-revision.sql
    • -0
    • +90
    /openacs-4/packages/acs-content-repository/sql/postgresql/upgrade/upgrade-5.9.1d22-5.9.1d23.sql
11:10 am

gustafn

file upgrade-5.9.1d22-5.9.1d23.sql was initially added on branch oacs-5-9.

Options
    • -0
    • +0
    /openacs-4/packages/acs-content-repository/sql/postgresql/upgrade/upgrade-5.9.1d22-5.9.1d23.sql
Saturday 26 Nov 2016
8:42 am

gustafn

- make upgrade script more robust

Options
    • -2
    • +1
    /openacs-4/packages/acs-lang/sql/postgresql/ad-locales.sql
    • -2
    • +20
    /openacs-4/packages/acs-lang/sql/postgresql/upgrade/upgrade-5.9.1d1-5.9.1d2.sql
Friday 25 Nov 2016
6:44 pm

gustafn

- replace regular expression by ad_html_qualify_links

- bum version number to 5.9.1d2

Options
    • -3
    • +3
    /openacs-4/packages/notifications/notifications.info
    • -22
    • +3
    /openacs-4/packages/notifications/tcl/notification-email-procs.tcl
3:47 pm

gustafn

- imporve ad_html_qualify_links in various ways (better argument name, better comments, removed superflous slashes, ...

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -7
    • +10
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
3:46 pm

gustafn

- turn relative links during notifications into absolute links

Options
    • -3
    • +3
    /openacs-4/packages/xowiki/xowiki.info
    • -2
    • +10
    /openacs-4/packages/xowiki/tcl/notification-procs.tcl
2:03 pm

gustafn

- add a function ad_html_qualify_links to make e.g. relative URL handing in notifications easier

Options
    • -1
    • +42
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
12:51 pm

gustafn

- use the right variable name

Options
    • -2
    • +2
    /openacs-4/packages/notifications/tcl/notification-email-procs.tcl
12:22 pm

antoniop

Add index on ad_locale_user_prefs for foreign key user_id

Options
    • -2
    • +2
    /openacs-4/packages/acs-lang/acs-lang.info
    • -1
    • +4
    /openacs-4/packages/acs-lang/sql/postgresql/ad-locales.sql
    • -0
    • +3
    /openacs-4/packages/acs-lang/sql/postgresql/upgrade/upgrade-5.9.1d1-5.9.1d2.sql
12:22 pm

antoniop

file upgrade-5.9.1d1-5.9.1d2.sql was initially added on branch oacs-5-9.

Options
    • -0
    • +0
    /openacs-4/packages/acs-lang/sql/postgresql/upgrade/upgrade-5.9.1d1-5.9.1d2.sql
11:43 am

gustafn

- fix code for making urls absolute. regexps like [^(http|https|mailto:)] don't work, as the author expected.

Options
    • -4
    • +20
    /openacs-4/packages/notifications/tcl/notification-email-procs.tcl
Thursday 24 Nov 2016
7:24 pm

antoniop

Allow messages starting with a dash

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/chat-procs.tcl
3:53 pm

antoniop

Avoid logging every message sent to reduce IO

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/chat-procs.tcl
3:12 pm

antoniop

Removed unnecessary decoding of received messages, fixed encoding of sent messages so special characters are properly urlencoded.

Options
    • -4
    • +5
    /openacs-4/packages/chat/www/ajax/chat.js
12:47 pm

gustafn

- use :form_field_index for adding names recursively to the index

- provide more detailed debugging info

Options
    • -2
    • +1
    /openacs-4/packages/xowiki/tcl/repeat-procs.tcl
    • -2
    • +10
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
12:33 pm

antoniop

Handle in a human way when lookup of a key fails (but keep reporting in the logs)

Options
    • -3
    • +9
    /openacs-4/packages/acs-lang/www/admin/lookup.tcl
12:12 pm

gustafn

- remove commented out "if disabled" code; otherwise, the controls are also shown when viewing the items

Options
    • -24
    • +24
    /openacs-4/packages/xowiki/tcl/repeat-procs.tcl
11:36 am

antoniop

Fix typo

Options
    • -2
    • +2
    /openacs-4/packages/chat/tcl/chat-procs.tcl
11:15 am

gustafn

- add repeat container to debugging output

Options
    • -1
    • +5
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
11:00 am

gustafn

- add debugging aids in case creation of nested formfields fails

Options
    • -4
    • +6
    /openacs-4/packages/xowiki/tcl/repeat-procs.tcl
    • -2
    • +13
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl