• last updated 12 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
fixed bug: exception in test case auth_use_email_for_login_p caused test to terminate

By adding an "ad_try", we can see that the intention to create

a user with no username failed. Probably this was working at some time,

not sure, if it still should.

This is could be a general problem with "aa_run_with_teardown" to

terminate too early in such cases.

fix typo

adjust luminosity calculation to the 2020 standard for UHDTV and HDR

remove spurious parens

improve spelling

    • -2
    • +2
    /openacs-4/packages/search/tcl/search-procs.tcl
calculate total points based on points and not on minutes

    • -1
    • +1
    /openacs-4/packages/xowf/lib/inclass-exam.wf
Handle potential race condition in search observer queue maintenance

In some cases, when e.g. objects are quicky deleted after updates, the

object might be already be deleted when being tried to trigger a

DELETE operation in the search queue. as a consequence, one can sometimes

observer errors like the one below. The new code double-checks now,

if the object for the DELETE operation still exists.

ERROR: insert or update on table "search_observer_queue" violates foreign key constraint "search_observer_queue_object_id_fk"

: DETAIL: Key (object_id)=(497509146) is not present in table "acs_objects".

: CONTEXT: SQL statement "insert into search_observer_queue (

    • -2
    • +2
    /openacs-4/packages/search/search.info
file upgrade-5.10.0d3-5.10.0d4.sql was initially added on branch oacs-5-10.

whitespace changes: break overlong lines

    • -12
    • +20
    /openacs-4/packages/search/tcl/search-procs.tcl
whitespace changes

white space changes: break overlong lines

    • -24
    • +50
    /openacs-4/packages/search/tcl/search-procs.tcl
compute for and background colors from percentage to guarantee good contrast

Add 'acs_subsite_attribute_datatypes' test case, covering 'attribute::translate_datatype' and 'attribute::datatype_validator_exists_p' procs

Remove unnecessary aliases

Add 'attribute::value_add' and 'attribute::value_delete' to the 'acs_subsite_attributes' test case

improve comments

improve spelling

reduce the number of locks (nsv-accesses) for OACS_FULLQUERIES by a factor of 3 when NaviServer is used.

OACS_FULLQUERIES is one of the 3 most intensively locked nsv arrays for

busy implementation

improve test coverage

reduce visibility of internal functions

fix entry in listing of covered procs

reduce verbosity

move function db_current_rdbms to acs-bootstrap installer to improve code locality

Cleanup of low-level DB-interace: use dict instead of list with fixed positions

VS: ----------------------------------------------------------------------

    • -3
    • +3
    /openacs-4/packages/acs-tcl/acs-tcl.info
reduce usage of ad_arg_parser by using c-level implementation; fixes as well broken cases of bind-var handling

added test cases for db_0or1row and db_1row

whitespace changes

add test cases for db_list*

reduce verbosity

whitespace changes