OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 3
Total Committers: 146
Last Commit: 03 Apr
Commits this week: 3
Total Lines of Code (LoC): 7,561,510
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 12 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 20 Feb 2004
6:43 am

bdolicki

Commiting integration of Site Wide Categories into Weblogger. While

implementing this I've also fixed numerous random bugs.

Some comments off the top of my head regarding this implementation:

* Weblogger currently doesn't take advantage of nested categories. You

can use trees that are nested but categories in those trees are

treated as if they were all flat.

* I've provided a migration script from old to new categories. The

script just copies data and doesn't delete anything. It is written

in Tcl so that it can take advantage of the APIs.

* I left the legacy categories in system. There are several reasons

for that:

- Site-Wide categories don't have short names and thus speaking

URLs are not implemented. Some people might prefer to keep

speaking URLs, especially if they don't want to break them

after migration

- Blogger-specific categories are simpler and thus easier to use.

- Having both solutions available for a while makes transition less

painful.

* I had lots of problems with Oracle port. At first I thought just

that it is slightly instable because we are working on HEAD and

categories are in flux... Only after having fixed a lot of bugs I

realized that LEGACY CATEGOIRIES NEVER WORKED IN ORACLE. At that

point it was easier to make them actually work in oracle :-)

* Actually it seems that the whole Weblogger never worked in Oracle, I

was fixing bugs such as broken filtering by date (because Oracle's

trunc() uses different format strings from PostgreSQL's date_trunc()

etc. etc.

* Juggling pieces of Tcl from .tcl to .xql (via variable and command

substitution) and pieces of SQL from .xql to .tcl (via db_map) was

fun :-)

* Implementing nested multirows (to show all categories one object is

in), in combination with included templates thought me a lot about

the templating system. One of the lessons: <multirow name="@foo@">

with variable could actually work if a bunch of bugs with variable

substitution were fixed in templating system. Until then using:

template::multirow -local -ulevel 1 upvar $foo myfoo will be

necessary.

* Some extensions for db_multirow, <multiple> and friends to support

grouping and tables-within-tables would be really useful. I didn't

dare do such large-scale hacks on db_multirow

* one-entry{tcl,adp} should be replaced with blog{tcl,adp} - after all

getting one entry is just a special case of getting many entries.

Options
    • -0
    • +1
    /openacs-4/packages/lars-blogger/tcl/entry-procs-oracle.xql
    • -56
    • +61
    /openacs-4/packages/lars-blogger/www/blog-oracle.xql
    • -53
    • +51
    /openacs-4/packages/lars-blogger/www/blog-postgresql.xql
    • -5
    • +70
    /openacs-4/packages/lars-blogger/www/blog.tcl
    • -1
    • +10
    /openacs-4/packages/lars-blogger/www/entry-chunk.adp
    • -0
    • +10
    /openacs-4/packages/lars-blogger/www/entry-chunk.tcl
    • -0
    • +10
    /openacs-4/packages/lars-blogger/www/index-postgresql.xql
    • -0
    • +15
    /openacs-4/packages/lars-blogger/www/index.adp
    • -9
    • +17
    /openacs-4/packages/lars-blogger/www/index.tcl
    • -5
    • +4
    /openacs-4/packages/lars-blogger/www/index.vuh
    • -2
    • +2
    /openacs-4/packages/lars-blogger/www/index.xql
    • -0
    • +28
    /openacs-4/packages/lars-blogger/www/one-entry.tcl
    • -1
    • +5
    /openacs-4/packages/lars-blogger/www/admin/index.adp
    • -0
    • +89
    /openacs-4/packages/lars-blogger/www/admin/migrate-categories-1.tcl
    • -0
    • +19
    /openacs-4/packages/lars-blogger/www/admin/migrate-categories.adp
    • -0
    • +18
    /openacs-4/packages/lars-blogger/www/admin/migrate-categories.tcl
6:19 am

bdolicki

It may sound insane that I'm *finishing* porting of legacy, obsolete,

blogger-specific categories to Oracle, but because of its brokeness

my new stuff was broken too, so I had to fix it ... oh never mind

Options
    • -1
    • +5
    /openacs-4/packages/lars-blogger/sql/oracle/lars-blogger-package-create.sql
2:46 am

bdolicki

Fixed syntax error that broke installation (wrong close tag):

revision 1.55

date: 2004/02/19 15:03:43; author: joela; state: Exp; lines: +5 -2

added package maturity flag

Options
    • -1
    • +1
    /openacs-4/packages/acs-kernel/acs-kernel.info
2:11 am

jader

Minor updates. Hopefully fixes problem posted here:

http://openacs.org/forums/message-view?message_id=164916

Options
    • -0
    • +0
    /openacs-4/contrib/packages/resource-list/sql/postgresql/resource-list-create.sql
    • -0
    • +0
    /openacs-4/contrib/packages/resource-list/sql/postgresql/resource-list-drop.sql
    • -0
    • +0
    /openacs-4/contrib/packages/resource-list/sql/postgresql/resource-list-functions-create.sql
    • -1
    • +4
    /openacs-4/contrib/packages/resource-list/www/add-edit.tcl
    • -1
    • +5
    /openacs-4/contrib/packages/resource-list/www/approve-delete-2.tcl
    • -0
    • +0
    /openacs-4/contrib/packages/resource-list/www/approve-delete.tcl
    • -0
    • +0
    /openacs-4/contrib/packages/resource-list/www/category-add-edit.tcl
    • -1
    • +2
    /openacs-4/contrib/packages/resource-list/www/index-postgresql.xql
    • -1
    • +1
    /openacs-4/contrib/packages/resource-list/www/index.adp
    • -2
    • +9
    /openacs-4/contrib/packages/resource-list/www/index.tcl
    • -1
    • +1
    /openacs-4/contrib/packages/resource-list/www/one.adp
    • -0
    • +0
    /openacs-4/contrib/packages/resource-list/www/one.tcl
    • -0
    • +0
    /openacs-4/contrib/packages/resource-list/www/type-add-edit.tcl
    • -0
    • +0
    /openacs-4/contrib/packages/resource-list/www/types.tcl
1:08 am

daveb

Fix regsubs for uri.

Options
    • -3
    • +3
    /openacs-4/packages/oacs-dav/tcl/oacs-dav-procs.tcl
Thursday 19 Feb 2004
11:27 pm

donb

Removed bogus tree_sortkey reference in the Oracle version ...

Options
    • -1
    • +2
    /openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl
    • -1
    • +0
    /openacs-4/packages/acs-tcl/tcl/object-procs-oracle.xql
10:16 pm

bdolicki

added a flag to take advantage of util_user_message in ad_progress_bar_end

Options
    • -0
    • +2
    /openacs-4/packages/acs-tcl/tcl/defs-procs.tcl
8:11 pm

timoh

bugfix: get triggers to compile

Options
    • -5
    • +9
    /openacs-4/packages/categories/sql/oracle/category-synonym-package.sql
7:41 pm

timoh

moved doc to proc category::list::elements

Options
    • -29
    • +34
    /openacs-4/packages/categories/tcl/category-list-procs.tcl
7:17 pm

jader

Added in more explanation about how to do hierarchical queries with Oracle.

Options
    • -1
    • +7
    /openacs-4/packages/acs-core-docs/www/xml/developers-guide/tutorial-advanced.xml
6:56 pm

dirkg

A few more CSS modifications

Slimmed down the CSS file considerably

Removed markup from the view pages

Unified multirow names

Unified sql queries

Use partialqueries more consistently

(These changes should be backwards-compatible with .LRN 2.0 and .LRN

head. Testing needs to be done here, fixing will take place during the

feature freeze period)

Options
    • -13
    • +18
    /openacs-4/packages/calendar/www/view-list-display.adp
    • -19
    • +46
    /openacs-4/packages/calendar/www/view-list-display.tcl
    • -17
    • +16
    /openacs-4/packages/calendar/www/view-month-display.adp
    • -58
    • +99
    /openacs-4/packages/calendar/www/view-month-display.tcl
    • -64
    • +52
    /openacs-4/packages/calendar/www/view-one-day-display.adp
    • -97
    • +82
    /openacs-4/packages/calendar/www/view-one-day-display.tcl
    • -33
    • +22
    /openacs-4/packages/calendar/www/view-week-display.adp
    • -42
    • +71
    /openacs-4/packages/calendar/www/view-week-display.tcl
    • -26
    • +42
    /openacs-4/packages/calendar/www/views-oracle.xql
    • -39
    • +55
    /openacs-4/packages/calendar/www/views-postgresql.xql
    • -136
    • +78
    /openacs-4/packages/calendar/www/resources/calendar.css
6:46 pm

dirkg

Added

Options
    • -0
    • +17
    /openacs-4/packages/calendar/www/views.xql
5:44 pm

daveb

Put fs::new_root_folder tcl procedure back in. It has new optional parameters

but should behave the same as the original procedure.

Options
    • -3
    • +6
    /openacs-4/packages/file-storage/sql/oracle/file-storage-package-create.sql
    • -3
    • +5
    /openacs-4/packages/file-storage/sql/postgresql/file-storage-package-create.sql
    • -1
    • +2
    /openacs-4/packages/file-storage/tcl/file-storage-procs-oracle.xql
    • -3
    • +4
    /openacs-4/packages/file-storage/tcl/file-storage-procs-postgresql.xql
    • -3
    • +37
    /openacs-4/packages/file-storage/tcl/file-storage-procs.tcl
4:10 pm

dirkg

Moved all remaining procs into the calendar namespace

Options
    • -29
    • +4
    /openacs-4/packages/calendar/tcl/calendar-procs.tcl
4:04 pm

dirkg

Added compatibility procs

Options
    • -0
    • +50
    /openacs-4/packages/calendar/tcl/calendar-compatibility-procs.tcl
4:03 pm

joela

added package maturity flag

Options
    • -2
    • +5
    /openacs-4/packages/acs-kernel/acs-kernel.info
4:03 pm

dirkg

Typo fix

Options
    • -4
    • +9
    /openacs-4/packages/calendar/www/cal-item-create-recurrence-2.tcl
3:59 pm

joela

updated package version numbers in core from 5.0.0 to 5.1.0d1

Options
    • -2
    • +2
    /openacs-4/packages/acs-admin/acs-admin.info
    • -6
    • +4
    /openacs-4/packages/acs-admin/www/apm/build-repository.tcl
    • -2
    • +2
    /openacs-4/packages/acs-api-browser/acs-api-browser.info
    • -2
    • +2
    /openacs-4/packages/acs-authentication/acs-authentication.info
    • -30
    • +25
    /openacs-4/packages/acs-authentication/www/doc/configure-batch-sync.html
    • -3
    • +3
    /openacs-4/packages/acs-authentication/www/doc/ext-auth-design.html
    • -3
    • +4
    /openacs-4/packages/acs-authentication/www/doc/ext-auth-install.html
    • -1
    • +1
    /openacs-4/packages/acs-authentication/www/doc/ext-auth-ldap-install.html
    • -5
    • +5
    /openacs-4/packages/acs-authentication/www/doc/ext-auth-pam-install.html
    • -5
    • +5
    /openacs-4/packages/acs-authentication/www/doc/ims-sync-driver-design.html
    • -1
    • +1
    /openacs-4/packages/acs-authentication/www/doc/index.html
    • -2
    • +2
    /openacs-4/packages/acs-automated-testing/acs-automated-testing.info
    • -2
    • +2
    /openacs-4/packages/acs-bootstrap-installer/acs-bootstrap-installer.info
    • -2
    • +2
    /openacs-4/packages/acs-core-docs/acs-core-docs.info
    • -2
    • +2
    /openacs-4/packages/acs-lang/acs-lang.info
  16. … 10 more files in changeset.
12:36 pm

joela

added xml-rpc module to support dotlrn-prereq

Options
    • -0
    • +1
    /CVSROOT/modules
12:19 pm

joela

added xml-rpc to dotlrn-prereq

Options
    • -1
    • +1
    /CVSROOT/modules
12:01 pm

joela

fixed directory/newer bug

Options
    • -3
    • +3
    /openacs-4/etc/backup.sh
11:48 am

joela

added oacs-dav to dotlrn-prereq module

Options
    • -1
    • +1
    /CVSROOT/modules
11:47 am

lars

Grant commit to Joel Aufrecht on CVSROOT

Options
    • -0
    • +1
    /CVSROOT/avail
10:37 am

lars

We still want security_inherit_p to default to 't', otherwise bcms::folder::create_folder breaks, because null is not a valid boolean value. This is also consistent with what the comments in the function says (default true)

Options
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/sql/postgresql/content-folder.sql
1:08 am

rocaelh

fix bug 1131

Options
    • -1
    • +1
    /openacs-4/packages/wp-slim/www/index-unregistered.adp
    • -1
    • +1
    /openacs-4/packages/wp-slim/www/users.adp
    • -11
    • +2
    /openacs-4/packages/wp-slim/www/users.tcl
    • -1
    • +1
    /openacs-4/packages/wp-slim/www/users.xql
12:26 am

dirkg

Replaced calendar_have_private_p with calendar::have_private_p

Options
    • -2
    • +2
    /openacs-4/packages/calendar-portlet/www/calendar-full-portlet.tcl
    • -2
    • +2
    /openacs-4/packages/calendar-portlet/www/calendar-list-portlet.tcl
    • -2
    • +2
    /openacs-4/packages/calendar-portlet/www/calendar-portlet.tcl
    • -2
    • +2
    /openacs-4/packages/dotlrn-calendar/tcl/dotlrn-calendar-procs.tcl
Wednesday 18 Feb 2004
10:25 pm

rocaelh

change checking of validity of term dates

Options
    • -4
    • +4
    /openacs-4/packages/dotlrn/www/admin/term-edit.tcl
    • -4
    • +4
    /openacs-4/packages/dotlrn/www/admin/term-new.tcl
10:05 pm

bdolicki

Added doc string

Options
    • -2
    • +4
    /openacs-4/packages/acs-templating/tcl/query-procs.tcl
9:59 pm

bdolicki

Added exists command to template::multirow

Options
    • -3
    • +8
    /openacs-4/packages/acs-templating/tcl/query-procs.tcl
7:40 pm

timoh

added procs for easy use in listbuilder

Options
    • -11
    • +43
    /openacs-4/packages/categories/tcl/categories-procs.tcl
    • -7
    • +9
    /openacs-4/packages/categories/tcl/categories-procs.xql
    • -0
    • +898
    /openacs-4/packages/categories/tcl/category-list-procs.tcl