Activity OpenACS/

11:18 am

antoniop

More
MAIN:antoniop:20170816091820
changed 3 files
MAIN

Small improvement for portrait management (deletion)

Exploit existing on delete cascade constraints when we delete a portrait, instead of deleting stuff manually.

Also, put remaining logics into a proc and use it in acs_user::delete to address legit use case of people wanting

to remove a user permanently without removing portrait in advance.

- -33
- +5
/openacs-4/packages/acs-subsite/www/user/portrait/erase.tcl
- History
- Source
- Diff
/openacs-4/packages/.../portrait/erase.tcl
- -46
- +0
/openacs-4/packages/acs-subsite/www/user/portrait/erase.xql
- History
- Source
- Diff
/openacs-4/packages/.../portrait/erase.xql
- -1
- +24
/openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl
- History
- Source
- Diff
/openacs-4/.../community-core-procs.tcl

2:36 pm

gustafn

More
MAIN:gustafn:20170813123601
changed 4 files
MAIN

fix: make sure to pass displayed_object_id always to the next master template

- -0
- +1
/openacs-4/packages/b-responsive-theme/lib/plain-master.adp
- History
- Source
- Diff
/openacs-4/packages/.../lib/plain-master.adp
- -0
- +1
/openacs-4/packages/layout-managed-subsite/lib/plain-master.adp
- History
- Source
- Diff
/openacs-4/packages/.../lib/plain-master.adp
- -0
- +1
/openacs-4/packages/openacs-bootstrap3-theme/resources/masters/plain-master.adp
- History
- Source
- Diff
/openacs-4/packages/.../plain-master.adp
- -0
- +1
/openacs-4/packages/openacs-default-theme/lib/plain-master.adp
- History
- Source
- Diff
/openacs-4/packages/.../lib/plain-master.adp

2:34 pm

gustafn

fix: make sure to pass displayed_object_id always to the next master template

- -0
- +1
/openacs-4/packages/openacs-bootstrap3-theme/resources/masters/plain-master.adp
- History
- Source
- Diff
/openacs-4/packages/.../plain-master.adp
- -0
- +1
/openacs-4/packages/openacs-default-theme/lib/plain-master.adp
- History
- Source
- Diff
/openacs-4/packages/.../lib/plain-master.adp

3:51 pm

gustafn

More
MAIN:gustafn:20170811135153
changed 1 file
MAIN

Turn off shared workflow definition as indicated in the last message

- -1
- +1
/openacs-4/packages/xowf/tcl/xowf-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/xowf-procs.tcl

3:35 pm

gustafn

More
MAIN:gustafn:20170811133548
changed 4 files
MAIN

Add Feature: Shared Workflow Definitions

Background: so far, xowf stored workflow definitions in the workflow

context, which is generated for every instantiated workflow instance

due to the needs of the State Pattern. While the old approach works

perfectly fine, when pre request only one or a few workflow instances

are created, but is inefficient, when e.g. 100 or more instances of

the workflow definition are created.

Now, the instances can share the definition, which is shared based on

the revision_id of the workflow FormPage.

OLD: obj <-> obj::wf_ctx

NEW: obj <-> obj::wf_ctx <(n)----> wf_definition

OLD scenario:

- the wf_definition was part of the context (no distinction)

- navigation from wf_ctx (and wf_definition) to object was possible

via "info parent"

NEW scenario:

- the wf_definition is separate

- one wf_definition can be used for multiple wf_ctx

- new methods are required instead of "info parent"

to navigate between these cooperating objects

* xowf::WorkflowPage.wf_context

* xowf::WorkflowConstruct.wf_context

* xowf::Context.wf_container

The navigation from a WorkflowConstruct (e.g. State) to the wf_ctx

is slow and fragile if not following usual programming conventions

and should e avoided (the methods of these constructs have the obj

passed in, so this path should not be necessary in most situations)

- as long the contents of the wf_container is constant, it can be

shared in the per-thread cache.

For now, the new feature is turned off by default via variable

::xowf::sharedWorkflowDefinition, but this will change in the future.

- -2
- +2
/openacs-4/packages/xowf/xowf.info
- History
- Source
- Diff
/openacs-4/packages/xowf/xowf.info
- -8
- +8
/openacs-4/packages/xowf/lib/online-exam.wf
- History
- Source
- Diff
/openacs-4/packages/.../lib/online-exam.wf
- -190
- +318
/openacs-4/packages/xowf/tcl/xowf-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/xowf-procs.tcl
- -4
- +8
/openacs-4/packages/xowf/www/index.vuh
- History
- Source
- Diff
/openacs-4/packages/xowf/www/index.vuh

2:54 pm

antoniop

More
MAIN:antoniop:20170811125440
changed 2 files
MAIN

Make so that refreshing of theming subsite parameters doesn't include locally modified subsites

This includes also moving of logic to identify local modifications in a proc

- -23
- +73
/openacs-4/packages/acs-subsite/tcl/subsite-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/subsite-procs.tcl
- -25
- +4
/openacs-4/packages/acs-subsite/www/admin/themes/index.tcl
- History
- Source
- Diff
/openacs-4/packages/.../themes/index.tcl

2:39 pm

gustafn

More
MAIN:gustafn:20170811123947
changed 9 files
MAIN

Regenerate ADP files

- -1
- +1
/openacs-4/packages/xowiki/resources/templates/oacs-view.adp
- History
- Source
- Diff
/openacs-4/packages/.../oacs-view.adp
- -1
- +1
/openacs-4/packages/xowiki/resources/templates/oacs-view2.adp
- History
- Source
- Diff
/openacs-4/packages/.../oacs-view2.adp
- -1
- +1
/openacs-4/packages/xowiki/resources/templates/oacs-view3-bootstrap3.adp
- History
- Source
- Diff
/openacs-4/.../oacs-view3-bootstrap3.adp
- -1
- +1
/openacs-4/packages/xowiki/resources/templates/oacs-view3.adp
- History
- Source
- Diff
/openacs-4/packages/.../oacs-view3.adp
- -1
- +1
/openacs-4/packages/xowiki/resources/templates/view-book-no-ajax.adp
- History
- Source
- Diff
/openacs-4/packages/.../view-book-no-ajax.adp
- -1
- +1
/openacs-4/packages/xowiki/resources/templates/view-book.adp
- History
- Source
- Diff
/openacs-4/packages/.../view-book.adp
- -1
- +1
/openacs-4/packages/xowiki/resources/templates/view-default.adp
- History
- Source
- Diff
/openacs-4/packages/.../view-default.adp
- -1
- +1
/openacs-4/packages/xowiki/resources/templates/view-links.adp
- History
- Source
- Diff
/openacs-4/packages/.../view-links.adp
- -1
- +1
/openacs-4/packages/xowiki/resources/templates/view-plain.adp
- History
- Source
- Diff
/openacs-4/packages/.../view-plain.adp

2:38 pm

gustafn

More
MAIN:gustafn:20170811123843
changed 1 file
MAIN

Add feature: overwrite generated ADP files only when necessary

Cases might be:

- ADP file list

- Generator updated

- -9
- +15
/openacs-4/packages/xowiki/tcl/adp-generator-procs.tcl
- History
- Source
- Diff
/openacs-4/.../adp-generator-procs.tcl

10:18 am

gustafn

Fix: close link target (<a name ...>); backport from HEAD

- -2
- +2
/openacs-4/packages/xotcl-core/www/index.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/index.tcl

10:15 am

gustafn

More
MAIN:gustafn:20170811081524
changed 1 file
MAIN

Fix: close link target (<a name ...>)

- -2
- +2
/openacs-4/packages/xotcl-core/www/index.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/index.tcl

7:29 pm

antoniop

More
MAIN:antoniop:20170810172917
changed 1 file
MAIN

Added procs to quickly issue refresh of subsite theme parameters from current theme defaults. This is useful in a context with many subsites using the same theme, when desired behavior at upgrade is to have them reload all parameters automatically.

- -1
- +53
/openacs-4/packages/acs-subsite/tcl/subsite-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/subsite-procs.tcl

11:42 am

antoniop

More
MAIN:antoniop:20170809094218
changed 1 file
MAIN

Fix typo

- -1
- +1
/openacs-4/packages/xowiki/www/portlets/weblog-mini-calendar.adp
- History
- Source
- Diff
/openacs-4/.../weblog-mini-calendar.adp

9:55 pm

gustafn

More
MAIN:gustafn:20170808195520
changed 1 file
MAIN

Remove dependency on calender for message-key

- -2
- +2
/openacs-4/packages/xowiki/www/portlets/weblog-mini-calendar.adp
- History
- Source
- Diff
/openacs-4/.../weblog-mini-calendar.adp

1:47 am

gustafn

More
MAIN:gustafn:20170807234743
changed 7835 files
MAIN

merged changes from the oacs-5-9 branch and resolved conflicts

- -0
- +289
/openacs-4/Announce-OpenACS-5.9.0
- History
- Source
- Diff
/openacs-4/Announce-OpenACS-5.9.0
- -0
- +511
/openacs-4/Announce-OpenACS-5.9.1
- History
- Source
- Diff
/openacs-4/Announce-OpenACS-5.9.1
- -36687
- +221521
/openacs-4/ChangeLog
- History
- Source
- Diff
/openacs-4/ChangeLog
- -5
- +4
/openacs-4/readme.txt
- History
- Source
- Diff
/openacs-4/readme.txt
- -23
- +106
/openacs-4/release-steps.txt
- History
- Source
- Diff
/openacs-4/release-steps.txt
- -6
- +6
/openacs-4/etc/backup.sh
- History
- Source
- Diff
/openacs-4/etc/backup.sh
- -31
- +29
/openacs-4/etc/config.tcl
- History
- Source
- Diff
/openacs-4/etc/config.tcl
- -6
- +8
/openacs-4/packages/acs-admin/acs-admin.info
- History
- Source
- Diff
/openacs-4/packages/.../acs-admin.info
- -0
- +78
/openacs-4/packages/acs-admin/catalog/acs-admin.de_DE.ISO-8859-1.xml
- History
- Source
- Diff
/openacs-4/.../acs-admin.de_DE.ISO-8859-1.xml
- -0
- +84
/openacs-4/packages/acs-admin/catalog/acs-admin.it_IT.ISO-8859-1.xml
- History
- Source
- Diff
/openacs-4/.../acs-admin.it_IT.ISO-8859-1.xml
- -1
- +7
/openacs-4/packages/acs-admin/lib/become.tcl
- History
- Source
- Diff
/openacs-4/packages/.../lib/become.tcl
- -0
- +6
/openacs-4/packages/acs-admin/lib/developer-services.tcl
- History
- Source
- Diff
/openacs-4/.../developer-services.tcl
- -0
- +6
/openacs-4/packages/acs-admin/lib/password-update.tcl
- History
- Source
- Diff
/openacs-4/packages/.../password-update.tcl
- -2
- +3
/openacs-4/packages/acs-admin/lib/service-parameters-oracle.xql
- History
- Source
- Diff
/openacs-4/.../service-parameters-oracle.xql
- -2
- +3
/openacs-4/packages/acs-admin/lib/service-parameters-postgresql.xql
- History
- Source
- Diff
/openacs-4/.../service-parameters-postgresql.xql
… 7820 more files in changeset.

11:11 pm

gustafn

undo untested last minute check

- -2
- +8
/openacs-4/packages/acs-tcl/tcl/apm-install-procs-oracle.xql
- History
- Source
- Diff
/openacs-4/.../apm-install-procs-oracle.xql
- -2
- +8
/openacs-4/packages/acs-tcl/tcl/apm-install-procs-postgresql.xql
- History
- Source
- Diff
/openacs-4/.../apm-install-procs-postgresql.xql
- -6
- +6
/openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../apm-install-procs.tcl

8:40 pm

antoniop

Fix typo

- -2
- +2
/openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../site-nodes-procs.tcl

6:43 pm

antoniop

Flush cache also for ancestors of nodes when mounting a package

- -4
- +6
/openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../site-nodes-procs.tcl

3:34 pm

antoniop

Unify version comparison logics so we always use apm_version_names_compare instead of other db api as apm_package_version__version_name_greater plus handcrafted queries which also might behave slightly differently