• last updated 20 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

    • -4
    • +4
    ./acs-admin/www/apm/build-repository.tcl
    • -4
    • +4
    ./acs-admin/www/apm/packages-install.tcl
    • -2
    • +2
    ./acs-admin/www/apm/version-callbacks.tcl
    • -3
    • +3
    ./acs-admin/www/apm/version-reload.tcl
    • -4
    • +4
    ./acs-admin/www/auth/authority-parameters.tcl
    • -7
    • +7
    ./acs-api-browser/tcl/acs-api-documentation-procs.tcl
    • -2
    • +2
    ./acs-api-browser/www/content-page-view.tcl
    • -4
    • +4
    ./acs-api-browser/www/package-view.tcl
  1. … 461 more files in changeset.
Reduce query duplication

    • -15
    • +2
    ./acs-service-contract/tcl/acs-service-contract-procs-oracle.xql
    • -16
    • +2
    ./acs-service-contract/tcl/acs-service-contract-procs-postgresql.xql
    • -3
    • +5
    ./acs-service-contract/tcl/acs-service-contract-procs.tcl
Prefer indivudual 'set' operations over 'lassign' in this case.

Rework variable assigning loops (set -> lassign)

    • -3
    • +2
    ./tsearch2-driver/tcl/tsearch2-driver-procs.tcl
Rework variable assigning loops (set -> lassign) + Whitespace changes

    • -18
    • +17
    ./acs-admin/www/apm/version-dependency-add-2.tcl
    • -4
    • +3
    ./acs-admin/www/apm/version-i18n-process.tcl
    • -2
    • +1
    ./acs-authentication/lib/local-search.tcl
    • -3
    • +1
    ./acs-bootstrap-installer/db-init-checks-oracle.tcl
    • -3
    • +2
    ./acs-bootstrap-installer/tcl/00-proc-procs.tcl
    • -3
    • +2
    ./acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl
    • -192
    • +190
    ./acs-content-repository/tcl/publish-procs.tcl
    • -3
    • +2
    ./acs-developer-support/www/request-info.tcl
    • -87
    • +85
    ./acs-lang/tcl/lang-util-procs.tcl
    • -7
    • +3
    ./acs-mail-lite/tcl/imap-inbound-procs.tcl
Prefer 'lset' to 'lreplace'.

    • -3
    • +3
    ./acs-templating/tcl/doc-tcl-procs.tcl
Prefer string operators to 'string equal'.

    • -2
    • +2
    ./acs-admin/www/apm/build-repository.tcl
    • -5
    • +5
    ./acs-templating/tcl/test/date-procs.tcl
Rework string comparison expression

Rework list operations

Add 'aggregation_format' option to list template (many thanks to Felix Moedritscher)

    • -1
    • +12
    ./acs-templating/tcl/list-procs.tcl
put the correct function into upgrade script

Replace 'linsert' with 'lappend'

Fix linsert command argument expansion + Whitespace

    • -31
    • +30
    ./notifications/tcl/sweep-procs.tcl
Replace 'exists_and_not_null'

Replace deprecated proc 'ad_parameter' with 'parameter::get'

Replace deprecated proc 'empty_string_p'

    • -1
    • +1
    ./assessment/www/asm-admin/item-add-mc.tcl
    • -3
    • +3
    ./bug-tracker/www/admin/formwizard.tcl
image width information in table images seems flaky. since portrait-bits provides efficient

scaling, why not use it?

increase number of accepted sizes

    • -2
    • +2
    ./acs-subsite/www/shared/portrait-bits.tcl
improve CSP in accordance with Google's csp-evaluator.withgoogle.com

imporve spelling

fix typo

Replace obsolete function bitfromint4() by cast

    • -3
    • +3
    ./acs-kernel/sql/postgresql/postgresql.sql
    • -0
    • +38
    ./acs-kernel/sql/postgresql/upgrade/upgrade-5.10.0d5-5.10.0d6.sql
make spelling more uniform

    • -2
    • +2
    ./acs-templating/tcl/apm-callback-procs.tcl
    • -2
    • +2
    ./acs-templating/tcl/richtext-procs.tcl
reduce verbosity

improve list operations

    • -2
    • +2
    ./acs-api-browser/tcl/acs-api-documentation-procs.tcl
    • -2
    • +2
    ./acs-bootstrap-installer/tcl/00-proc-procs.tcl
    • -1
    • +1
    ./acs-outdated/tcl/acs-tcl-admin-procs.tcl
    • -14
    • +26
    ./categories/tcl/widget-procs.tcl
make spelling more consistent

    • -2
    • +2
    ./general-comments/tcl/general-comments-procs.tcl
regenerated documentation

    • -11
    • +11
    ./assessment/www/doc/as_items.adp
    • -2
    • +2
    ./assessment/www/doc/data_collection.adp
    • -1
    • +1
    ./assessment/www/doc/display_types.adp
    • -9
    • +9
    ./assessment/www/doc/asm_trigger_doc/bi01.adp
    • -9
    • +9
    ./assessment/www/doc/asm_trigger_doc/bi02.adp
    • -9
    • +9
    ./assessment/www/doc/asm_trigger_doc/ch01.adp
    • -9
    • +9
    ./assessment/www/doc/asm_trigger_doc/ch02.adp
  1. … 14 more files in changeset.
improve list operations

improve grammar

Improve grammer and make spelling more consistent