OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 22
Total Committers: 146
Last Commit: 26 Nov
Commits this week: 22
Total Lines of Code (LoC): 7,560,945
Net change in LoC this week: 141

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 15 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 18 Aug 2015
2:34 pm

gustafn

- remove globals for errorInfo and use namespace qualifiers instead

Options
    • -3
    • +2
    /openacs-4/packages/acs-subsite/www/admin/applications/application-add.tcl
    • -3
    • +2
    /openacs-4/packages/acs-subsite/www/admin/applications/multiple-add.tcl
    • -3
    • +2
    /openacs-4/packages/acs-subsite/www/members/member-invite.tcl
    • -2
    • +1
    /openacs-4/packages/acs-subsite/www/permissions/perm-modify.tcl
    • -3
    • +2
    /openacs-4/packages/acs-subsite/www/register/user-join.tcl
    • -3
    • +2
    /openacs-4/packages/acs-subsite/www/shared/1pixel.tcl
2:33 pm

gustafn

- don't use errorInfo as variable name, if just error message is meant

Options
    • -4
    • +4
    /openacs-4/packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl
2:25 pm

gustafn

- remove globals for errorInfo/errorCode and use namespace qualifiers instead

Options
    • -9
    • +5
    /openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
    • -4
    • +3
    /openacs-4/packages/acs-automated-testing/tcl/http.tcl
    • -3
    • +2
    /openacs-4/packages/acs-automated-testing/tcl/tclwebtest-procs.tcl
    • -2
    • +1
    /openacs-4/packages/acs-developer-support/www/shell.tcl
2:22 pm

gustafn

- remove globals for errorInfo and use namespace qualifiers instead

Options
    • -3
    • +2
    /openacs-4/packages/acs-admin/www/apm/build-repository.tcl
    • -3
    • +2
    /openacs-4/packages/acs-admin/www/apm/version-callback-invoke.tcl
    • -4
    • +2
    /openacs-4/packages/acs-admin/www/apm/version-generate-diffs.tcl
    • -9
    • +5
    /openacs-4/packages/acs-authentication/tcl/authentication-procs.tcl
    • -5
    • +3
    /openacs-4/packages/acs-authentication/tcl/authority-procs.tcl
    • -3
    • +2
    /openacs-4/packages/acs-authentication/tcl/driver-procs.tcl
    • -9
    • +5
    /openacs-4/packages/acs-authentication/tcl/local-procs.tcl
    • -15
    • +8
    /openacs-4/packages/acs-authentication/tcl/password-procs.tcl
    • -6
    • +4
    /openacs-4/packages/acs-authentication/tcl/sync-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-bootstrap-installer/bootstrap.tcl
    • -4
    • +3
    /openacs-4/packages/acs-bootstrap-installer/installer.tcl
    • -5
    • +3
    /openacs-4/packages/acs-lang/tcl/lang-catalog-procs.tcl
    • -7
    • +3
    /openacs-4/packages/acs-lang/tcl/test/acs-lang-test-procs.tcl
    • -2
    • +1
    /openacs-4/packages/acs-lang/www/admin/lookups-include.tcl
    • -2
    • +1
    /openacs-4/packages/acs-lang/www/admin/message-usage-include.tcl
    • -2
    • +1
    /openacs-4/packages/acs-lang/www/admin/set-system-timezone.tcl
2:19 pm

gustafn

- streamline spelleck (sub)widget of richtext between different modes, fix one more label occurance

Options
    • -3
    • +3
    /openacs-4/packages/acs-templating/tcl/richtext-procs.tcl
2:17 pm

gustafn

- fix indentation

Options
    • -2
    • +2
    /openacs-4/packages/forums/tcl/form-procs.tcl
1:39 pm

gustafn

- don't let <label> contain <input> fields, end the label text before it.

The original version has bad effects on e.g. bootstrap, which sets

a font-property for <label>, which is afterwards as well used for input fields.

Options
    • -6
    • +9
    /openacs-4/packages/acs-templating/resources/forms/standard.adp
    • -9
    • +15
    /openacs-4/packages/acs-templating/tcl/richtext-procs.tcl
1:17 pm

gustafn

- improve validity for HTML5

Options
    • -7
    • +10
    /openacs-4/packages/acs-bootstrap-installer/installer/www/blank-master.tcl
    • -7
    • +10
    /openacs-4/www/blank-master.tcl
12:42 pm

gustafn

- improve validation for HTML and HTML5

Options
    • -5
    • +10
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
    • -6
    • +8
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
11:56 am

gustafn

- quote tags in javascript code (ns_quotehtml is too much)

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/30-widget-procs.tcl
11:18 am

gustafn

- update documentation

- remove uneeded backslashes

Options
    • -3
    • +15
    /openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
11:01 am

gustafn

- add "path" to page contract filters to improve security, used e.g. by api-doc in procs-file-view

Options
    • -2
    • +2
    /openacs-4/packages/acs-api-browser/www/procs-file-view.tcl
    • -3
    • +18
    /openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
Monday 17 Aug 2015
7:45 pm

gustafn

- remove globals for errorInfo/errorCode and use namespace qualifiers instead

Options
    • -6
    • +3
    /openacs-4/packages/acs-tcl/tcl/adp-parser-procs.tcl
    • -5
    • +3
    /openacs-4/packages/acs-tcl/tcl/apm-file-procs.tcl
    • -11
    • +7
    /openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl
    • -2
    • +1
    /openacs-4/packages/acs-tcl/tcl/form-processing-procs.tcl
    • -5
    • +4
    /openacs-4/packages/acs-tcl/tcl/openacs-kernel-procs.tcl
    • -5
    • +3
    /openacs-4/packages/acs-tcl/tcl/parameter-procs.tcl
    • -5
    • +4
    /openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl
    • -4
    • +3
    /openacs-4/packages/acs-tcl/tcl/stack-trace-procs.tcl
    • -7
    • +5
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -11
    • +6
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
    • -10
    • +4
    /openacs-4/packages/acs-templating/tcl/filter-procs.tcl
    • -4
    • +3
    /openacs-4/packages/acs-templating/tcl/query-procs.tcl
    • -7
    • +5
    /openacs-4/packages/acs-templating/tcl/tag-init.tcl
7:06 pm

gustafn

- provide nicer and more complete documentation

Options
    • -3
    • +13
    /openacs-4/packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl
6:43 pm

gustafn

ad_proc reform:

- use nsf::proc for defining ad_procs, when nsf::proc is available

- nsf::proc is part of the environment of XOTcl2 and provides

an efficient, C-implemented argument parser that can replace

the scripted *__arg_parser of OpenACS.

- The benefits are performance and reduced memory consumption.

* Simple functions (where the calling overhead was a large

part of the execution times can become several times faster

(e.g. db_name is 3x faster, cookie handling is 2x faster),

for functions with much db-activities the percentage will

be less.

* The memory consumption (RSS) of a site like OpenACS.org

is reduced by about 15%.

NEW (with nsf::proc)

::ad_get_cookie x: 10.93 microseconds per iteration

::ad_get_cookie ad_session_id: 21.95 microseconds per iteration

::dt_systime: 24.89 microseconds per iteration

::db_name: 8.70 microseconds per iteration

::db_string dbqd.null.g "select version() from dual": 316.66 microseconds per iteration

::ad_convert_to_html "hello world": 102.29 microseconds per iteration

OLD (without nsf::proc)

::ad_get_cookie x: 19.42 microseconds per iteration

::ad_get_cookie ad_session_id: 30.10 microseconds per iteration

::dt_systime: 27.55 microseconds per iteration

::db_name: 32.28 microseconds per iteration

::db_string dbqd.null.g "select version() from dual": 366.69 microseconds per iteration

::ad_convert_to_html "hello world": 160.51 microseconds per iteration

======================================================================

proc mtime cmd {set c 5000

set t [time [list time $cmd $c]];

regexp {^(-?[0-9]+) +} $t _ mS1;

set ms [expr {$mS1*1.0/$c}];

return "[format %6.2f $ms] microseconds per iteration"

}

set tests {

{::ad_get_cookie x} {::ad_get_cookie ad_session_id} {::dt_systime}

{::db_name} {::db_string dbqd.null.g "select version() from dual"}

{::ad_convert_to_html "hello world"}

}

foreach t $tests {append ::_ $t ": " [mtime $t] \n}

set ::_

======================================================================

Options
    • -18
    • +10
    /openacs-4/packages/acs-authentication/tcl/test/acs-authentication-procs.tcl
    • -3
    • +1
    /openacs-4/packages/acs-authentication/tcl/test/sync-test-procs.tcl
    • -47
    • +87
    /openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-bootstrap-installer/acs-bootstrap-installer.info
    • -4
    • +8
    /openacs-4/packages/acs-bootstrap-installer/installer/tcl/0-acs-init.tcl
    • -26
    • +82
    /openacs-4/packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-bootstrap-installer/tcl/30-apm-load-procs.tcl
    • -2
    • +10
    /openacs-4/packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl
    • -6
    • +10
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
    • -4
    • +8
    /openacs-4/tcl/0-acs-init.tcl
5:49 pm

gustafn

- add @see for deprecated proc

Options
    • -1
    • +3
    /openacs-4/packages/acs-content-repository/tcl/keyword-procs.tcl
5:29 pm

gustafn

- fix page contracts, improve saftey of argument passing via URLs

Options
    • -15
    • +19
    /openacs-4/packages/acs-automated-testing/www/admin/rerun.tcl
    • -3
    • +3
    /openacs-4/packages/acs-automated-testing/www/admin/testcase.tcl
5:20 pm

gustafn

- update head channel

Options
    • -2
    • +2
    /openacs-4/packages/acs-admin/tcl/apm-admin-procs.tcl
5:19 pm

gustafn

- remove backup file from repository

Options
    • -4
    • +0
    /openacs-4/packages/intermedia-driver/sql/oracle/intermedia-driver-drop.sql~
12:47 am

gustafn

file upgrade-5.9.0d4-5.9.0d5.sql was initially added on branch oacs-5-9.

Options
    • -0
    • +0
    /openacs-4/packages/acs-content-repository/sql/postgresql/upgrade/upgrade-5.9.0d4-5.9.0d5.sql
12:47 am

gustafn

- follow naming conventions proposed by regression test

- bump version number

Options
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/acs-content-repository.info
    • -3
    • +3
    /openacs-4/packages/acs-content-repository/sql/postgresql/content-create.sql
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/sql/postgresql/content-update.sql
    • -0
    • +8
    /openacs-4/packages/acs-content-repository/sql/postgresql/upgrade/upgrade-5.9.0d4-5.9.0d5.sql
12:28 am

gustafn

- add documentation for public procs (fix for issue #3246)

Options
    • -5
    • +11
    /openacs-4/packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl
12:07 am

gustafn

- fix syntax and indentation

Options
    • -127
    • +126
    /openacs-4/packages/dotlrn/www/dotlrn-master-kelp.tcl
    • -8
    • +13
    /openacs-4/packages/evaluation/www/admin/evaluations/student-list.tcl
Sunday 16 Aug 2015
11:55 pm

gustafn

- fix syntax

Options
    • -5
    • +8
    /openacs-4/packages/acs-developer-support/www/css-edit.tcl
11:43 pm

gustafn

- remove acs_objects.tree_sortkey from xql query for object::get

Options
    • -1
    • +0
    /openacs-4/packages/acs-tcl/tcl/object-procs-postgresql.xql
Saturday 15 Aug 2015
7:15 am

gustafn

- reduce verbosity

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
Friday 14 Aug 2015
7:28 pm

gustafn

- backport from oacs-5-9

Options
    • -0
    • +12
    /openacs-4/packages/xowiki/tcl/xowiki-init.tcl
    • -12
    • +28
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
    • -2
    • +8
    /openacs-4/packages/xowiki/tcl/xowiki-utility-procs.tcl
7:25 pm

gustafn

- when form_instance_item_index is dropped, and hstore should be used,

repopulate the item_index with hstore values

- ::xowiki::hstore::update_update_all_form_instances respects now the

use_hstore package parameter values

Options
    • -0
    • +12
    /openacs-4/packages/xowiki/tcl/xowiki-init.tcl
    • -12
    • +28
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
    • -2
    • +8
    /openacs-4/packages/xowiki/tcl/xowiki-utility-procs.tcl
7:25 pm

gustafn

file xowiki-init.tcl was added on branch oacs-5-8 on 2015-08-14 17:28:07 +0000

Options
    • -0
    • +0
    /openacs-4/packages/xowiki/tcl/xowiki-init.tcl
7:25 pm

gustafn

file xowiki-init.tcl was initially added on branch oacs-5-9.

Options
    • -0
    • +0
    /openacs-4/packages/xowiki/tcl/xowiki-init.tcl