nsf.c

Clone Tools
  • last updated 12 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
* nsf.c (GetNextArguments): Ensemble method names via the colon resolver were not cleansed for the colon, leading to a broken method lookup chain. Fix for SF Ticket #1. Added basic tests.

  1. … 1 more file in changeset.
fix: remove failing assertion, Tcl handles leading colons in proc names

* nsf.c, forward.test (ForwardArg): Extend to recognize alternative element separators in list string reps (NsfHasTclSpace).

  1. … 1 more file in changeset.
* nsf.c, nsf-cmd.test (ObjectFindMethod): Extend to recognize all element separator chars (NsfHasTclSpace).

  1. … 1 more file in changeset.
* nsf.c, parameters.test (NsfMethodSetterCmd): Make list detection aware of all list separator chars (NsfHasTclSpace).

  1. … 1 more file in changeset.
* nsf.c, parameters.test (NsfOResidualargsMethod): Extend XOTcl's list-notation support to recognize all Tcl list separators (NsfHasTclSpace).

  1. … 1 more file in changeset.
* nsf.c, nsfInt.h: Start housekeeping work on Tcl command/proc names vs. NSF method names to avoid conflicts between ensemle methods and e.g. whitespace-containing command names. Added helper macro NsfHasTclSpace and some first tests. To be continued.

  1. … 2 more files in changeset.
Reduce variable scope

* nsf.c (NsfMethodPropertyCmd,NsfForwardPropertyCmd): Remove extra whitespace from error message.

  1. … 1 more file in changeset.
Merge branch 'master' of ssh://alice.wu-wien.ac.at/usr/local/src/git-repo/nsf

* nsf.c (DispatchUnknownMethod): Sanitize messages emitted by default unknown handler. Unless in the context of an ensemble object (NSF_KEEP_CALLER_SELF, NSF_PER_OBJECT_DISPATCH), make sure that the entire method name, incl. multi-word names, are fully reported.

Simplify code

- Don't assume that CallStackGetTopFrame0() reurns != NULL - reduce variable scopes - reduce number of returns before function end

  1. … 3 more files in changeset.
Make sure, paramPtr is always initialized

- Use more straightforward Tcl idiom to access first character of a string - Standardize spelling of names of products (Tcl, AOLserver, PostgreSQL)

  1. … 10 more files in changeset.
- Use uniform spelling of "Tcl" - Fix more spelling errors

  1. … 18 more files in changeset.
Improve spelling

  1. … 43 more files in changeset.
- provide means to debug invalid coding in Tcl_Objs

* nsf.c (ArgumentCheck): Set parentheses correctly.

* nsf.c (ArgumentCheck): Avoid double dispatching to value checkers (built-in and type=*) for "slotset" parameters. Previously, configure and then the value=set (value=add) method triggered one dispatch each. Now, the configure pass skips the check and shifts sole responsibility on the value=set/ value=add methods. Added basic test cases to parameters.test to capture the intended call semantics.

  1. … 1 more file in changeset.
Fix potential bug in forwarder code (it was possible, that a subsituted %proc was freed to early)

- include all enum values in case statements

- use preprocessor variables more consistently

  1. … 1 more file in changeset.
- remove old-style function definitions

  1. … 1 more file in changeset.
- remove implicit conversion to 'unsigned int' from 'int' m

- ISO C90 forbids mixed declarations and code

- don't shadow local variable

Reduce memory consumption via better aligning (esp on 64bit machines)

  1. … 3 more files in changeset.
- don't shadow variables

  1. … 1 more file in changeset.
- removed unneeded arguments - mark unused arguments as UNUSED

  1. … 4 more files in changeset.