Activity nsf/

* nsf.c (GetObjectFromObj, TclDeletesObject): Remove two earlier fixes to deal with ::nsf::object::alloc failing under cmd deletion/recreation. The issue has been tackled more generally by a Tcl-side fix. Background: Since 2005 (commit fcb9ab1df3a9b2d1), in Tcl the cmdEpoch state in delete traces and delete callbacks (deleteProcs, destructors) has been compromised. Bumping the epoch of the cmd under deletion before executing the traces and callbacks had the potential of caching the cmd under in Tcl_Objs beyond its deletion (at least in our code path). In July 2017 (8.7a, commit 54fac92610d3bdd9), this potential realised by removing a guard expression (CMD_IS_DELETED) in the Tcl_Obj cache invalidation logic, which had protected from such invalid caches (as a side effect). As of today (8.7a, commit 71fa1f9c91), the underlying timing problem of epoch bumping has been resolved.

- -25
- +1
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c

12:08 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
bab0e88
changed 1 file
2-1-0-rc, 2.2 and 36 more

* nsf.c (TclDeletesObject): Provide an alternative fix to reflect the changed cache invalidation policy for Tcl_Obj cmd intrep in 8.7.

- -2
- +12
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c

11:35 am

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
69dd502
changed 2 files
CMD_IS_DELETED_REFORM

Save code instrumentation to demonstrate the problem

- -13
- +21
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c
- -8
- +20
/library/nx/nx.tcl
- History
- Source
- Diff
/library/nx/nx.tcl

1:08 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

More
75a78fb
changed 1 file
2-1-0-rc, 2.2 and 37 more

move the logic if Tcl_GetCommandFromObj() is returning an epoched obj to a more central place (GetObjectFromObj()) such it might kick in on other potential occasions as well.

- -30
- +39
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c

8:53 am

Gustaf Neumann <neumann@wu-wien.ac.at>

More
2d8f61f
changed 1 file
2-1-0-rc, 2.2 and 37 more

- fix text for Tcl 8.7

- -5
- +17
/tests/tcl86.test
- History
- Source
- Diff
/tests/tcl86.test

8:52 am

Gustaf Neumann <neumann@wu-wien.ac.at>

More
646eda3
changed 1 file
2-1-0-rc, 2.2 and 37 more

- use TclFreeIntRep() instead of direct function calls - perform TclFreeIntRep() for Class and Object creation under Tcl 8.7

- -14
- +16
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c

9:47 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

More
4ab0ae5
changed 1 file
2-1-0-rc, 2.2 and 37 more

fix for Tcl 8.7: - when recreating an nsf object in in tcl 8.7, we seem to have to invalidate the intrep, otherwise the new command is not picked up by a later Tcl_GetCommandFromObj()

- -15
- +46
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c

4:10 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
438e614
changed 1 file
2-1-0-rc, 2.2 and 37 more

* nsf.c (NsfMethodAliasCmd): Tcl 8.7 is more picky about typePtr and intrep being in line. We need to NULL the typePtr explicitly. TclFreeIntRep does so for us as good Tcl citizens, rather than setting bodyObj->typePtr == NULL directly.