nsf

tests

Clone Tools

Stats

Commits this week: 0
Total Committers: 10
Last Commit: 14 Oct
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 15 Jul 2011
5:23 pm

ssoberni <stefan.sobernig@wu-wien.ac.at>

- generic/nsf.c: Fixed [current callingmethod] for submethods (i.e., reporting submethods as calling methods, including their methodpath). Added tests covering the fix (see tests/submethods.test). - generic/nsfStack.c (CallStackMethodPath): Re-arranged the traversal slightly, to escape non-ensemble frames (eval CFRAMEs) as parts of the method path. Added test (see tests/submethods.test). - library/nx/nx.tcl: Corrected the impl of Ensemble->defaultmethod() (e.g., used self instead of current) - tests/disposition.test: Fixed test cases turned out to be false positives. Before the fixes, [current methodpath] gave non-empty results for simple object aliases.

Options
    • -8
    • +11
    ./disposition.test
    • -2
    • +50
    ./submethods.test
  3. … 3 more files in changeset.
1:30 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- provide error message, when method variable is a noop (e.g. no value provided and no accessor is wanted)

Options
    • -2
    • +4
    ./parameters.test
  2. … 2 more files in changeset.
1:08 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- added support for "class variable" - added tests for "variable" + multiplicity and "class variable"

Options
    • -0
    • +28
    ./parameters.test
  2. … 2 more files in changeset.
12:26 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- nx::Attribute: changed method 'checkInstVar' to 'setCheckedInstVar' - set only fresh variables via per-object method "variable" and "attribute" - added flag -concomplain to per-object method "variable" and "attribute" - extended regression test

Options
    • -4
    • +11
    ./parameters.test
  2. … 2 more files in changeset.
Thursday 14 Jul 2011
1:54 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- add reference value in tests, update TODO

Options
    • -0
    • +4
    ./parameters.test
  2. … 1 more file in changeset.
1:45 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- nx: factor out method createFromParameterSpec - method variable: * check default value * added shortcut, when no slot object is needed * extended regression test

Options
    • -35
    • +62
    ./parameters.test
  2. … 2 more files in changeset.
11:40 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- generalized "nsf::object::initialized" to nsf::object::property objectName initialized|class|rootmetaclass|rootclass|slotcontainer

Options
    • -3
    • +3
    ./object-system.test
  2. … 4 more files in changeset.
9:18 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- regularized more nsf::* names: renamed "nsf::createobjectsystem" => "nsf::objectsystem::create" renamed "nsf::unknown" => "nsf::object::unknown" renamed "nsf::dispatch" => "nsf::object::dispatch"

Options
    • -2
    • +2
    ./doc.test
    • -1
    • +1
    ./method-require.test
    • -13
    • +13
    ./methods.test
    • -10
    • +10
    ./object-system.test
    • -11
    • +11
    ./parameters.test
    • -4
    • +4
    ./protected.test
  7. … 12 more files in changeset.
Wednesday 13 Jul 2011
2:51 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- first draft of separation of attribute -> variable + accessor

Options
    • -1
    • +1
    ./disposition.test
    • -2
    • +2
    ./info-method.test
  3. … 3 more files in changeset.
11:39 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- reamed ObjectParameterSlot attribute from nosetter => accessor (positive formulation)

Options
    • -1
    • +1
    ./parameters.test
  2. … 3 more files in changeset.
Monday 11 Jul 2011
4:28 pm

ssoberni <stefan.sobernig@wu-wien.ac.at>

- tests/parameters.test: Tracked down the relevant Tcl issue (fossil check-in 769801ace1) resulting in the bignum double-rounding problem, observed earlier. The work-around is setting the tcl precision level to 17. I made it applying conditionally, depending on the Tcl patch level as the work-around is not needed anymore fore 8.5.10+. - generic/nsf.c: Correct usage of TclDumpMemoryInfo() for changes in 8.5.10, introduced by fossil check-in 4a9ba46064. Memdebug builts (--enable-symbols=mem) therefore require a recent Tcl version (8.5.10+).

Options
    • -1
    • +19
    ./parameters.test
  2. … 1 more file in changeset.
10:03 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- provide backward compatibility for unknwon method (when method contains spaces). - some minor cleanup - extended regression test

Options
    • -0
    • +32
    ./methods.test
  2. … 2 more files in changeset.
Friday 08 Jul 2011
9:24 pm

ssoberni <stefan.sobernig@wu-wien.ac.at>

- TODO: Added an entry concerning callstack introspection (as discussed today) - generic/nsf.c: Some minor renaming in NsfOConfigureMethod(); made sure that intermediate frames resulting from forward-parameter dispatches are equally marked INACTIVE. - tests/disposition.test: Added tests covering uplevel/upvar support under parameter/disposition dispatches (i.e., uplevel and upvar calls from within parameter-dispatched methods); the tests also cover XOTcl's residualargs dispatches.

Options
    • -7
    • +150
    ./disposition.test
    • -1
    • +1
    ./volatile.test
  3. … 2 more files in changeset.
Wednesday 06 Jul 2011
5:54 pm

ssoberni <stefan.sobernig@wu-wien.ac.at>

Squashed commit of the following:

commit 901efa4cb4e1bbd55a8c47ebb79f4c7b4b397668

Author: ssoberni <stefan.sobernig@wu-wien.ac.at>

Date: Wed Jul 6 17:51:38 2011 +0200

- generic/nsf.c: Provide the [current class] context to submethods

- tests/disposition.test: Added some tests on the interaction of

INACTIVE frames (mixin, filter) and submethods

- tests/submethods.test: Testing [current class] context for submethods

Options
    • -3
    • +149
    ./disposition.test
    • -0
    • +43
    ./submethods.test
  3. … 2 more files in changeset.
Tuesday 05 Jul 2011
7:19 pm

ssoberni <stefan.sobernig@wu-wien.ac.at>

- generic/nsfStack.c: Revised my former patch for traversing callstacks under ensemle dispatches. We fixed the traversal-ending gateway expression; and added transparency for INACTIVE frames when assembling the method path. Added further tests, remain to be completed ...

Options
    • -3
    • +132
    ./disposition.test
  2. … 2 more files in changeset.
9:41 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- preliminary fix for volatile called through redsidual args - new regression test file volatile.test

Options
    • -0
    • +85
    ./volatile.test
  2. … 4 more files in changeset.
9:09 am

ssoberni <stefan.sobernig@wu-wien.ac.at>

- Reduced verbosity in nsf.c, reactivated a test case

Options
    • -1
    • +2
    ./disposition.test
  2. … 1 more file in changeset.
Monday 04 Jul 2011
9:21 pm

ssoberni <stefan.sobernig@wu-wien.ac.at>

- tests/forward.test, tests/methods.test: Remove some intermediary statements

Options
    • -2
    • +1
    ./forward.test
    • -1
    • +0
    ./methods.test
9:04 pm

ssoberni <stefan.sobernig@wu-wien.ac.at>

- nsfStack.c / CallStackMethodPath(): Providing a fix for reporting method paths correctly when dispatching to ensembles from alias parameters. Prior to that fix, the intermediate (and inactive) CMETHOD frame wrapping configure() calls caused [current methodpath]s to report empty string elements. Added some test cases. - nsf.c / ObjectDispatch(), DispatchUnknownMethod(): When testing objects as alias parameter targets, I found cases when the default (C-level) unknown handler was invoked upon. The result was an unknown message which reported the delegator object as "unknown" method! This was due to injecting the delegator object into the argument vector at position 0, subsequently used by the C-level unknown handler. First, I tried to make the C-level unknown handler aware of the ensemble call context (by funneling through the CSC and frame flags) but this turned out to be complicated to achieve this simple task. As an alternative, I suggest the following patch: The first argument in unknown calls is treated as a list, and dependening on the call context (ensemble vs. non-ensemble) contains all the necessary call data. For ensemble methods, it is the delegator object, the entire method path (as returned by [current methodpath]), and the actual unknown selector. The default C-level handler, treating the call info as list, resorts to reporting the last element of the list which is always the unknown selector. Custom (ensemble-level, application-level) unknown handler can wrap and further process the information as necessary. To demonstrate the usefulness, I rewrote EnsembleObject->unknown() accordingly. I checked for Tcl_Obj leaks. - Added some tests on objects as targets of alias object parameter. To be continued.

Options
    • -2
    • +197
    ./disposition.test
    • -2
    • +3
    ./forward.test
    • -0
    • +1
    ./methods.test
  4. … 4 more files in changeset.
Thursday 30 Jun 2011
12:43 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- nsf.c: * report only fully initialized slot objects via "info slots" to avoid chicken-egg problem during method "objectparameter" * added flag -array to ::nsf::var::exists to check, whether the variable is an array (to avoid "o eval {array exists ...}" in the serializer. * provided flags to VarExists instead of multiple args * don't add new pointer entries in Nsf_PointerTypeLookup()

Options
    • -1
    • +1
    ./disposition.test
    • -0
    • +38
    ./parameters.test
  3. … 8 more files in changeset.
Wednesday 29 Jun 2011
12:22 pm

ssoberni <stefan.sobernig@wu-wien.ac.at>

- tests/parameters.test: Slight extension of test case on a re-assignment of per-ob defaults.

Options
    • -7
    • +18
    ./parameters.test
11:28 am

ssoberni <stefan.sobernig@wu-wien.ac.at>

- library/nx/nx.tcl: Fixed Attribute->reconfigure() to cover the reconfiguration of a default value in the per-object case ... - tests/parameters.test: Added Victor Mayevski's example as a proper test case. Details need to be discussed ...

Options
    • -0
    • +20
    ./parameters.test
  2. … 1 more file in changeset.
9:57 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- C-code generator: * additional parameter swith "-withObj" to allow passing of internal representation and the according TclObj * * c-implemented methods: report types in "info parameter" for more builtin types. * use "-withObj" in mongodb interface * adapted regression test

Options
    • -0
    • +3
    ./info-method.test
    • -1
    • +1
    ./parameters.test
  3. … 8 more files in changeset.
Tuesday 28 Jun 2011
12:21 pm

ssoberni <stefan.sobernig@wu-wien.ac.at>

- generic/nsf.c: Shuffled around the word order and adding some quoting in the error message for enforcing multivalued, non-empty list multiplicities; to differentiate between parameter name and value literals etc.

Options
    • -3
    • +1
    ./disposition.test
    • -1
    • +1
    ./parameters.test
  3. … 1 more file in changeset.
3:34 am

ssoberni <stefan.sobernig@wu-wien.ac.at>

- tests/disposition.test: Added tests covering "dispos vs. return checker" and "dispos vs. uplevel/upvar"

Options
    • -13
    • +123
    ./disposition.test
Monday 27 Jun 2011
10:24 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- nsf.c: no good reason to disallow user defined types for for alias, forward or initcmd

Options
    • -5
    • +26
    ./disposition.test
  2. … 2 more files in changeset.
5:47 pm

ssoberni <stefan.sobernig@wu-wien.ac.at>

- generic/nsf.c: Aligned error messages for parameter options; Re-arranged control flow in ParamOptionParse() slightly, do allow for [string is] types being used as options of disposition types. Refactored code slightly (e.g., removed unneeded, intermediary Tcl_Objs). - tests/disposition.test: Extended test suite, in particular, for covering multiplicity types as parameter options of disposition types. - tests/parameters.test: Adjusting for rephrased error messages.

Options
    • -21
    • +93
    ./disposition.test
    • -1
    • +1
    ./parameters.test
  3. … 1 more file in changeset.
12:34 pm

ssoberni <stefan.sobernig@wu-wien.ac.at>

- tests/parameters.test: Setting the precision to 17 explicitly (otherwise, comparison operations might fail due to deviating precision levels)

Options
    • -0
    • +1
    ./parameters.test
9:51 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- nsf.c: * Don't output non-consuming procs (which are always called) via parametersyntax (shows, what a user can input) * additional command ::nsf::object::initialized to check whether an object is already initialized * new function DispatchInitMethod() similar to DispatchDefaultMethod() * let residualargs call init directly instead of doing it the inidrect way * provided ability to call init with object parameters at arbitrary times * switch from Tcl_ObjCmdProc style interface (ClientData first) to a C stype interface for DispatchDefaultMethod(), DispatchUnknownMethod() * bring cmd definitions for nsf::object in right order - extended regression test

Options
    • -1
    • +54
    ./disposition.test
    • -0
    • +7
    ./object-system.test
    • -8
    • +12
    ./parameters.test
    • -14
    • +29
    ./protected.test
  5. … 6 more files in changeset.
Friday 24 Jun 2011
12:38 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- nsf.c: * added refcounting to parameter definitions (needed, when aliased object parameter redefined the actual objectparameters) * removed hardcoded call to remaining args * switched implentation of xotcl2 to use object parameter with parameter option "args" * removed residualargs from object system definition * extended regression test

Options
    • -5
    • +16
    ./disposition.test
  2. … 5 more files in changeset.