nsf

tests

Clone Tools

Stats

Commits this week: 0
Total Committers: 10
Last Commit: 14 Oct
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 11 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 31 Jul 2012
2:49 pm

ssoberni <stefan.sobernig@wu-wien.ac.at>

Adding a test case and a preliminary fix for the parameter option interactions

Options
    • -0
    • +17
    ./parameters.test
  2. … 1 more file in changeset.
Wednesday 18 Jul 2012
10:54 am

Gustaf Neumann <neumann@wu-wien.ac.at>

nsf.c: - ignore in internall calls to "dealloc" protection settings - handle cyclical class dependencies during object system finalize - extend regression test

Options
    • -1
    • +21
    ./destroy.test
  2. … 2 more files in changeset.
1:55 am

Stefan Sobernig <stefan.sobernig@wu-wien.ac.at>

- library/nx/nx.tcl: Following the code review, implemented a first scheme for handling traces in setCheckedInstVar. This gives us consistent behavior for defaults and traces (valuechangedcmd) across classes and objects. - tests/parameters.test: Adjusted the relevant tests - Pending: setCheckedInstVar currently uses ::nsf::is to validate the value (e.g., default value) to be set. However, it might get passed parameter options which do not fit the NSF_DISALLOWED_ARG_VALUECHECKED filter.

Options
    • -9
    • +2
    ./parameters.test
  2. … 1 more file in changeset.
Tuesday 17 Jul 2012
12:24 am

ssoberni <stefan.sobernig@wu-wien.ac.at>

- Addressed a number of issues in the NX slot infrastructure (which revealed themselves when running Mark's BusinessActivities implementation in XOTcl2 mode): - generic/nsf.c: Initcmd blocks (as set for registering per-class slot traces) were subjected to argument checks causing unexpected behavior (e.g., attempts of unboxing initcmds as Tcl lists or of checking initcmds against value types). This was fixed by exempting NSF_ARG_INITCMD params from argument checking in ArgumentCheck() explicitly. - library/nx/nx.tcl: For per-class parameters, the use of valuechangedcmd effectively overruled the default value specified (simply because the generated initcmd holding the trace statements took the place of the default value). While for defaultcmd and for valuecmd the parallel use of default is forbidden, the valuechangedcmd semantics allow for specifying a default, in principle. This was fixed by providing a default-setting statement in the initcmd. - tests/parameters.test: Added tests to cover the above (and beyond). - library/xotcl/library/xotcl2.tcl: Extended the backwards compatibility of the hybrid XOTcl2/NX slots infrastructure to the XOTcl 1 interface: This includes support for inline -proc statements and instvar. This compat level corresponds to the slot interface as documented (by examples) in the XOTcl language ref and the manual. - library/xotcl/tests/slottest.xotcl: Added tests for the above compat enhancements.

Options
    • -0
    • +135
    ./parameters.test
  2. … 4 more files in changeset.
12:22 am

ssoberni <stefan.sobernig@wu-wien.ac.at>

The BA examples are operative

Options
    • -3
    • +21
    ./parameters.test
  2. … 1 more file in changeset.
Monday 16 Jul 2012
2:56 pm

ssoberni <stefan.sobernig@wu-wien.ac.at>

Most issues resolved, however, the ordering of default vs. traces is pending

Options
    • -0
    • +117
    ./parameters.test
  2. … 4 more files in changeset.
Wednesday 27 Jun 2012
1:21 am

ssoberni <stefan.sobernig@wu-wien.ac.at>

- Replaced errorneous check using the object-specific rather than the class-specific options in the query mode of ::nsf::relation with class-filter. This prevented [::nsf::relation /cls/ class-filter] from returning any filter info. As a consequence, the incremental interface of the filter slot failed (e.g., [/cls/ filter add aFilterProc] effectively reset the class-filter cmd list instead of adding to it). Thx are due to Markus Moldaschl for reporting the issue. - Aligning class-filter and object-filter behaviour on errors during filter additions to the state-preserving behaviour of object-mixin and class-mixin. - Adding basic tests on object-filter/class-filter (::nsf::relation, filter slot interface) and specific ones to cover the above issues.

Options
    • -1
    • +1
    ./info-method.test
    • -0
    • +56
    ./interceptor-slot.test
  3. … 1 more file in changeset.
1:18 am

ssoberni <stefan.sobernig@wu-wien.ac.at>

Adding basic tests on object-filter/class-filter; and specific ones to cover the class-filter issue

Options
    • -1
    • +1
    ./info-method.test
    • -0
    • +56
    ./interceptor-slot.test
Monday 25 Jun 2012
11:48 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- added a SlotContainerCmdResolver() to avoid interaction of slot names with names of callable tcl commands. Without the SlotContainerCmdResolver() the call to "list" in a property named "list" leads to a call to the container object ::Test2::slot::list instead to the intended ::list. The implementation is not perfect, since it ignores the namespace path inside the slot container. - added regression test.

Options
    • -0
    • +23
    ./parameters.test
  2. … 2 more files in changeset.
Friday 01 Jun 2012
12:01 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

nsfShadow.c - bump MethodEpoch when a tcl ::rename command happens on a nsf method (which might be cached in a Tcl_Obj) This fixes a crash reported by Arthur Schreiber nsf.c: - make NsfInstanceMethodEpochIncr() and NsfObjectMethodEpochIncr() accessible from all files using nsfInt.h - remove experimental code (backslash escaping for "," in parameter option parse

Options
    • -0
    • +52
    ./destroy.test
  2. … 4 more files in changeset.
Tuesday 22 May 2012
10:33 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- document private properties in tutorial and migration guide - improve wording in documenting - extend regression test

Options
    • -1
    • +63
    ./protected.test
  2. … 5 more files in changeset.
Monday 21 May 2012
11:22 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- minor polishing

Options
    • -1
    • +8
    ./protected.test
Monday 14 May 2012
12:41 pm

ssoberni <stefan.sobernig@wu-wien.ac.at>

- generic/nsf.c, ObjectDispatch(): Re-arranged the handling of fully-qualified method dispatches with the selectors resolving to existing objects and, in particular, nested (namespace-qualified) objects. Prior to that, dispatches such as "::C ::parent::child" were not covered appropriately: ::parent was reported as valid regObj and so the dispatcher continued to dispatch to the cmd "::parent::child" in the self-context ::parent::child ... with unwanted side-effects (e.g., XOTcl's unknown handling was bypassed). - tests/methods.test: Added basic tests on the (current) handling for such ::* dispatches and a specific test set on the intended XOTcl behaviour.

Options
    • -0
    • +114
    ./methods.test
  2. … 1 more file in changeset.
Sunday 13 May 2012
10:19 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- start error messages with a lower case word for consistency and to follow closer to Tcl's conventions

Options
    • -3
    • +3
    ./methods.test
    • -4
    • +4
    ./parameters.test
    • -0
    • +110
    ./protected.test
    • -15
    • +15
    ./submethods.test
    • -2
    • +2
    ./tcloo.test
  6. … 2 more files in changeset.
Friday 11 May 2012
11:48 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- implement escaping for comma in value of parameter options: escaping in values can be achived via duplicating the comma. - extend regression test

Options
    • -6
    • +54
    ./parameters.test
  2. … 2 more files in changeset.
Friday 20 Apr 2012
12:05 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- explorative implementation of object method dispatches with KEEP_CALLER_SELF and no NSF_PER_OBJECT_DISPATCH - extend regression test

Options
    • -7
    • +14
    ./submethods.test
  2. … 2 more files in changeset.
Monday 16 Apr 2012
12:45 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- remove debug line

Options
    • -1
    • +0
    ./submethods.test
Wednesday 11 Apr 2012
12:11 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- add regression test for keepcallerself with and without perobjectdispatch

Options
    • -0
    • +65
    ./submethods.test
Tuesday 10 Apr 2012
6:58 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- serializer: * pertain perobjectdispatch and keepcallerself in serializer * extend regression test

Options
    • -0
    • +38
    ./serialize.test
  2. … 2 more files in changeset.
3:13 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- serializer: * make [::Serializer deepSerialize -ignoreVarsRE "" $o] behave like [::Serializer deepSerialize $o], since learn@wu depends on that, and a value for ignoreVarsRE of empty looks more like an omitted value than a regular expression, that should match everything. * extended regression test

Options
    • -4
    • +6
    ./serialize.test
  2. … 2 more files in changeset.
2:24 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- extended regression test

Options
    • -0
    • +16
    ./object-system.test
Monday 05 Mar 2012
1:44 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- tcl86.test: better implementation of method "each", cleanup and extension of enumerator tests

Options
    • -28
    • +35
    ./tcl86.test
  2. … 1 more file in changeset.
Wednesday 29 Feb 2012
3:14 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- extended regression tests for yield - implemented "next" for ruby-like enumerators (each needs still more work)

Options
    • -3
    • +167
    ./tcl86.test
  2. … 1 more file in changeset.
Monday 27 Feb 2012
12:25 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- pass property name to slot "initialize" method to conform with the interface to "assign", "get" ... (all these receive the property name as well) - allow slot "initialize" method to be protected (handled similarly to "init")

Options
    • -1
    • +1
    ./parameters.test
    • -1
    • +1
    ./varresolution.test
  3. … 2 more files in changeset.
Friday 24 Feb 2012
7:56 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

nsf.c: - added object parameter option "slotinitialize" - renamed object parameter option "invokesetter" -> "slotassign" - call slot.assign instead of setter of object - removed restriction on nosetter/invokesetter: nosetter can be used in connection with slotassign - added regression test for slot.initialize

Options
    • -5
    • +35
    ./parameters.test
  2. … 4 more files in changeset.
Wednesday 22 Feb 2012
9:48 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- Fixed a bad interaction between Tcl's apply (pushing lambda frames) and the variable resolvers. The variable resolver was not able to resolve variables, while the command resolver was still working correctly. - Extended regression test

Options
    • -0
    • +85
    ./varresolution.test
  2. … 2 more files in changeset.
Friday 17 Feb 2012
4:35 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- improve error message to indicate, that nsf refuses to overwrite (redefine) some cmds

Options
    • -7
    • +7
    ./protected.test
    • -1
    • +1
    ./submethods.test
  3. … 1 more file in changeset.
12:13 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- don't allow method to overwrite child object - extended regression test - documented new feature as incompatibility with XOTcl 1

Options
    • -0
    • +18
    ./object-system.test
  2. … 4 more files in changeset.
Thursday 16 Feb 2012
10:15 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- don't allow object creation to overwrite non-object cmds (e.g. procs)

Options
    • -3
    • +4
    ./destroy.test
    • -0
    • +19
    ./object-system.test
    • -3
    • +3
    ./submethods.test
  4. … 3 more files in changeset.
2:22 pm

ssoberni <stefan.sobernig@wu-wien.ac.at>

- tests/serialize.test: Added some basic regression tests, in particular to challenge the filter options provided by Serializer->deepSerialize() and Serializer->all(). - Included a test for commit 595e6a2. - Along the line, two minor issues where fixed: 1) Set Serializer->ignore() to public, otherwise the various external message sends to this method would fail; 2) Object-serialize() did not distinguish between serialising a per-object or per-class container properly; as a consequence, per-object containers were not restored at all. Add a test covering this.

Options
    • -0
    • +167
    ./serialize.test
  2. … 2 more files in changeset.