Activity nsf/

11:56 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
ea63ea3
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

* nsf.c (NsfDebugGetDict): Make use of strncat more robust by setting the destingation length to the remainder of the output buffer.

- -3
- +5
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c

10:35 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
500a581
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

* nsf.c (ForwardArg): Provide a const'ed pointer to strpbrk, as required [CID 294162].

- -5
- +6
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c

10:15 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
b3e820b
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

* nsf.c (ParamDefsFormat): Fix overrun in memcpy by correcting the destination-length argument [CID 294165].

- -1
- +1
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c

12:39 am

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
bec5f06
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

* nsf.c: Fix all "-pedantic -ansi" errors.

- -47
- +55
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c

5:49 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
1a486b9
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

* nsf.c (ParamDefsStore, NsfProcDeleteProc): Provide for counting a reference to the execNsPtr from the NsfProcContext structure. While I could not devise a script-level path to pull out the rug (execNsPtr) out from under NsfProcContext clients, I can only also not exclude the latter (from future C-level paths?). Better act defensively.

- -2
- +11
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c

12:53 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
d96dedf
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

* nsfInt.h (STRING_NEW): Silence GCC 8.1 warnings on truncation risk using strncpy; made me wonder whether STRING_NEW would not be more robust against mis-computations of the destination-buffer length by using snprintf (mainly because snprintf does not nul-pad the destination buffer and always nul-terminates the destination buffer)?

- -1
- +1
/generic/nsfInt.h
- History
- Source
- Diff
/generic/nsfInt.h

1:49 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
bf61b8a
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

* parameters.test: Adding two test cases to cover previously missed code branches leading to leaking NsfMethodNamePath uses.

- -0
- +15
/tests/parameters.test
- History
- Source
- Diff
/tests/parameters.test

10:35 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
6042ab0
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

* nsf.c (ArgumentParse): Handle NsfMethodNamePath result correctly.

- -8
- +11
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c

10:34 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
76da430
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

* nsf.c (NsfSetterMethod): Handle NsfMethodNamePath result correctly.

- -2
- +6
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c

4:05 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
424b6e1
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

* nsf.c (ObjectCmdMethodDispatch): Close another Tcl_Obj leak incurred by not handling the result from NsfMethodNamePath.

- -1
- +13
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c

2:42 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
87bc503
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

* nsf.c (FindNextMethod): Plumb another memleak (valgrind). The Tcl_Obj computed by NsfMethodNamePath must be refcount corrected.

- -2
- +5
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c

2:39 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
31c114e
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

* nsf.c (AliasGet): Plumbing a memleak found by valgrind. The computed Tcl_Obj from AliasIndex must be refcount-managed explicitly, otherwise the path via AliasGet leaks it.

- -9
- +22
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c

5:55 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
611f73c
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

Fix makefile.vc syntax [skip travis]

- -2
- +2
/win/makefile.vc
- History
- Source
- Diff
/win/makefile.vc

5:45 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
f5ff0c4
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

Re-code env variable dimension of build matrix

- -12
- +11
/appveyor.yml
- History
- Source
- Diff
/appveyor.yml

5:41 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
9eda698
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

Fix appveyor.yml syntax

- -4
- +8
/appveyor.yml
- History
- Source
- Diff
/appveyor.yml

5:39 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
900390c
changed 3 files
2.2, 2.2.0-repro-patch and 19 more

Necessary additions to build script and NMAKE/TEA artifacts

- -4
- +5
/apps/build.tcl
- History
- Source
- Diff
/apps/build.tcl
- -39
- +29
/win/makefile.vc
- History
- Source
- Diff
/win/makefile.vc
- -326
- +1415
/win/rules.vc
- History
- Source
- Diff
/win/rules.vc

5:20 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
d78609d
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

appveyor.yml: Add TOOLCHAIN dimension to incorporate MSVC builds

- -6
- +14
/appveyor.yml
- History
- Source
- Diff
/appveyor.yml

12:07 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
49ae7bc
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

per-object-mixins.tcl: Fix an example script that got broken a long, long time ago. [skip ci]

- -5
- +6
/doc/example-scripts/per-object-mixins.tcl
- History
- Source
- Diff
/doc/.../per-object-mixins.tcl

4:02 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
f848dc5
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

Fix build.tcl pt. 2 [skip ci]

- -1
- +2
/apps/build.tcl
- History
- Source
- Diff
/apps/build.tcl

3:55 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
ae03d54
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

Fix build.tcl [skip ci]

- -0
- +1
/apps/build.tcl
- History
- Source
- Diff
/apps/build.tcl

3:50 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
457f8a8
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

Add nmake mode to build.tcl [skip ci]

- -9
- +21
/apps/build.tcl
- History
- Source
- Diff
/apps/build.tcl

11:25 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
9e5f074
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

Add allowed failures to Travis setup [skip appveyor]

- -0
- +7
/.travis.yml
- History
- Source
- Diff
/.travis.yml

5:14 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
f718572
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

Set allowed failures on Tcl development branches; report failure on first failing build [skip travis]

- -0
- +6
/appveyor.yml
- History
- Source
- Diff
/appveyor.yml

2:20 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
8a1a43a
changed 2 files
2.2, 2.2.0-repro-patch and 19 more

* nsf.c (ParamOptionParse), nsfInt.h: Provide for own MAX and MIN macros, the ones reused implicitly from Tcl's tommath have vanished in 8.7 branches; and are not provided otherwise, at least in MinGW settings. Fixes 8.7 builds for MinGW under Win.