Activity OpenACS/

8:19 pm

gustafn

- modernize tcl

- brace expressions

- flatten nested "lindex" structures

- use tcl 8.5 extended index format for "lrange"

- -57
- +57
/openacs-4/packages/oacs-dav/tcl/oacs-dav-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../oacs-dav-procs.tcl
- -45
- +45
/openacs-4/packages/oacs-dav/tcl/tDAV-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/tDAV-procs.tcl
- -5
- +5
/openacs-4/packages/oacs-dav/tcl/test/oacs-dav-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../oacs-dav-procs.tcl

8:12 pm

gustafn

- flatten nested "lindex" structures

- -2
- +2
/openacs-4/packages/notifications/www/request-new.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/request-new.tcl
- -1
- +1
/openacs-4/packages/notifications/www/request-notification.tcl
- History
- Source
- Diff
/openacs-4/.../request-notification.tcl

7:19 pm

gustafn

- use numeric comparison operator for truth value comparisons

- -2
- +2
/openacs-4/packages/news/lib/item.tcl
- History
- Source
- Diff
/openacs-4/packages/news/lib/item.tcl
- -4
- +4
/openacs-4/packages/news/tcl/test/news-db-test-init.tcl
- History
- Source
- Diff
/openacs-4/packages/.../news-db-test-init.tcl
- -2
- +2
/openacs-4/packages/news/www/item-create-3.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/item-create-3.tcl
- -2
- +2
/openacs-4/packages/news/www/admin/approve-2.tcl
- History
- Source
- Diff
/openacs-4/packages/.../admin/approve-2.tcl
- -2
- +2
/openacs-4/packages/news/www/admin/revision-add-3.tcl
- History
- Source
- Diff
/openacs-4/packages/.../revision-add-3.tcl

7:16 pm

gustafn

- remove uneeded and broken file

- -5
- +0
/openacs-4/packages/news/www/news.adp
- History
- Source
- Diff
/openacs-4/packages/news/www/news.adp
- -4
- +0
/openacs-4/packages/news/www/news.tcl
- History
- Source
- Diff
/openacs-4/packages/news/www/news.tcl

2:08 pm

gustafn

- flatten nested "lindex" structures

- use numeric comparison operator for truth value comparisons

- use "lassign" instead of multiple "lindex" operations

- -2
- +2
/openacs-4/packages/categories/lib/categorize.tcl
- History
- Source
- Diff
/openacs-4/packages/.../lib/categorize.tcl
- -3
- +3
/openacs-4/packages/categories/lib/list-categories.tcl
- History
- Source
- Diff
/openacs-4/packages/.../list-categories.tcl
- -2
- +2
/openacs-4/packages/categories/lib/map.tcl
- History
- Source
- Diff
/openacs-4/packages/.../lib/map.tcl
- -5
- +5
/openacs-4/packages/categories/tcl/category-trees-procs.tcl
- History
- Source
- Diff
/openacs-4/.../category-trees-procs.tcl
- -1
- +1
/openacs-4/packages/categories/tcl/tagcloud-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tagcloud-procs.tcl
- -16
- +18
/openacs-4/packages/categories/tcl/widget-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/widget-procs.tcl
- -2
- +2
/openacs-4/packages/categories/www/categories-browse.tcl
- History
- Source
- Diff
/openacs-4/packages/.../categories-browse.tcl

1:49 pm

gustafn

- flatten nested "lindex" structures

- -3
- +3
/openacs-4/packages/calendar/www/cal-item-new.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/cal-item-new.tcl
- -2
- +2
/openacs-4/packages/calendar/www/view.tcl
- History
- Source
- Diff
/openacs-4/packages/calendar/www/view.tcl

1:44 pm

gustafn

- flatten nested "lindex" structures

- use "lassign" instead of multiple "lindex" operations

- -6
- +5
/openacs-4/packages/acs-subsite/www/permissions/grant.tcl
- History
- Source
- Diff
/openacs-4/packages/.../permissions/grant.tcl

1:43 pm

gustafn

More
oacs-5-8:gustafn:20131011114346
changed 13 files
oacs-5-8

- flatten nested "lindex" structures

- use numeric comparison operator for truth value comparisons

- -3
- +3
/openacs-4/packages/acs-admin/tcl/apm-admin-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../apm-admin-procs.tcl
- -2
- +2
/openacs-4/packages/acs-admin/www/send-email.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/send-email.tcl
- -4
- +4
/openacs-4/packages/acs-admin/www/apm/index.tcl
- History
- Source
- Diff
/openacs-4/packages/.../apm/index.tcl
- -2
- +2
/openacs-4/packages/acs-admin/www/apm/package-delete.tcl
- History
- Source
- Diff
/openacs-4/packages/.../package-delete.tcl
- -2
- +2
/openacs-4/packages/acs-admin/www/apm/packages-install-2.tcl
- History
- Source
- Diff
/openacs-4/.../packages-install-2.tcl
- -2
- +2
/openacs-4/packages/acs-admin/www/apm/parameter-add-2.tcl
- History
- Source
- Diff
/openacs-4/packages/.../parameter-add-2.tcl
- -2
- +2
/openacs-4/packages/acs-admin/www/apm/parameter-delete.tcl
- History
- Source
- Diff
/openacs-4/packages/.../parameter-delete.tcl
- -2
- +2
/openacs-4/packages/acs-admin/www/apm/parameter-edit-2.tcl
- History
- Source
- Diff
/openacs-4/packages/.../parameter-edit-2.tcl
- -2
- +2
/openacs-4/packages/acs-admin/www/apm/version-dependencies.tcl
- History
- Source
- Diff
/openacs-4/.../version-dependencies.tcl
- -6
- +6
/openacs-4/packages/acs-admin/www/apm/version-files.tcl
- History
- Source
- Diff
/openacs-4/packages/.../apm/version-files.tcl
- -2
- +2
/openacs-4/packages/acs-admin/www/apm/version-parameters.tcl
- History
- Source
- Diff
/openacs-4/.../version-parameters.tcl
- -5
- +5
/openacs-4/packages/acs-admin/www/apm/version-view.tcl
- History
- Source
- Diff
/openacs-4/packages/.../apm/version-view.tcl
- -1
- +1
/openacs-4/packages/acs-admin/www/auth/authority-set-enabled-p.tcl
- History
- Source
- Diff
/openacs-4/.../authority-set-enabled-p.tcl

1:11 pm

gustafn

- flatten nested list structures

- -1
- +1
/openacs-4/packages/acs-subsite/lib/login.tcl
- History
- Source
- Diff
/openacs-4/packages/.../lib/login.tcl
- -2
- +2
/openacs-4/packages/acs-subsite/tcl/group-type-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../group-type-procs.tcl
- -1
- +1
/openacs-4/packages/acs-subsite/www/admin/subsite-add.tcl
- History
- Source
- Diff
/openacs-4/packages/.../admin/subsite-add.tcl
- -3
- +3
/openacs-4/packages/acs-subsite/www/permissions/grant.tcl
- History
- Source
- Diff
/openacs-4/packages/.../permissions/grant.tcl
- -2
- +2
/openacs-4/packages/acs-subsite/www/register/recover-password.tcl
- History
- Source
- Diff
/openacs-4/packages/.../recover-password.tcl

1:08 pm

gustafn

- fix empty string in compiled expression

- -4
- +6
/openacs-4/packages/acs-datetime/tcl/acs-datetime-procs.tcl
- History
- Source
- Diff
/openacs-4/.../acs-datetime-procs.tcl

12:39 pm

gustafn

More
MAIN:gustafn:20131011103937
changed 1 file
MAIN

- prettify output

- -5
- +15
/openacs-4/packages/download/www/index.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/index.tcl

12:29 pm

gustafn

More
MAIN:gustafn:20131011102931
changed 3 files
MAIN

- use numeric comparison operator for truth value comparisons

- -3
- +3
/openacs-4/packages/download/tcl/download-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../download-procs.tcl
- -2
- +2
/openacs-4/packages/download/www/archive-add-2.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/archive-add-2.tcl
- -2
- +2
/openacs-4/packages/download/www/index.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/index.tcl

12:28 pm

gustafn

More
MAIN:gustafn:20131011102828
changed 2 files
MAIN

- commit modifications from openacs.org

- -4
- +4
/openacs-4/packages/download/www/index.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/index.tcl
- binary
/openacs-4/packages/download/www/graphics/download-button.png
- History
- Source
/openacs-4/packages/.../download-button.png

12:17 pm

gustafn

- don't abbreviate subcommands of "file"

- flatten nested lindex structures

- -4
- +4
/openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
- History
- Source
- Diff
/openacs-4/.../throttle_mod-procs.tcl
- -2
- +2
/openacs-4/packages/xotcl-request-monitor/www/last-requests.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/last-requests.tcl

12:14 pm

gustafn

- flatten nested lindex structures

- -2
- +2
/openacs-4/packages/xowiki/tcl/form-field-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../form-field-procs.tcl
- -2
- +2
/openacs-4/packages/xowiki/tcl/lcs-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/lcs-procs.tcl

12:06 pm

gustafn

- commit speedup from OpenACS.org, which might be useful for most sites.

- -6
- +21
/openacs-4/packages/forums/tcl/forums-callback-procs.tcl
- History
- Source
- Diff
/openacs-4/.../forums-callback-procs.tcl

11:57 am

gustafn

- simplify logic; set message(screen_name) always

- -3
- +5
/openacs-4/packages/forums/lib/message/row.tcl
- History
- Source
- Diff
/openacs-4/packages/.../message/row.tcl

11:49 am

gustafn

- flatten nested lindex-structures

- use single "lassign" instead of multiple "lindex" operations

- -10
- +7
/openacs-4/packages/acs-templating/tcl/doc-tcl-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/doc-tcl-procs.tcl
- -2
- +2
/openacs-4/packages/acs-templating/tcl/parse-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/parse-procs.tcl
- -4
- +4
/openacs-4/packages/acs-templating/tcl/widget-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/widget-procs.tcl
- -2
- +2
/openacs-4/packages/acs-templating/www/scripts/xinha/attach-file.tcl
- History
- Source
- Diff
/openacs-4/packages/.../xinha/attach-file.tcl
- -2
- +2
/openacs-4/packages/acs-templating/www/scripts/xinha/attach-image.tcl
- History
- Source
- Diff
/openacs-4/packages/.../attach-image.tcl

10:47 am

gustafn

- brace expressions

- factor out groupby tests

- -25
- +28
/openacs-4/packages/acs-templating/tcl/list-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/list-procs.tcl

10:12 am

gustafn

- avoid setting one-use variables for frequently called code

- fold multiple upvars to a single one

- make indentation more regular

- fix one case of double dollar

- -103
- +87
/openacs-4/packages/acs-templating/tcl/form-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/form-procs.tcl

11:32 pm

gustafn

- normalize string expressions

- -2
- +2
/openacs-4/packages/acs-tcl/tcl/xml-1-dom-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../xml-1-dom-procs.tcl

11:20 pm

gustafn

More
oacs-5-8:gustafn:20131010212009
changed 13 files
oacs-5-8

- normalize string expressions

- -3
- +3
/openacs-4/packages/acs-templating/tcl/data-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/data-procs.tcl
- -5
- +5
/openacs-4/packages/acs-templating/tcl/date-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/date-procs.tcl
- -2
- +2
/openacs-4/packages/acs-templating/tcl/filter-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/filter-procs.tcl
- -7
- +7
/openacs-4/packages/acs-templating/tcl/form-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/form-procs.tcl
- -22
- +22
/openacs-4/packages/acs-templating/tcl/list-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/list-procs.tcl
- -3
- +3
/openacs-4/packages/acs-templating/tcl/paginator-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../paginator-procs.tcl
- -2
- +2
/openacs-4/packages/acs-templating/tcl/richtext-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../richtext-procs.tcl
- -4
- +4
/openacs-4/packages/acs-templating/tcl/widget-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/widget-procs.tcl
- -1
- +1
/openacs-4/packages/acs-templating/www/doc/demo/display-edit.tcl
- History
- Source
- Diff
/openacs-4/packages/.../demo/display-edit.tcl
- -2
- +2
/openacs-4/packages/acs-templating/www/doc/demo/sandwich.tcl
- History
- Source
- Diff
/openacs-4/packages/.../demo/sandwich.tcl
- -2
- +2
/openacs-4/packages/acs-templating/www/resources/xinha-nightly/plugins/OacsFs/popups/file-selector.tcl
- History
- Source
- Diff
/openacs-4/packages/.../file-selector.tcl
- -3
- +3
/openacs-4/packages/acs-templating/www/scripts/xinha/attach-file.tcl
- History
- Source
- Diff
/openacs-4/packages/.../xinha/attach-file.tcl
- -2
- +2
/openacs-4/packages/acs-templating/www/scripts/xinha/file-selector.tcl
- History
- Source
- Diff
/openacs-4/packages/.../file-selector.tcl

11:00 pm

gustafn

More
oacs-5-8:gustafn:20131010210045
changed 17 files
oacs-5-8

- use numeric comparison for truth values

- -4
- +4
/openacs-4/packages/acs-subsite/tcl/attribute-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../attribute-procs.tcl
- -2
- +2
/openacs-4/packages/acs-subsite/tcl/group-type-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../group-type-procs.tcl
- -3
- +3
/openacs-4/packages/acs-subsite/tcl/package-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/package-procs.tcl
- -3
- +3
/openacs-4/packages/acs-subsite/tcl/plsql-utility-procs.tcl
- History
- Source
- Diff
/openacs-4/.../plsql-utility-procs.tcl
- -2
- +2
/openacs-4/packages/acs-subsite/tcl/rel-types-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../rel-types-procs.tcl
- -2
- +2
/openacs-4/packages/acs-subsite/www/admin/attributes/add-2.tcl
- History
- Source
- Diff
/openacs-4/packages/.../attributes/add-2.tcl
- -2
- +2
/openacs-4/packages/acs-subsite/www/admin/group-types/change-join-policy-2.tcl
- History
- Source
- Diff
/openacs-4/.../change-join-policy-2.tcl
- -2
- +2
/openacs-4/packages/acs-subsite/www/admin/group-types/change-join-policy.tcl
- History
- Source
- Diff
/openacs-4/.../change-join-policy.tcl
- -3
- +3
/openacs-4/packages/acs-subsite/www/admin/groups/new.tcl
- History
- Source
- Diff
/openacs-4/packages/.../groups/new.tcl
- -3
- +3
/openacs-4/packages/acs-subsite/www/admin/parties/new.tcl
- History
- Source
- Diff
/openacs-4/packages/.../parties/new.tcl
- -8
- +8
/openacs-4/packages/acs-subsite/www/admin/relations/add.tcl
- History
- Source
- Diff
/openacs-4/packages/.../relations/add.tcl
- -5
- +5
/openacs-4/packages/acs-subsite/www/admin/site-map/index.tcl
- History
- Source
- Diff
/openacs-4/packages/.../site-map/index.tcl
- -5
- +5
/openacs-4/packages/acs-subsite/www/admin/site-map/site-map.tcl
- History
- Source
- Diff
/openacs-4/packages/.../site-map/site-map.tcl
- -4
- +4
/openacs-4/packages/acs-subsite/www/admin/users/new.tcl
- History
- Source
- Diff
/openacs-4/packages/.../users/new.tcl
- -3
- +3
/openacs-4/packages/acs-subsite/www/permissions/one.tcl
- History
- Source
- Diff
/openacs-4/packages/.../permissions/one.tcl
- -3
- +3
/openacs-4/packages/acs-subsite/www/pvt/alerts.tcl
- History
- Source
- Diff
/openacs-4/packages/.../pvt/alerts.tcl
- -5
- +5
/openacs-4/packages/acs-subsite/www/site-map/index.tcl
- History
- Source
- Diff
/openacs-4/packages/.../site-map/index.tcl

10:48 pm

gustafn

- use numeric comparison for truth value comparison

- -3
- +3
/openacs-4/packages/forums/lib/message/thread-chunk.tcl
- History
- Source
- Diff
/openacs-4/packages/.../thread-chunk.tcl
- -2
- +2
/openacs-4/packages/forums/www/forum-view.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/forum-view.tcl
- -2
- +2
/openacs-4/packages/forums/www/message-view.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/message-view.tcl

10:47 pm

gustafn

- get screen name only when requested

- -2
- +7
/openacs-4/packages/forums/lib/message/row.tcl
- History
- Source
- Diff
/openacs-4/packages/.../message/row.tcl

10:44 pm

gustafn

More
oacs-5-8:gustafn:20131010204407
changed 10 files
oacs-5-8

- brace while expressions

- don't use expr within while expression

- use numeric comparison for truth values

- normalize string expressions

- -2
- +2
/openacs-4/packages/acs-tcl/tcl/admin-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/admin-procs.tcl
- -2
- +2
/openacs-4/packages/acs-tcl/tcl/aolserver-3-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../aolserver-3-procs.tcl
- -2
- +2
/openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../apm-install-procs.tcl
- -5
- +5
/openacs-4/packages/acs-tcl/tcl/request-processor-init.tcl
- History
- Source
- Diff
/openacs-4/.../request-processor-init.tcl
- -10
- +10
/openacs-4/packages/acs-tcl/tcl/security-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../security-procs.tcl
- -2
- +2
/openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../site-nodes-procs.tcl
- -5
- +5
/openacs-4/packages/acs-tcl/tcl/table-display-procs.tcl
- History
- Source
- Diff
/openacs-4/.../table-display-procs.tcl
- -30
- +30
/openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../utilities-procs.tcl
- -2
- +2
/openacs-4/packages/acs-tcl/tcl/xml-0-sgml-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../xml-0-sgml-procs.tcl
- -2
- +2
/openacs-4/packages/acs-tcl/tcl/xml-1-dom-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../xml-1-dom-procs.tcl

9:35 pm

gustafn

- use per-thread caching for security::driver and ad_server_modules

- -6
- +14
/openacs-4/packages/acs-tcl/tcl/security-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../security-procs.tcl

2:06 pm

gustafn

- new functions security::driver and ad_server_modules to simplify

redundant logic for determining secure drivers

- -32
- +47
/openacs-4/packages/acs-tcl/tcl/security-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../security-procs.tcl

10:18 am

gustafn

- added author for blaming

- -1
- +3
/openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../utilities-procs.tcl

10:14 am

gustafn

- ad_job: Added convenience wrapper for simple usages of ns_job with timeout

- -1
- +33
/openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../utilities-procs.tcl

OpenACS

Line History

Stats

Commits this week: 0

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

gustafn

gustafn

gustafn

gustafn

gustafn

gustafn

gustafn

gustafn

gustafn

gustafn

gustafn

gustafn

gustafn

gustafn

gustafn

gustafn

gustafn

gustafn

gustafn

gustafn

gustafn

gustafn

gustafn

gustafn

gustafn

gustafn

gustafn

gustafn

gustafn

gustafn