OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 7
Total Committers: 146
Last Commit: 07 Nov
Commits this week: 7
Total Lines of Code (LoC): 7,560,799
Net change in LoC this week: 46

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 12 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 02 Oct 2013
10:56 am

gustafn

- brace expressions to allow for tcl compilation

- use "in" or not in (ni) operator instead of lsearch (for readability and performance)

Options
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/apm/packages-install-2.tcl
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/apm/packages-install-4.tcl
    • -1
    • +1
    /openacs-4/packages/acs-admin/www/auth/authority-parameters.tcl
    • -1
    • +1
    /openacs-4/packages/acs-admin/www/install/install-2.tcl
    • -4
    • +2
    /openacs-4/packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-authentication/tcl/test/acs-authentication-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-bootstrap-installer/tcl/30-apm-load-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-datetime/tcl/acs-calendar-2-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-datetime/tcl/acs-calendar-procs.tcl
    • -5
    • +5
    /openacs-4/packages/acs-datetime/tcl/acs-datetime-procs.tcl
10:42 am

gustafn

- use "in" or not in (ni) operator instead of lsearch (for readability and performance)

- use "eq" instead of "string equal"

Options
    • -3
    • +3
    /openacs-4/packages/acs-content-repository/tcl/content-item-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/tcl/content-revision-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-content-repository/tcl/filter-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-content-repository/tcl/publish-procs.tcl
10:29 am

gustafn

- use "in" or not in (ni) operator instead of lsearch (for readability and performance)

Options
    • -3
    • +3
    /openacs-4/packages/acs-authentication/tcl/test/acs-authentication-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-bootstrap-installer/installer.tcl
    • -2
    • +2
    /openacs-4/packages/acs-bootstrap-installer/tcl/30-apm-load-procs.tcl
10:01 am

gustafn

- use "in" or not in (ni) operator instead of lsearch (for readability and performance)

Options
    • -3
    • +3
    /openacs-4/packages/acs-authentication/tcl/authentication-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-authentication/tcl/authority-procs.tcl
    • -4
    • +4
    /openacs-4/packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl
9:55 am

gustafn

- don't abbreviate "info" subcommands

- no need for "\" in continuation lines of expression

Options
    • -13
    • +13
    /openacs-4/packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl
    • -3
    • +4
    /openacs-4/packages/acs-api-browser/www/type-view.tcl
9:44 am

gustafn

- use "in" operator instead of lsearch (for readability and performance)

Options
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/apm/packages-install.tcl
    • -1
    • +1
    /openacs-4/packages/acs-admin/www/auth/authority.tcl
    • -5
    • +5
    /openacs-4/packages/acs-tcl/tcl/apm-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/apm-xml-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/application-data-link-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/set-operation-procs.tcl
9:42 am

gustafn

- add outdated function based on non-existing tables (currency_codes)

Options
    • -0
    • +125
    /openacs-4/packages/acs-outdated/tcl/acs-lang-localization-procs.tcl
    • -0
    • +23
    /openacs-4/packages/acs-outdated/tcl/acs-lang-localization-procs.xql
    • -0
    • +32
    /openacs-4/packages/acs-outdated/tcl/acs-tcl-widget-procs.tcl
    • -0
    • +15
    /openacs-4/packages/acs-outdated/tcl/acs-tcl-widget-procs.xql
9:23 am

gustafn

- move ad_user_class_query and ad_user_class_query_count_only from

packages/acs-tcl/tcl/admin-procs.{tcl,xql} to acs-outdated/tcl/

since these functions are non-functional (based on non-existing

tables)

- move related code from acs-admin/www/users/one.{tcl,xql} to acs-outdated/www/

Options
    • -71
    • +1
    /openacs-4/packages/acs-admin/www/users/one.tcl
    • -10
    • +0
    /openacs-4/packages/acs-admin/www/users/one.xql
    • -241
    • +1
    /openacs-4/packages/acs-tcl/tcl/admin-procs.tcl
    • -61
    • +0
    /openacs-4/packages/acs-tcl/tcl/admin-procs.xql
9:23 am

gustafn

- move ad_user_class_query and ad_user_class_query_count_only from

packages/acs-tcl/tcl/admin-procs.{tcl,xql} to acs-outdated/tcl/

since these functions are non-functional (based on non-existing

tables)

- move related code from acs-admin/www/users/one.{tcl,xql} to acs-outdated/www/

Options
    • -0
    • +241
    /openacs-4/packages/acs-outdated/tcl/acs-tcl-admin-procs.tcl
    • -0
    • +61
    /openacs-4/packages/acs-outdated/tcl/acs-tcl-admin-procs.xql
    • -0
    • +71
    /openacs-4/packages/acs-outdated/www/acs-tcl-users-one.tcl
8:23 am

gustafn

- use "in" oeprator instead of "lsearch" to improve readability and performance

Options
    • -8
    • +8
    /openacs-4/packages/acs-tcl/tcl/admin-procs.tcl
6:59 am

gustafn

- added acs-outdated

Options
    • -0
    • +1
    /CVSROOT/modules
6:54 am

gustafn

- initial checkin

Options
    • -0
    • +28
    /openacs-4/packages/acs-outdated/acs-outdated.info
Tuesday 01 Oct 2013
12:03 pm

gustafn

- fix incorrect variable name "package_id" used instead of "subsite_id"

- make variable check explicit

Options
    • -7
    • +7
    /openacs-4/packages/acs-subsite/lib/login.tcl
10:47 am

gustafn

- no need to use "expr" in a condition of a "for" loop

Options
    • -3
    • +3
    /openacs-4/packages/acs-admin/www/apm/packages-install.tcl
    • -2
    • +2
    /openacs-4/packages/acs-subsite/tcl/attribute-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-subsite/tcl/package-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-templating/tcl/list-procs.tcl
10:36 am

gustafn

- modernize tcl

- brace expressions

- no need to use expr in condition of for loop

- no need to test for existence when variables have defaults

Options
    • -26
    • +26
    /openacs-4/packages/acs-datetime/tcl/acs-calendar-2-procs.tcl
    • -31
    • +31
    /openacs-4/packages/acs-datetime/tcl/acs-calendar-procs.tcl
    • -52
    • +52
    /openacs-4/packages/acs-datetime/tcl/acs-datetime-procs.tcl
10:16 am

gustafn

- not need to check for existence of variables with defaults: email, first_names, limit_to_users_in_group_id authority_id last_name_starts_with

Options
    • -14
    • +15
    /openacs-4/packages/acs-admin/www/users/complex-search.tcl
10:09 am

gustafn

- fix spelling limit_users_in_group_id -> limit_to_users_in_group_id

Options
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/users/complex-search.tcl
    • -6
    • +8
    /openacs-4/packages/acs-admin/www/users/search.tcl
10:02 am

gustafn

- "email" and "limit_to_user_id" have defaults, no need to check for existence

Options
    • -4
    • +4
    /openacs-4/packages/acs-admin/www/users/search.tcl
9:54 am

gustafn

- "email" and "last_name" have defaults, no need to check for existence

Options
    • -5
    • +3
    /openacs-4/packages/acs-admin/www/users/search.tcl
9:43 am

gustafn

- use "in" operator instead of lsearch

Options
    • -2
    • +2
    /openacs-4/packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl
9:40 am

gustafn

- simply string comparisons

- use tcl 8.5 extended index format for "lindex" and "lrange"

Options
    • -2
    • +2
    /openacs-4/packages/acs-bootstrap-installer/bootstrap.tcl
    • -6
    • +6
    /openacs-4/packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-bootstrap-installer/tcl/30-apm-load-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl
9:18 am

gustafn

- bumped version number

- update search engine links default value

Options
    • -16
    • +16
    /openacs-4/packages/search/search.info
Monday 30 Sep 2013
8:26 pm

gustafn

- make exists_and_not_null explicit

Options
    • -32
    • +37
    /openacs-4/packages/acs-authentication/tcl/authentication-procs.tcl
    • -5
    • +5
    /openacs-4/packages/acs-authentication/tcl/authority-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-authentication/tcl/local-procs.tcl
    • -10
    • +9
    /openacs-4/packages/acs-authentication/tcl/password-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-authentication/tcl/sync-procs.tcl
    • -16
    • +20
    /openacs-4/packages/acs-authentication/tcl/test/acs-authentication-procs.tcl
    • -13
    • +14
    /openacs-4/packages/acs-authentication/tcl/test/sync-test-procs.tcl
7:44 pm

gustafn

- modernize tcl

Options
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/tcl/content-folder-procs.tcl
    • -8
    • +10
    /openacs-4/packages/acs-content-repository/tcl/content-item-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-content-repository/tcl/content-keyword-procs.tcl
    • -6
    • +7
    /openacs-4/packages/acs-content-repository/tcl/content-revision-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/tcl/content-symlink-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/tcl/content-template-procs.tcl
    • -3
    • +5
    /openacs-4/packages/acs-content-repository/tcl/item-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/tcl/publish-procs.tcl
    • -4
    • +5
    /openacs-4/packages/acs-content-repository/tcl/revision-procs.tcl
    • -3
    • +4
    /openacs-4/packages/acs-content-repository/tcl/test/acs-content-repository-procs.tcl
2:00 pm

gustafn

- don't abbreviate subcommands

Options
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/test/ad-proc-test-procs.tcl
2:00 pm

gustafn

- follow usual indenting convention

Options
    • -4
    • +2
    /openacs-4/packages/acs-tcl/tcl/apm-file-procs.tcl
1:37 pm

gustafn

- don't abbreviate subcommands

Options
    • -10
    • +10
    /openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xotcl-core/tcl/06-param-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/20-Ordered-Composite-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xotcl-core/tcl/bgdelivery-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xotcl-core/tcl/chat-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xotcl-core/tcl/context-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xotcl-core/tcl/html-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/http-client-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xotcl-core/tcl/install-check-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-init.tcl
    • -3
    • +3
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xotcl-request-monitor/www/index.tcl
    • -2
    • +2
    /openacs-4/packages/xotcl-request-monitor/www/running.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/chat-procs.tcl
  16. … 8 more files in changeset.
1:33 pm

gustafn

- modernize tcl

- break overlong lines

Options
    • -4
    • +4
    /openacs-4/packages/forums/lib/forums-portlet.tcl
    • -2
    • +2
    /openacs-4/packages/forums/lib/forums/admin-forums-chunk.tcl
    • -2
    • +2
    /openacs-4/packages/forums/lib/forums/edit.tcl
    • -2
    • +2
    /openacs-4/packages/forums/lib/forums/forums-chunk.tcl
    • -2
    • +2
    /openacs-4/packages/forums/lib/forums/forums-history-chunk.tcl
    • -2
    • +2
    /openacs-4/packages/forums/lib/forums/new.tcl
    • -3
    • +3
    /openacs-4/packages/forums/lib/message/attachment-list.tcl
    • -2
    • +2
    /openacs-4/packages/forums/lib/message/delete.tcl
    • -2
    • +2
    /openacs-4/packages/forums/lib/message/messages-table.tcl
    • -2
    • +2
    /openacs-4/packages/forums/lib/message/pending-list-chunk.tcl
    • -2
    • +2
    /openacs-4/packages/forums/lib/message/post.tcl
    • -4
    • +4
    /openacs-4/packages/forums/lib/message/row.tcl
    • -3
    • +3
    /openacs-4/packages/forums/lib/message/row2.tcl
    • -3
    • +3
    /openacs-4/packages/forums/lib/message/thread-chunk.tcl
    • -10
    • +19
    /openacs-4/packages/forums/lib/message/threads-chunk.tcl
  16. … 5 more files in changeset.
1:22 pm

gustafn

- don't abbreviate subcommands

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/10-charset-compat-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/20-memoize-init.tcl
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/apm-file-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/form-processing-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/xml-2-procs.tcl
1:12 pm

gustafn

- use tcl 8.5 extended index format for "string range"

Options
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/users/user-batch-add-2.tcl