• last updated 15 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Whitespace changeds

    • -106
    • +106
    /openacs-4/packages/acs-tcl/tcl/defs-procs.tcl
    • -261
    • +261
    /openacs-4/packages/acs-tcl/tcl/deprecated-procs.tcl
Harmonize parameter names in proc documentation removing unnecessary hyphens

Fix parameter name

Allow square brackets in proc doc. In particular, this fixed a false positive with [doc_string] in 'ad_proc'

Improve 'args' check in 'documentation__check_parameters' test case by using the built-in 'varargs_p' variable.

Sanitize date stings for parsability with clock scan and allow HTTPS requests using 'util::http::post' (many thanks to Markus Moser).

    • -33
    • +7
    /openacs-4/packages/xml-rpc/tcl/xml-rpc-procs.tcl
Add 'args' parameter to the real parameter list of the 'documentation__check_parameters', as it is not included into 'switches' or 'positionals'.

Use 'apm_get_package_files -file_types' instead of filtering the 'www' and 'lib' directories manually.

Take care of '_p' boolean parameters when checking for discrepancies between real and documented proc parameters.

- add the detail-link only when necessary

- include the email address properly

Overhaul of test cases:

- make tested API calls explict

- reduce dependency on twt

  1. … 4 more files in changeset.
Add call graph information based on static analysis to API doc. This information

is computed on a best-effor bases and not necessarily complete, since static analysis

of a dyamic language is limited; furthermore, direct calls from web pages are not included

for activation, see tcl/api-doc-init.tcl

    • -0
    • +24
    /openacs-4/packages/acs-api-browser/tcl/api-doc-init.tcl
Fix parameter name in proc documentation

Whitespace changes

Fix misleading and uncoherent 'ad_dispatch' proc documentation, discovered using the 'documentation__check_parameters' test.

don't leak user_ids from regression test case

make tested API calls explicit

prefer built-in ns_dbquotevalue over DoubleApos

improve spelling

modernize Tcl

normalize boolean expressions in .adp files

prefer built-in ns_dbquotevalue over DoubleApos

  1. … 3 more files in changeset.
normalize boolean expressions in .adp files

  1. … 20 more files in changeset.
prefer built-in ns_dbquotevalue over DoubleApos

make former private functions, used in several packages to public functions

prefer built-in ns_dbquotevalue over DoubleApos

remove single quotes

prefer built-in ns_dbquotevalue over DoubleApos

improve spelling

Add new test case 'documentation__check_parameters', which checks if parameters defined in the proc doc (@param) are really proc parameters.

Sometimes proc parameter changes are not reflected in the proc doc, this should take care of some of these cases.