Index: TODO =================================================================== diff -u -raccdf4beee7067c76291e80b85d8336c69075510 -r08dedaca6e7654b181f4d33d918bc3b9737fed71 --- TODO (.../TODO) (revision accdf4beee7067c76291e80b85d8336c69075510) +++ TODO (.../TODO) (revision 08dedaca6e7654b181f4d33d918bc3b9737fed71) @@ -5559,8 +5559,6 @@ - prefer explicit comparisons - remove test, since it is covered already by assertions -======================================================================== -TODO: - Is NsfParamDefs.slotObj obsolete? @@ -5577,6 +5575,13 @@ pt. 2: NsfParamDefs.slotObj and its memory-management statements all over remain in place, to be reviewed. +- removed NsfParamDefs.slotObj (and single occurance for memory-management) + since it is not used for the time being + +======================================================================== +TODO: + + - should we change "/obj/ info lookup syntax /methodName/" to return obj and method as well? (similar to "info method syntax /methodName/") Index: generic/nsf.c =================================================================== diff -u -raccdf4beee7067c76291e80b85d8336c69075510 -r08dedaca6e7654b181f4d33d918bc3b9737fed71 --- generic/nsf.c (.../nsf.c) (revision accdf4beee7067c76291e80b85d8336c69075510) +++ generic/nsf.c (.../nsf.c) (revision 08dedaca6e7654b181f4d33d918bc3b9737fed71) @@ -11360,7 +11360,6 @@ if (paramDefs->paramsPtr != NULL) { ParamsFree(paramDefs->paramsPtr); } - if (paramDefs->slotObj != NULL) {DECR_REF_COUNT2("paramDefsObj", paramDefs->slotObj);} if (paramDefs->returns != NULL) {DECR_REF_COUNT2("paramDefsObj", paramDefs->returns);} FREE(NsfParamDefs, paramDefs); } @@ -21983,7 +21982,7 @@ */ Nsf_methodDefinition *mdPtr = Nsf_CmdDefinitionGet(((Command *)cmd)->objProc); if (mdPtr != NULL) { - NsfParamDefs paramDefs = {mdPtr->paramDefs, mdPtr->nrParameters, 1, 0, NULL, NULL}; + NsfParamDefs paramDefs = {mdPtr->paramDefs, mdPtr->nrParameters, 1, 0, NULL}; Tcl_Obj *list = ListParamDefs(interp, paramDefs.paramsPtr, contextObject, pattern, printStyle); Tcl_SetObjResult(interp, list); @@ -21998,9 +21997,9 @@ if (cd && cd->paramsPtr) { Tcl_Obj *list; NsfParamDefs paramDefs; + paramDefs.paramsPtr = cd->paramsPtr; paramDefs.nrParams = 1; - paramDefs.slotObj = NULL; list = ListParamDefs(interp, paramDefs.paramsPtr, contextObject, pattern, printStyle); Tcl_SetObjResult(interp, list); DECR_REF_COUNT2("paramDefsObj", list); Index: generic/nsfInt.h =================================================================== diff -u -r6c7bb9ba109a65cf8b80fbe947268522dc528ebe -r08dedaca6e7654b181f4d33d918bc3b9737fed71 --- generic/nsfInt.h (.../nsfInt.h) (revision 6c7bb9ba109a65cf8b80fbe947268522dc528ebe) +++ generic/nsfInt.h (.../nsfInt.h) (revision 08dedaca6e7654b181f4d33d918bc3b9737fed71) @@ -512,7 +512,7 @@ #define NsfObjectIsClass(obj) \ ((obj)->flags & NSF_IS_CLASS) #define NsfObjectToClass(obj) \ - (NsfClass*)((((NsfObject*)obj)->flags & NSF_IS_CLASS)?obj:NULL) + (NsfClass *)((((NsfObject *)obj)->flags & NSF_IS_CLASS) ? obj : NULL) /* @@ -524,7 +524,6 @@ int nrParams; int refCount; int serial; - Tcl_Obj *slotObj; Tcl_Obj *returns; } NsfParamDefs;