Index: openacs-4/packages/xowiki/tcl/package-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowiki/tcl/package-procs.tcl,v diff -u -r1.279.2.19 -r1.279.2.20 --- openacs-4/packages/xowiki/tcl/package-procs.tcl 12 Dec 2014 12:50:26 -0000 1.279.2.19 +++ openacs-4/packages/xowiki/tcl/package-procs.tcl 11 Jan 2015 20:50:01 -0000 1.279.2.20 @@ -792,7 +792,8 @@ if {[$page_or_package istype ::xowiki::FormPage] && [$page_or_package is_link_page] && [[self class] exists delegate_link_to_target($method)]} { - # if the target is a link, we may want to call the method on the target + # If the target is a symbolic link, we may want to call the + # method on the target set target [$page_or_package get_target_from_link_page] #my msg "delegate $method from $page_or_package [$page_or_package name] to $target [$target name]" if {$target ne ""} {set page_or_package $target} @@ -807,10 +808,10 @@ if {$batch_mode} {[my id] unset __batch_mode} if {$err} { - #ns_log notice "errorMsg: $errorMsg, $::errorInfo" - return [my error_msg -status_code 404 \ + ns_log notice "error during invocation of method $method errorMsg: $errorMsg, $::errorInfo" + return [my error_msg -status_code 500 \ -template_file $error_template \ - [ns_quotehtml $errorMsg]] + [ns_quotehtml "error during $method: $errorMsg"]] } return $r } Index: openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl,v diff -u -r1.320.2.22 -r1.320.2.23 --- openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl 8 Sep 2014 10:55:43 -0000 1.320.2.22 +++ openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl 11 Jan 2015 20:50:02 -0000 1.320.2.23 @@ -1078,8 +1078,7 @@ } } #my show_fields $form_fields - foreach {validation_errors category_ids} \ - [my get_form_data -field_names $query_field_names $form_fields] break + lassign [my get_form_data -field_names $query_field_names $form_fields] validation_erors category_ids if {$validation_errors == 0} { # @@ -1179,8 +1178,8 @@ break } } - foreach {validation_errors category_ids} \ - [my get_form_data -field_names $query_field_names $form_fields] break + lassign [my get_form_data -field_names $query_field_names $form_fields] \ + validation_errors category_ids set error "" if {$validation_errors == 0} { set status_code 200 @@ -2007,7 +2006,7 @@ # set validation_error [$f validate [self]] if {$validation_error ne ""} { - #my msg "validation of $f [$f name] with value '[$f value]' returns '$validation_error'" + #my log "validation of $f [$f name] with value '[$f value]' returns '$validation_error'" $f error_msg $validation_error incr validation_errors } @@ -2047,6 +2046,7 @@ #my instance_attributes [array get __ia] #my msg category_ids=$category_ids + return [list $validation_errors [lsort -unique $category_ids]] }