Index: openacs-4/packages/assessment/tcl/as-assessment-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/tcl/as-assessment-procs.tcl,v diff -u -r1.36.2.1 -r1.36.2.2 --- openacs-4/packages/assessment/tcl/as-assessment-procs.tcl 18 Aug 2014 20:25:00 -0000 1.36.2.1 +++ openacs-4/packages/assessment/tcl/as-assessment-procs.tcl 18 Aug 2014 20:27:50 -0000 1.36.2.2 @@ -592,8 +592,8 @@ Compares the first part of a pair of strings as numbers } { - set a0 [expr double([lindex [lindex $a 0] 0])] - set b0 [expr double([lindex [lindex $b 0] 0])] + set a0 [expr double([lindex $a 0 0])] + set b0 [expr double([lindex $b 0 0])] if {$a0 > $b0} { return 1 } elseif {$a0 == $b0} { Index: openacs-4/packages/assessment/tcl/as-item-data-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/tcl/as-item-data-procs.tcl,v diff -u -r1.13.4.1 -r1.13.4.2 --- openacs-4/packages/assessment/tcl/as-item-data-procs.tcl 18 Aug 2014 20:25:00 -0000 1.13.4.1 +++ openacs-4/packages/assessment/tcl/as-item-data-procs.tcl 18 Aug 2014 20:27:50 -0000 1.13.4.2 @@ -105,8 +105,8 @@ } { if {$session_id eq ""} { set last_sessions [db_list_of_lists last_sessions {}] - set session_id [lindex [lindex $last_sessions 0] 0] - set as_item_id [lindex [lindex $last_sessions 0] 1] + set session_id [lindex $last_sessions 0 0] + set as_item_id [lindex $last_sessions 0 1] } if {$session_id ne "" && [db_0or1row response {} -column_array response]} { Index: openacs-4/packages/assessment/tcl/as-item-type-mc-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/tcl/as-item-type-mc-procs.tcl,v diff -u -r1.25.2.1 -r1.25.2.2 --- openacs-4/packages/assessment/tcl/as-item-type-mc-procs.tcl 18 Aug 2014 20:25:01 -0000 1.25.2.1 +++ openacs-4/packages/assessment/tcl/as-item-type-mc-procs.tcl 18 Aug 2014 20:27:50 -0000 1.25.2.2 @@ -750,7 +750,7 @@ Get what form widget we used } { set display_type [db_string allow_other_p "select object_type from acs_objects, as_item_rels r1, as_item_rels r2, cr_items ci where r1.item_rev_id = ci.latest_revision and r1.item_rev_id=r2.item_rev_id and r1.target_rev_id=:type_id and r1.rel_type='as_item_type_rel' and r2.target_rev_id=object_id and r2.rel_type='as_item_display_rel'"] - set display_type [string range $display_type [expr {[string length $display_type] - 2}] end] + set display_type [string range $display_type [string length $display_type]-2 end] return [string map {rb radio cb checkbox sb selet} $display_type] } \ No newline at end of file Index: openacs-4/packages/assessment/tcl/as-section-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/tcl/as-section-procs.tcl,v diff -u -r1.32.4.1 -r1.32.4.2 --- openacs-4/packages/assessment/tcl/as-section-procs.tcl 18 Aug 2014 20:25:02 -0000 1.32.4.1 +++ openacs-4/packages/assessment/tcl/as-section-procs.tcl 18 Aug 2014 20:27:50 -0000 1.32.4.2 @@ -260,7 +260,7 @@ lappend sorted_items $fixed_position($position) array unset fixed_position $position } elseif {[llength $open_positions] > 0} { - lappend sorted_items [lindex [lindex $open_positions 0] 0] + lappend sorted_items [lindex $open_positions 0 0] set open_positions [lreplace $open_positions 0 0] } } Index: openacs-4/packages/assessment/www/asm-admin/action-params.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/www/asm-admin/action-params.tcl,v diff -u -r1.7.8.1 -r1.7.8.2 --- openacs-4/packages/assessment/www/asm-admin/action-params.tcl 18 Aug 2014 20:25:03 -0000 1.7.8.1 +++ openacs-4/packages/assessment/www/asm-admin/action-params.tcl 18 Aug 2014 20:27:51 -0000 1.7.8.2 @@ -100,7 +100,7 @@ db_foreach get_params {} { set param_$parameter_id [as::assessment::check::get_parameter_value -parameter_id $parameter_id -type $type -check_id $inter_item_check_id] if { [set param_$parameter_id] eq ""} { - set param_$parameter_id [lindex [lindex $choices 0] 1] + set param_$parameter_id [lindex $choices 0 1] } } Index: openacs-4/packages/assessment/www/asm-admin/admin-request.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/www/asm-admin/admin-request.tcl,v diff -u -r1.3.6.1 -r1.3.6.2 --- openacs-4/packages/assessment/www/asm-admin/admin-request.tcl 18 Aug 2014 20:25:04 -0000 1.3.6.1 +++ openacs-4/packages/assessment/www/asm-admin/admin-request.tcl 18 Aug 2014 20:27:51 -0000 1.3.6.2 @@ -31,8 +31,8 @@ # set default values set d_state "f" -set d_assessment [lindex [lindex $assessment_list 0] 1] -set d_interval [lindex [lindex $intervals 0] 1] +set d_assessment [lindex $assessment_list 0 1] +set d_interval [lindex $intervals 0 1] set d_date "" set date_query "" set interval_query "" Index: openacs-4/packages/assessment/www/asm-admin/bulk-mail.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/www/asm-admin/bulk-mail.tcl,v diff -u -r1.5.6.1 -r1.5.6.2 --- openacs-4/packages/assessment/www/asm-admin/bulk-mail.tcl 18 Aug 2014 20:25:04 -0000 1.5.6.1 +++ openacs-4/packages/assessment/www/asm-admin/bulk-mail.tcl 18 Aug 2014 20:27:51 -0000 1.5.6.2 @@ -25,7 +25,7 @@ append users_list "$subject_id," } -set users_list [string range $users_list 0 [expr {[string length $users_list] -2}]] +set users_list [string range $users_list 0 [string length $users_list]-2] append users_list ")" set query "select email from cc_users where object_id in $users_list" Index: openacs-4/packages/assessment/www/asm-admin/checks-admin.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/www/asm-admin/checks-admin.tcl,v diff -u -r1.9.8.1 -r1.9.8.2 --- openacs-4/packages/assessment/www/asm-admin/checks-admin.tcl 18 Aug 2014 20:25:04 -0000 1.9.8.1 +++ openacs-4/packages/assessment/www/asm-admin/checks-admin.tcl 18 Aug 2014 20:27:51 -0000 1.9.8.2 @@ -44,7 +44,7 @@ if {$count == 0} { append check_list "0," } - set check_list [string range $check_list 0 [expr {[string length $check_list] -2}]] + set check_list [string range $check_list 0 [string length $check_list]-2] append check_list ")" } Index: openacs-4/packages/assessment/www/asm-admin/request-notification.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/www/asm-admin/request-notification.tcl,v diff -u -r1.3 -r1.3.12.1 --- openacs-4/packages/assessment/www/asm-admin/request-notification.tcl 4 Feb 2005 22:11:54 -0000 1.3 +++ openacs-4/packages/assessment/www/asm-admin/request-notification.tcl 18 Aug 2014 20:27:51 -0000 1.3.12.1 @@ -49,7 +49,7 @@ -widget select\ -label "[_ notifications.Delivery_Method]"\ -options $delivery_methods\ - -value [lindex [lindex $delivery_methods 0] 1] + -value [lindex $delivery_methods 0 1] if {[template::form is_valid notify]} {