Index: openacs-4/packages/forums/lib/message/attachment-list.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/forums/lib/message/attachment-list.tcl,v
diff -u -r1.8.2.4 -r1.8.2.5
--- openacs-4/packages/forums/lib/message/attachment-list.tcl	1 Jul 2019 14:47:07 -0000	1.8.2.4
+++ openacs-4/packages/forums/lib/message/attachment-list.tcl	11 Jul 2019 17:01:26 -0000	1.8.2.5
@@ -14,33 +14,51 @@
 if {(![info exists bgcolor] || $bgcolor eq "")} {
     set bgcolor "#ffffff"
 }
-
-# get the attachments
+#
+# Get the attachments
+#
 template::multirow create attachments url name content_size_pretty icon
 foreach attachment [attachments::get_attachments -object_id $message(message_id)] {
     set id      [lindex $attachment 0]
     set name    [lindex $attachment 1]
     set url     [lindex $attachment 2]
 
-    set content_type [content::item::get_content_type -item_id $id]
-
-    if {$content_type ne "content_extlink"} {
+    set content_size_pretty ""
+    if {[content::extlink::is_extlink -item_id $id]} {
         #
-        # File
-        #
-        set content_size [db_string size {select content_length from cr_revisions where item_id = :id} -default ""]
-        set content_size_pretty "([lc_content_size_pretty -size $content_size])"
-        set icon "/resources/acs-subsite/attach.png"
-    } else {
-        #
         # URL
         #
-        set content_size_pretty ""
         set icon "/resources/acs-subsite/url-button.gif"
         #
         # Avoid redirecting to external hosts made by "go-to-attachment" by just linking the original URL
         #
         set url [db_string url {select url from cr_extlinks where extlink_id = :id} -default ""]
+    } else {
+        #
+        # Not a link, let's try to get the size, in case it is a 'content_item',
+        # a 'content_revision' or a subtype of them.
+        #
+        set object_type [acs_object_type $id]
+        set icon "/resources/acs-subsite/attach.png"
+        if {[content::item::is_subclass \
+                -object_type $object_type \
+                -supertype "content_item"]} {
+            #
+            # Content item, or subtype
+            #
+            set revision [content::item::get_best_revision -item_id $id]
+            set content_size [db_string size {select content_length from cr_revisions where revision_id = :revision} -default ""]
+            set content_size_pretty "([lc_content_size_pretty -size $content_size])"
+
+        } elseif {[content::item::is_subclass \
+                    -object_type $object_type \
+                    -supertype "content_revision"]} {
+            #
+            # Content revision, or subtype
+            #
+            set content_size [db_string size {select content_length from cr_revisions where revision_id = :id} -default ""]
+            set content_size_pretty "([lc_content_size_pretty -size $content_size])"
+        }
     }
 
     template::multirow append attachments $url $name $content_size_pretty $icon
@@ -49,7 +67,7 @@
 set attachment_graphic [attachments::graphic_url]
 
 if {[info exists alt_template] && $alt_template ne ""} {
-  ad_return_template $alt_template
+    ad_return_template $alt_template
 }
 
 # Local variables: