Index: openacs-4/packages/acs-templating/tcl/element-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-templating/tcl/element-procs.tcl,v diff -u -N -r1.37.2.21 -r1.37.2.22 --- openacs-4/packages/acs-templating/tcl/element-procs.tcl 28 Sep 2022 09:16:35 -0000 1.37.2.21 +++ openacs-4/packages/acs-templating/tcl/element-procs.tcl 15 Nov 2022 16:59:14 -0000 1.37.2.22 @@ -420,12 +420,24 @@ # check for submission if { [template::form is_submission $form_id] || [info exists opts(param)] } { + + if {[info exists opts(param)]} { + ad_log warning "Outdated and deprecated form options detected," \ + "The usage of opts(param) will be removed in versions past 5.10.1" + } + validate $form_id $element_id } elseif { [ns_queryget "__edit"] ne "" } { # If the magic __edit button was hit, try to get values from the form still # but don't do any validation set opts(values) [querygetall opts] + ad_log warning "This if-branch is insecure since it bypasses validation." \ + "the branch is deactivated rigjt now, and there is no know usage" \ + "of the __edit flag. If you still need it, uncomment the following line" \ + "and contact webmaster@openacs.org" + error "Outdated and vulnerable code detected, contact webmaster@openacs.org" + # be careful not to clobber a default value if one has been specified if { [llength $opts(values)] || ! [info exists opts(value)] } { set opts(value) [lindex $opts(values) 0]