Index: openacs-4/packages/bulk-mail/tcl/bulk-mail-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/bulk-mail/tcl/bulk-mail-procs.tcl,v diff -u -r1.3 -r1.3.2.1 --- openacs-4/packages/bulk-mail/tcl/bulk-mail-procs.tcl 10 Sep 2002 22:22:29 -0000 1.3 +++ openacs-4/packages/bulk-mail/tcl/bulk-mail-procs.tcl 17 Dec 2002 18:03:23 -0000 1.3.2.1 @@ -169,7 +169,15 @@ } { ns_log notice "bulk_mail::sweep starting" - db_transaction { + ## JCD: this transaction is misguided since any code + ## errors in any procs below would cause the messages + ## already sent to be marked unsent. Also, it seems to + ## cause locking problems on oracle + ## (per Caroline Meeks + ## http://openacs.org/bugtracker/openacs/bug?bug_number=93 + + #db_transaction { + foreach bulk_mail [db_list_of_ns_sets select_bulk_mails_to_send {}] { foreach recipient [db_list_of_ns_sets select_bulk_mail_recipients [ns_set get $bulk_mail query]] { @@ -234,7 +242,7 @@ set bulk_mail_id [ns_set get $bulk_mail bulk_mail_id] db_dml mark_message_sent {} } - } + #} ns_log notice "bulk_mail::sweep ending" }