Index: openacs-4/packages/bookmarks/sql/postgresql/bookmarks-create.sql
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/bookmarks/sql/postgresql/bookmarks-create.sql,v
diff -u -r1.2 -r1.3
--- openacs-4/packages/bookmarks/sql/postgresql/bookmarks-create.sql	2 Jun 2001 07:33:06 -0000	1.2
+++ openacs-4/packages/bookmarks/sql/postgresql/bookmarks-create.sql	3 Jun 2001 04:22:52 -0000	1.3
@@ -260,7 +260,7 @@
 
 --KDK: here!
 
-CREATE FUNCTION url__new(integer,varchar,varchar,varchar,text,text,integer,varchar,integer)
+CREATE FUNCTION url__new (integer,varchar,varchar,varchar,text,text,integer,varchar,integer)
 RETURNS integer AS '
 DECLARE
        p_url_id ALIAS FOR $1;	
@@ -286,7 +286,7 @@
 END;
 ' LANGUAGE 'plpgsql';
 
-CREATE FUNCTION url__delete(integer)
+CREATE FUNCTION url__delete (integer)
 RETURNS integer AS '
 DECLARE
        p_url_id ALIAS FOR $1;	
@@ -298,7 +298,7 @@
 END;
 ' LANGUAGE 'plpgsql';
 
-CREATE FUNCTION url__insert_or_update(varchar,varchar,varchar,text,text,integer,varchar,integer)
+CREATE FUNCTION url__insert_or_update (varchar,varchar,varchar,text,text,integer,varchar,integer)
 RETURNS integer AS '
 DECLARE
        p_url_title ALIAS FOR $1;		-- in bm_urls.url_title%TYPE,
@@ -342,7 +342,7 @@
 ' LANGUAGE 'plpgsql';
 
 
-CREATE FUNCTION bookmark__new(varchar,varchar,varchar,text,text,integer,varchar,integer)
+CREATE FUNCTION bookmark__new (varchar,varchar,varchar,text,text,integer,varchar,integer)
 RETURNS integer AS '
 DECLARE
 	p_bookmark_id ALIAS FOR $1;		-- in bm_bookmarks.bookmark_id%TYPE, 
@@ -407,7 +407,7 @@
 ' LANGUAGE 'plpgsql';
 
 
-CREATE FUNCTION bookmark__delete(integer)
+CREATE FUNCTION bookmark__delete (integer)
 RETURNS integer AS '
 DECLARE
 	p_bookmark_id ALIAS FOR $1;	-- in bm_bookmarks.bookmark_id%TYPE,
@@ -488,7 +488,7 @@
 ' LANGUAGE 'plpgsql';
 
 
-CREATE FUNCTION bookmark__name(integer)
+CREATE FUNCTION bookmark__name (integer)
 RETURNS integer AS '
 DECLARE
 	p_object_id ALIAS FOR $1;	-- in bm_bookmarks.bookmark_id%TYPE,
@@ -503,7 +503,7 @@
 ' LANGUAGE 'plpgsql';
 
 
-CREATE FUNCTION bookmark__get_in_closed_p(integer,integer)
+CREATE FUNCTION bookmark__get_in_closed_p (integer,integer)
 RETURNS integer AS '
 DECLARE
 	p_new_parent_id ALIAS FOR $1;	-- in bm_bookmarks.bookmark_id%TYPE,
@@ -533,7 +533,7 @@
 ' LANGUAGE 'plpgsql';
 
 
-CREATE FUNCTION bookmark__update_in_closed_p_one_user(integer, integer)
+CREATE FUNCTION bookmark__update_in_closed_p_one_user (integer, integer)
 RETURNS integer AS '
 DECLARE
        p_bookmark_id ALIAS FOR $1;	-- in bm_bookmarks.bookmark_id%TYPE,	     
@@ -594,7 +594,7 @@
 ' LANGUAGE 'plpgsql';
 
 
-CREATE FUNCTION bookmark__update_in_closed_p_all_users(integer, integer)
+CREATE FUNCTION bookmark__update_in_closed_p_all_users (integer, integer)
 RETURNS integer AS '
 DECLARE
 	p_bookmark_id ALIAS FOR $1;	-- in bm_bookmarks.bookmark_id%TYPE,
@@ -862,4 +862,3 @@
 END;
 ' LANGUAGE 'plpgsql';
 
-
Index: openacs-4/packages/bookmarks/sql/postgresql/bookmarks-drop.sql
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/bookmarks/sql/postgresql/bookmarks-drop.sql,v
diff -u -r1.1 -r1.2
--- openacs-4/packages/bookmarks/sql/postgresql/bookmarks-drop.sql	2 Jun 2001 03:58:13 -0000	1.1
+++ openacs-4/packages/bookmarks/sql/postgresql/bookmarks-drop.sql	3 Jun 2001 04:22:52 -0000	1.2
@@ -75,15 +75,15 @@
 -- (new, delete, name, get_in_closed_p, update_in_closed_p_one_user, update_in_closed_p_all_users,
 --  toggle_open_close, toggle_open_close_all, get_root_folder, new_root_folder, private_p, 
 --  update_private_p, initialize_in_closed_p)
-DROP FUNCTION bookmark__new(varchar,varchar,varchar,text,text,integer,varchar,integer);
-DROP FUNCTION bookmark__delete(integer);
-DROP FUNCTION bookmark__name(integer);
-DROP FUNCTION bookmark__get_in_closed_p(integer,integer);
-DROP FUNCTION bookmark__update_in_closed_p_one_user(integer, integer);
-DROP FUNCTION bookmark__update_in_closed_p_all_users(integer, integer);
-DROP FUNCTION bookmark__toggle_open_close(integer, integer);
-DROP FUNCTION bookmark__toggle_open_close_all(integer, boolean, integer);
-DROP FUNCTION bookmark__new_root_folder(integer, integer);
+DROP FUNCTION bookmark__new (varchar,varchar,varchar,text,text,integer,varchar,integer);
+DROP FUNCTION bookmark__delete (integer);
+DROP FUNCTION bookmark__name (integer);
+DROP FUNCTION bookmark__get_in_closed_p (integer,integer);
+DROP FUNCTION bookmark__update_in_closed_p_one_user (integer, integer);
+DROP FUNCTION bookmark__update_in_closed_p_all_users (integer, integer);
+DROP FUNCTION bookmark__toggle_open_close (integer, integer);
+DROP FUNCTION bookmark__toggle_open_close_all (integer, boolean, integer);
+DROP FUNCTION bookmark__new_root_folder (integer, integer);
 DROP FUNCTION bookmark__get_root_folder (integer, integer);
 DROP FUNCTION bookmark__private_p (integer);
 DROP FUNCTION bookmark__update_private_p (integer, boolean);
Index: openacs-4/packages/bookmarks/www/most-popular.xql
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/bookmarks/www/most-popular.xql,v
diff -u
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ openacs-4/packages/bookmarks/www/most-popular.xql	3 Jun 2001 04:22:52 -0000	1.1
@@ -0,0 +1,29 @@
+<?xml version="1.0"?>
+<queryset>
+
+<fullquery name="popular_hosts">      
+      <querytext>
+      
+    select unique host_url,
+           $count_select_query as n_bookmarks
+    from  bm_urls
+    order by n_bookmarks desc
+
+      </querytext>
+</fullquery>
+
+ 
+<fullquery name="popular_urls">      
+      <querytext>
+      
+    select coalesce(url_title, complete_url) as local_title, 
+           complete_url, 
+           $count_select_query as n_bookmarks
+    from   bm_urls
+    order by n_bookmarks desc
+
+      </querytext>
+</fullquery>
+
+ 
+</queryset>