Index: openacs-4/packages/acs-admin/tcl/apm-admin-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-admin/tcl/apm-admin-procs.tcl,v diff -u -r1.24 -r1.25 --- openacs-4/packages/acs-admin/tcl/apm-admin-procs.tcl 23 Feb 2018 11:18:59 -0000 1.24 +++ openacs-4/packages/acs-admin/tcl/apm-admin-procs.tcl 25 Apr 2018 19:23:25 -0000 1.25 @@ -277,8 +277,8 @@ } } - array set channel_tag [list] - array set channel_bugfix_version [list] + array set channel_tag {} + array set channel_bugfix_version {} for { } { $i < [llength $lines] } { incr i } { # Tag lines have the form tag: cvs-version @@ -338,7 +338,7 @@ # Store the list of packages we've seen for this channel, so we don't include the same package twice # Seems odd, but we have to do this given the forked packages sitting in /contrib - set packages [list] + set packages {} # Checkout from the tag given by channel_tag($channel) if { $debug_p } { Index: openacs-4/packages/acs-admin/www/apm/build-repository.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-admin/www/apm/Attic/build-repository.tcl,v diff -u -r1.20 -r1.21 --- openacs-4/packages/acs-admin/www/apm/build-repository.tcl 5 Jan 2018 22:59:13 -0000 1.20 +++ openacs-4/packages/acs-admin/www/apm/build-repository.tcl 25 Apr 2018 19:23:25 -0000 1.21 @@ -60,8 +60,8 @@ } } -array set channel_tag [list] -array set channel_bugfix_version [list] +array set channel_tag {} +array set channel_bugfix_version {} for { } { $i < [llength $lines] } { incr i } { # Tag lines have the form tag: cvs-version @@ -114,7 +114,7 @@ # Store the list of packages we've seen for this channel, so we don't include the same package twice # Seems odd, but we have to do this given the forked packages sitting in /contrib - set packages [list] + set packages {} # Checkout from the tag given by channel_tag($channel) if { $debug_p } { Index: openacs-4/packages/acs-admin/www/apm/packages-install.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-admin/www/apm/packages-install.tcl,v diff -u -r1.26 -r1.27 --- openacs-4/packages/acs-admin/www/apm/packages-install.tcl 25 Apr 2018 08:49:03 -0000 1.26 +++ openacs-4/packages/acs-admin/www/apm/packages-install.tcl 25 Apr 2018 19:23:25 -0000 1.27 @@ -135,9 +135,9 @@ ad_set_client_property -clob t apm spec_files $spec_files - set errors [list] - set pkg_info_list [list] - set pkg_key_list [list] + set errors {} + set pkg_info_list {} + set pkg_key_list {} apm_log APMDebug "APM: Specification files available: $spec_files" foreach spec_file $spec_files { ### Parse the package. Index: openacs-4/packages/acs-admin/www/apm/version-callbacks.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-admin/www/apm/version-callbacks.tcl,v diff -u -r1.9 -r1.10 --- openacs-4/packages/acs-admin/www/apm/version-callbacks.tcl 7 Aug 2017 23:47:45 -0000 1.9 +++ openacs-4/packages/acs-admin/www/apm/version-callbacks.tcl 25 Apr 2018 19:23:25 -0000 1.10 @@ -23,7 +23,7 @@ if { [llength $unused_callback_types] > 0 } { set actions [list "\#acs-admin.Add_callback\#" [export_vars -base "version-callback-add-edit" { version_id }]] } else { - set actions [list] + set actions {} } Index: openacs-4/packages/acs-admin/www/apm/version-reload.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-admin/www/apm/version-reload.tcl,v diff -u -r1.13 -r1.14 --- openacs-4/packages/acs-admin/www/apm/version-reload.tcl 9 Jan 2018 13:21:00 -0000 1.13 +++ openacs-4/packages/acs-admin/www/apm/version-reload.tcl 25 Apr 2018 19:23:25 -0000 1.14 @@ -31,7 +31,7 @@ # Source all of the marked files using the current interpreter, accumulating # errors into apm_package_load_errors - array set errors [list] + array set errors {} ad_try { apm_load_any_changed_libraries errors } on error {errorMsg} { @@ -43,7 +43,7 @@ if {[info exists errors($package_key)]} { array set package_errors $errors($package_key) } else { - array set package_errors [list] + array set package_errors {} } foreach file $files { Index: openacs-4/packages/acs-admin/www/auth/authority-parameters.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-admin/www/auth/authority-parameters.tcl,v diff -u -r1.6 -r1.7 --- openacs-4/packages/acs-admin/www/auth/authority-parameters.tcl 7 Aug 2017 23:47:45 -0000 1.6 +++ openacs-4/packages/acs-admin/www/auth/authority-parameters.tcl 25 Apr 2018 19:23:25 -0000 1.7 @@ -15,11 +15,11 @@ # Get the implementation id and implementation pretty name -array set parameters [list] -array set parameter_values [list] +array set parameters {} +array set parameter_values {} # Each element is a list of impl_ids which have this parameter -array set param_impls [list] +array set param_impls {} foreach element_name [auth::authority::get_sc_impl_columns] { set name_column $element_name @@ -47,7 +47,7 @@ # Set focus on first param name set first_param_name [lindex [array names parameters] 0] - set form_widgets [list] + set form_widgets {} foreach parameter_name [array names parameters] { lappend form_widgets [list ${parameter_name}:text,optional [list label $parameter_name] [list help_text $parameters($parameter_name)] {html {size 80}}] } Index: openacs-4/packages/acs-admin/www/install/install.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-admin/www/install/install.tcl,v diff -u -r1.10 -r1.11 --- openacs-4/packages/acs-admin/www/install/install.tcl 27 Mar 2018 11:17:59 -0000 1.10 +++ openacs-4/packages/acs-admin/www/install/install.tcl 25 Apr 2018 19:23:25 -0000 1.11 @@ -55,7 +55,7 @@ apm_get_installed_versions -array installed_versions set upgrades_p 0 -array set package [list] +array set package {} if {$channel eq ""} { set channel $current_channel Index: openacs-4/packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl,v diff -u -r1.41 -r1.42 --- openacs-4/packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl 23 Apr 2018 16:08:29 -0000 1.41 +++ openacs-4/packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl 25 Apr 2018 19:23:25 -0000 1.42 @@ -188,7 +188,7 @@ return $out } - array set params [list] + array set params {} if { [info exists doc_elements(param)] } { foreach param $doc_elements(param) { @@ -215,7 +215,7 @@ # append out "
\"$as_default_value($arg_name)\"
"
# }
@@ -310,7 +310,7 @@
# Initialize the lines variable to hold a list of order line summaries - set lines [list] + set lines {} # Start building the multirow. We add the dynamic column 'lines_pretty', which will # contain the pretty summary of the order lines. @@ -1848,7 +1848,7 @@ set lines_pretty [join $lines ", "] # Reset the lines list, so we start from a fresh with the next row - set lines [list] + set lines {} } else { # There are yet more order lines to come for this order, # continue until we've collected all the order lines @@ -1911,7 +1911,7 @@ # Remember which one (if any) is provided: set lob_argc 0 - set lob_argv [list] + set lob_argv {} set command "dml" if { [info exists clobs] } { set command "clob_dml" @@ -1942,7 +1942,7 @@ db_with_handle -dbn $dbn db { if { $lob_argc == 1 } { # Bind :1, :2, ..., :n as LOBs (where n = [llength $lob_argv]) - set bind_vars [list] + set bind_vars {} for { set i 1 } { $i <= [llength $lob_argv] } { incr i } { lappend bind_vars $i } @@ -2066,7 +2066,7 @@ set selection [db_exec 0or1row $db $full_statement_name $sql] } - set values [list] + set values {} if { $selection ne "" } { for {set i 0} { $i < [ns_set size $selection] } {incr i} { @@ -2864,7 +2864,7 @@ } } - set tables [list] + set tables {} if { [info exists pattern] } { db_foreach -dbn $dbn table_names_with_pattern \ $sql_table_names_with_pattern { @@ -2927,7 +2927,7 @@ @change-log yon@arsdigita.com 20000711 changed to return lower case column names } { - set columns [list] + set columns {} # Works for both Oracle and PostgreSQL: db_foreach -dbn $dbn table_column_names { @@ -2949,7 +2949,7 @@ @author Lars Pind (lars@pinds.com) } { - set columns [list] + set columns {} # Works for both Oracle and PostgreSQL: set n_rows [db_string -dbn $dbn column_exists { @@ -3340,7 +3340,7 @@ upvar bind bind if { [info exists bind] && [llength $bind] != 0 } { if { [llength $bind] == 1 } { - set bind_vars [list] + set bind_vars {} set len [ns_set size $bind] for {set i 0} {$i < $len} {incr i} { lappend bind_vars [ns_set key $bind $i] \ Index: openacs-4/packages/acs-tcl/tcl/admin-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/admin-procs.tcl,v diff -u -r1.25 -r1.26 --- openacs-4/packages/acs-tcl/tcl/admin-procs.tcl 1 Oct 2017 12:16:05 -0000 1.25 +++ openacs-4/packages/acs-tcl/tcl/admin-procs.tcl 25 Apr 2018 19:23:26 -0000 1.26 @@ -55,7 +55,7 @@ Takes an ns_set of key/value pairs and produces a human-readable description of the class of users specified. } { - set clauses [list] + set clauses {} set pretty_description "" # turn all the parameters in the ns_set into Tcl vars @@ -193,7 +193,7 @@ in the user_state finite state machine. If the nohtml switch is set, then a list of lists will be returned (url label). } { - set user_finite_states [list] + set user_finite_states {} switch -- $member_state { "approved" { lappend user_finite_states \ Index: openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl,v diff -u -r1.117 -r1.118 --- openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl 25 Apr 2018 08:46:13 -0000 1.117 +++ openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl 25 Apr 2018 19:23:26 -0000 1.118 @@ -30,7 +30,7 @@ ### Scan for all unregistered .info files. ns_log Notice "apm_scan_packages: Scanning for new unregistered packages..." - set new_spec_files [list] + set new_spec_files {} # Loop through all directories in the /packages directory, searching each for a # .info file. foreach dir [lsort [glob -nocomplain "$path/*"]] { @@ -257,10 +257,10 @@ ## by packages in the install set. ## extra_package_keys - package keys of extra packages to install to satisfy all requirements. - set extra_package_keys [list] + set extra_package_keys {} set updated_p 1 - set install_in [list] + set install_in {} foreach spec_file $spec_files { if { [catch { array set package [apm_read_package_info_file $spec_file] @@ -301,8 +301,8 @@ # Inner loop tries to add another package from the install_pend list while { $updated_p && [info exists install_pend] && $install_pend ne ""} { - set install_in_provides [list] - set new_install_pend [list] + set install_in_provides {} + set new_install_pend {} set updated_p 0 # Generate the list of dependencies currently provided by the install set. foreach pkg_info $install_in { @@ -455,26 +455,26 @@ # 'pending_packages' is an array keyed by package_key with a value of 1 for each package pending installation # When dependencies have been met, the entry will be unset - array set pending_packages [list] + array set pending_packages {} foreach package_key $package_keys { set pending_packages($package_key) 1 } # 'installed_packages' is an array keyed by package_key with a value of 1 for each package # whose dependencies have been met and is ready to be installed - array set installed_packages [list] + array set installed_packages {} # 'provided' will keep track of what we've provided with the currently installed packages # combined with the packages which we're already able to install apm_get_installed_provides -array provided # 'required' will keep track of unsatisfied dependencies # keyed by (service-uri) and will contain the largest version number required - array set required [list] + array set required {} # 'required_by' will keep track of unsatisfied dependencies # keyed by (service-uri) and will contain the largest version number required - array set required_by [list] + array set required_by {} # Just to get us started set updated_p 1 @@ -621,7 +621,7 @@ } else { set result(status) failed - array set failed [list] + array set failed {} # There were problems, now be helpful @@ -710,7 +710,7 @@ return } - set pkg_info_list [list] + set pkg_info_list {} foreach spec_file [glob -nocomplain "$::acs::rootdir/packages/*/*.info"] { # Get package info, and find out if this is a package we should install if { [catch { @@ -1417,7 +1417,7 @@ Prepare the owners data structure for installation. } { - set owners [list] + set owners {} for {set i 0} {$i < [llength $owner_names] } {incr i} { if { [lindex $owner_names $i] ne "" } { lappend owners [list [lindex $owner_names $i] [lindex $owner_uris $i]] @@ -1714,9 +1714,9 @@ } else { lappend types_to_retrieve "data_model_upgrade" } - set data_model_list [list] - set upgrade_file_list [list] - set ctl_file_list [list] + set data_model_list {} + set upgrade_file_list {} + set ctl_file_list {} set file_list [apm_get_package_files -include_data_model_files \ -file_types $types_to_retrieve \ -package_path $package_path \ @@ -1762,7 +1762,7 @@ @param file_list A list of files and file types of form [list [list "foo.sql" "data_model_upgrade"] ...] } { - set query_file_list [list] + set query_file_list {} foreach file $file_list { lassign $file path file_type file_db_type @@ -1967,7 +1967,7 @@ error "The length of spec should be dividable by 3" } - array set chunks [list] + array set chunks {} foreach { elm_from elm_to elm_chunk } $spec { # Check that @@ -2074,7 +2074,7 @@ } # Build a list of packages to install additionally - set version(install) [list] + set version(install) {} foreach node [xml_node_get_children_by_name $package_node install] { set install [apm_attribute_value $node package] lappend version(install) $install @@ -2248,7 +2248,7 @@ # If it is nested we will typically need id's from the parent if {!$nested_p} { array unset ids - array set ids [list] + array set ids {} # set default ids for the main site and core packages set ids(ACS_KERNEL) [apm_package_id_from_key acs-kernel] Index: openacs-4/packages/acs-tcl/tcl/apm-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/apm-procs.tcl,v diff -u -r1.102 -r1.103 --- openacs-4/packages/acs-tcl/tcl/apm-procs.tcl 25 Apr 2018 08:46:13 -0000 1.102 +++ openacs-4/packages/acs-tcl/tcl/apm-procs.tcl 25 Apr 2018 19:23:26 -0000 1.103 @@ -282,22 +282,22 @@ } { array unset ::apm_visited_package_keys - set ::apm_package_url_resolution [list] + set ::apm_package_url_resolution {} apm_package_list_url_resolution $package_key nsv_set apm_package_url_resolution $package_key $::apm_package_url_resolution array unset ::apm_visited_package_keys - set ::apm_package_inherit_order [list] + set ::apm_package_inherit_order {} apm_one_package_inherit_order $package_key nsv_set apm_package_inherit_order $package_key $::apm_package_inherit_order array unset ::apm_visited_package_keys - set ::apm_package_load_libraries_order [list] + set ::apm_package_load_libraries_order {} apm_one_package_load_libraries_dependencies $package_key nsv_set apm_package_load_libraries_order $package_key $::apm_package_load_libraries_order array unset ::apm_visited_package_keys - set ::apm_package_descendents [list] + set ::apm_package_descendents {} apm_one_package_descendents $package_key nsv_set apm_package_descendents $package_key $::apm_package_descendents @@ -371,7 +371,7 @@ @author Peter Marklund } { - set changed_files [list] + set changed_files {} foreach relative_path $file_list { set full_path "$::acs::rootdir/$relative_path" @@ -418,7 +418,7 @@ ns_log notice "apm_mark_version_for_reload try to get package_key from $version_id" set package_key [apm_package_key_from_version_id $version_id] ns_log notice "apm_mark_version_for_reload $package_key $version_id" - set changed_files [list] + set changed_files {} set file_types [list tcl_procs query_file] if { [apm_load_tests_p] } { @@ -509,7 +509,7 @@ to in *all* active interpreters). } { - set file_types [list] + set file_types {} if { $procs_p } { lappend file_types tcl_procs } @@ -528,7 +528,7 @@ } # Scan the package directory for files to source. - set files [list] + set files {} foreach package $packages { set paths [apm_get_package_files -package_key $package -file_types $file_types] @@ -583,7 +583,7 @@ set packages [apm_enabled_packages] } - set packages_to_load [list] + set packages_to_load {} foreach package_key $packages { foreach package_to_load [::apm_package_load_libraries_order $package_key] { if {$package_to_load ni $packages_to_load} { @@ -648,7 +648,7 @@ } # Scan the package directory for files to source. - set files [list] + set files {} foreach package $packages { set files [ad_find_all_files $::acs::rootdir/packages/$package] @@ -697,7 +697,7 @@ Returns a list of subdirectories of path (including path itself) } { - set dirs [list] + set dirs {} lappend dirs $path foreach subdir [glob -nocomplain -type d [file join $path *]] { lappend dirs {*}[apm_subdirs $subdir] @@ -745,7 +745,7 @@ if {$errorVarName ne ""} { upvar $errorVarName errors } else { - array set errors [list] + array set errors {} } # Determine the current reload level in this interpreter by calling @@ -758,7 +758,7 @@ # Check watched files, adding them to files_to_reload if they have # changed. - set files_to_reload [list] + set files_to_reload {} foreach file [nsv_array names apm_reload_watch] { set path "$::acs::rootdir/$file" ns_log Debug "APM: File being watched: $path" @@ -783,7 +783,7 @@ # Keep track of which files we've reloaded in this loop so we never # reload the same one twice. - array set reloaded_files [list] + array set reloaded_files {} while { $reload_level < [nsv_get apm_properties reload_level] } { incr reload_level set changed_reload_level_p 1 @@ -862,7 +862,7 @@ @see db_known_database_types @see apm_package_supports_rdbms_p } { - set supported_databases_list [list] + set supported_databases_list {} foreach db_type_info [db_known_database_types] { set db_type [lindex $db_type_info 0] if { [apm_package_supports_rdbms_p -package_key $package_key] } { @@ -1236,7 +1236,7 @@ } { if {$mounted_p} { - set package_ids [list] + set package_ids {} db_foreach apm_package_ids_from_key { select package_id from apm_packages where package_key = :package_key } { @@ -1497,7 +1497,7 @@ set supported_types [apm_supported_callback_types] - set unused_types [list] + set unused_types {} foreach supported_type $supported_types { if {$supported_type ni $used_callback_types} { lappend unused_types $supported_type Index: openacs-4/packages/acs-tcl/tcl/application-data-link-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/application-data-link-procs.tcl,v diff -u -r1.15 -r1.16 --- openacs-4/packages/acs-tcl/tcl/application-data-link-procs.tcl 21 Mar 2018 08:53:23 -0000 1.15 +++ openacs-4/packages/acs-tcl/tcl/application-data-link-procs.tcl 25 Apr 2018 19:23:26 -0000 1.16 @@ -294,7 +294,7 @@ @creation-date 2006-08-31 } { - set refs [list] + set refs {} set http_url [string trimright [ad_url] /]/ set https_url [string map {http https} $http_url] set re "(?:\")(?:$http_url|$https_url|/)(?:o|image|file)/(\\d{1,8})" @@ -334,7 +334,7 @@ if {![llength $link_object_ids]} { set link_object_ids [application_data_link::scan_for_links -text $text] } - set delete_ids [list] + set delete_ids {} foreach old_link $old_links { if {$old_link ni $link_object_ids} { lappend delete_ids $old_link Index: openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl,v diff -u -r1.68 -r1.69 --- openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl 25 Apr 2018 08:46:13 -0000 1.68 +++ openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl 25 Apr 2018 19:23:26 -0000 1.69 @@ -470,7 +470,7 @@ @author Lars Pind (lars@collaboraid.biz) } { - set cols [list] + set cols {} foreach var { authority_id username screen_name password_question password_answer email_verified_p } { if { [info exists $var] } { lappend cols "$var = :$var" @@ -559,7 +559,7 @@ @author Lars Pind (lars@collaboraid.biz) } { - set cols [list] + set cols {} foreach var { email url } { if { [info exists $var] } { lappend cols "$var = :$var" Index: openacs-4/packages/acs-tcl/tcl/defs-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/defs-procs.tcl,v diff -u -r1.71 -r1.72 --- openacs-4/packages/acs-tcl/tcl/defs-procs.tcl 3 Mar 2018 16:51:35 -0000 1.71 +++ openacs-4/packages/acs-tcl/tcl/defs-procs.tcl 25 Apr 2018 19:23:26 -0000 1.72 @@ -358,7 +358,7 @@ @author Unknown @author Roberto Mello } { - set lines [list] + set lines {} if { $line2 eq "" } { lappend lines $line1 } elseif { $line1 eq "" } { Index: openacs-4/packages/acs-tcl/tcl/form-processing-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/form-processing-procs.tcl,v diff -u -r1.73 -r1.74 --- openacs-4/packages/acs-tcl/tcl/form-processing-procs.tcl 4 Apr 2018 18:51:56 -0000 1.73 +++ openacs-4/packages/acs-tcl/tcl/form-processing-procs.tcl 25 Apr 2018 19:23:26 -0000 1.74 @@ -582,7 +582,7 @@ global af_element_names if { !$extend_p } { - set af_element_names($form_name) [list] + set af_element_names($form_name) {} } global af_parts @@ -630,8 +630,8 @@ # Track element names and their parameters locally as we'll generate those in this form # or extend block on the fly - set element_names [list] - array set af_element_parameters [list] + set element_names {} + array set af_element_parameters {} if { [info exists form] } { @@ -654,11 +654,11 @@ lappend af_element_names($form_name) $element_name set af_extra_args($element_name) [lrange $element 1 end] set pre_flag_list [split [string tolower $flags] ,] - set af_flag_list(${form_name}__$element_name) [list] + set af_flag_list(${form_name}__$element_name) {} # find parameterized flags. We only allow one parameter. foreach flag $pre_flag_list { - set af_element_parameters($element_name:$flag) [list] + set af_element_parameters($element_name:$flag) {} set left_paren [string first "(" $flag] if { $left_paren != -1 } { if { [string index $flag end] ne ")" } { @@ -683,7 +683,7 @@ global af_validate_elements if { !$extend_p } { - set af_validate_elements($form_name) [list] + set af_validate_elements($form_name) {} } if { [info exists validate] } { @@ -1214,7 +1214,7 @@ # Pass the form variables to the confirm template, applying the to_html filter if present - set args [list] + set args {} foreach element_name $af_element_names($form_name) { if { [llength $element_name] == 1 } { if { [info exists af_to_html(${form_name}__$element_name)] } { Index: openacs-4/packages/acs-tcl/tcl/html-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/html-procs.tcl,v diff -u -r1.3 -r1.4 --- openacs-4/packages/acs-tcl/tcl/html-procs.tcl 1 Oct 2017 12:16:05 -0000 1.3 +++ openacs-4/packages/acs-tcl/tcl/html-procs.tcl 25 Apr 2018 19:23:26 -0000 1.4 @@ -38,19 +38,19 @@ dom parse -html -keepEmpties $html doc set root [$doc documentElement] - set forms [list] + set forms {} # Get every form... foreach f [$root selectNodes {//form}] { set form [list "attributes" [util::get_node_attributes -node $f]] - set fields [list] + set fields {} # ...every input tag foreach input [$f selectNodes {//input}] { lappend fields [list tag "input" attributes [util::get_node_attributes -node $input]] } # ...every select tag with its options foreach select [$f selectNodes {//select}] { set field [list tag "select" attributes [util::get_node_attributes -node $select]] - set options [list] + set options {} foreach option [$f selectNodes {option}] { lappend options [list attributes [$option attributes] value [$option nodeValue]] } @@ -148,7 +148,7 @@ } # Now vars must be translated in export_vars form - set vars [list] + set vars {} foreach {name value} [array get v] { # Multiple values must be specified # with the :multiple modifier Index: openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl,v diff -u -r1.12 -r1.13 --- openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl 27 Mar 2018 11:18:00 -0000 1.12 +++ openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl 25 Apr 2018 19:23:26 -0000 1.13 @@ -42,7 +42,7 @@ if {$headers eq ""} { set headers [ns_set create headers] } - set cookies [list] + set cookies {} foreach {name value} $resp_headers { # get only set-cookie headers, ignoring case set name [string tolower $name] @@ -258,8 +258,8 @@ } { Obtains implemented apis for http communication } { - set http [list] - set https [list] + set http {} + set https {} if {[util::which curl] ne ""} { lappend http "curl" lappend https "curl" @@ -1009,7 +1009,7 @@ # set this_proc ::util::http::request - set urlvars [list] + set urlvars {} # ...retrieve redirect location variables... set locvars [lindex [split $location ?] 1] Index: openacs-4/packages/acs-tcl/tcl/install-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/install-procs.tcl,v diff -u -r1.32 -r1.33 --- openacs-4/packages/acs-tcl/tcl/install-procs.tcl 25 Apr 2018 08:46:13 -0000 1.32 +++ openacs-4/packages/acs-tcl/tcl/install-procs.tcl 25 Apr 2018 19:23:26 -0000 1.33 @@ -110,7 +110,7 @@ set context_id [apm_attribute_value -default "" $node context-id] set security_inherit_p [apm_attribute_value -default "t" $node security-inherit-p] - set out [list] + set out {} # Remove double slashes regsub -all {//} $mount_point "/" mount_point @@ -194,7 +194,7 @@ set package_key [apm_attribute_value -default "" $node package-key] set mount_point [apm_attribute_value -default "" $node mount-point] - set out [list] + set out {} # Remove double slashes regsub -all {//} $mount_point "/" mount_point Index: openacs-4/packages/acs-tcl/tcl/navigation-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/navigation-procs.tcl,v diff -u -r1.38 -r1.39 --- openacs-4/packages/acs-tcl/tcl/navigation-procs.tcl 6 Apr 2018 15:40:36 -0000 1.38 +++ openacs-4/packages/acs-tcl/tcl/navigation-procs.tcl 25 Apr 2018 19:23:26 -0000 1.39 @@ -60,7 +60,7 @@ @author Peter Marklund } { - set context [list] + set context {} while { $node_id ne "" } { array set node [site_node::get -node_id $node_id] @@ -234,7 +234,7 @@ } { set count 0 - set return_list [list] + set return_list {} foreach value $values { if { $default eq $value } { @@ -274,7 +274,7 @@ # directories that should not receive links to move up one level proc ad_no_uplevel_patterns {} { - set regexp_patterns [list] + set regexp_patterns {} lappend regexp_patterns "*/pvt/home.tcl" # Tcl files in the root directory lappend regexp_patterns "^/\[^/\]*\.tcl\$" Index: openacs-4/packages/acs-tcl/tcl/request-processor-init.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/request-processor-init.tcl,v diff -u -r1.19 -r1.20 --- openacs-4/packages/acs-tcl/tcl/request-processor-init.tcl 1 Oct 2017 12:16:05 -0000 1.19 +++ openacs-4/packages/acs-tcl/tcl/request-processor-init.tcl 25 Apr 2018 19:23:26 -0000 1.20 @@ -116,7 +116,7 @@ if {[nsv_exists rp_filters .]} { set filters [nsv_get rp_filters .] } else { - set filters [list] + set filters {} } # This lsort is what makes the priority stuff work. It guarantees # that filters are registered in order of priority. AOLServer will @@ -159,7 +159,7 @@ if {[nsv_exists rp_registered_procs .]} { set procs [nsv_get rp_registered_procs .] } else { - set procs [list] + set procs {} } set proc_index 0 Index: openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl,v diff -u -r1.134 -r1.135 --- openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl 25 Apr 2018 08:47:56 -0000 1.134 +++ openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl 25 Apr 2018 19:23:26 -0000 1.135 @@ -863,7 +863,7 @@ ds_add conn error $message - set params [list] + set params {} #Serve the stacktrace set params [list [list stacktrace $message] \ @@ -913,7 +913,7 @@ } set components [split $path "/"] - set prefixes [list] + set prefixes {} for {set i [expr {[llength $components] -1}]} {$i > 0} {incr i -1} { lappend prefixes "[join [lrange $components 0 $i] /]/" lappend prefixes [join [lrange $components 0 $i] /] @@ -1675,9 +1675,9 @@ if { [apm_first_time_loading_p] } { # Initialize nsv_sets - nsv_array set rp_filters [list] - nsv_array set rp_registered_procs [list] - nsv_array set rp_extension_handlers [list] + nsv_array set rp_filters {} + nsv_array set rp_registered_procs {} + nsv_array set rp_extension_handlers {} # The following stuff is in a -procs.tcl file rather than a # -init.tcl file since we want it done really early in the startup Index: openacs-4/packages/acs-tcl/tcl/security-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/security-procs.tcl,v diff -u -r1.90 -r1.91 --- openacs-4/packages/acs-tcl/tcl/security-procs.tcl 29 Mar 2018 08:09:04 -0000 1.90 +++ openacs-4/packages/acs-tcl/tcl/security-procs.tcl 25 Apr 2018 19:23:26 -0000 1.91 @@ -1326,7 +1326,7 @@ # we assume sample size of 10%. set num_tokens [expr {$num_tokens * 10}] set counter 0 - set list_of_tokens [list] + set list_of_tokens {} # the best thing to use here would be an array_dml, except # that an array_dml makes it hard to use sysdate and sequences. @@ -1941,7 +1941,7 @@ @return insecure location and secure location followed possibly by alternate location(s) as a list. } { - set locations [list] + set locations {} set portless_locations {} # # Get Information from configured servers Index: openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl,v diff -u -r1.105 -r1.106 --- openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl 9 Apr 2018 21:20:16 -0000 1.105 +++ openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl 25 Apr 2018 19:23:26 -0000 1.106 @@ -448,7 +448,7 @@ set query_name select_site_node } - set cur_obj_ids [list] + set cur_obj_ids {} db_foreach $query_name {} { if {$parent_id eq ""} { # url of root node @@ -625,9 +625,9 @@ Return a list of site node info associated with the given object_id. The nodes will be ordered descendingly by url (children before their parents). } { - set node_id_list [list] + set node_id_list {} - set url_list [list] + set url_list {} foreach url [get_url_from_object_id -object_id $object_id] { lappend node_id_list [get -url $url] } @@ -726,7 +726,7 @@ } { @return the ancestors of this node } { - set result [list] + set result {} set array_result_p [string equal $element ""] while {$node_id ne "" } { @@ -803,7 +803,7 @@ set node_url [site_node::get_url -node_id $node_id] if { !$all_p } { - set child_urls [list] + set child_urls {} set s [string length "$node_url"] # find all child_urls who have only one path element below node_id # by clipping the node url and last character and seeing if there @@ -819,7 +819,7 @@ if { [llength $filters] > 0 } { - set return_val [list] + set return_val {} foreach child_url $child_urls { array unset site_node if {![catch {array set site_node [nsv_get site_nodes $child_url]}]} { @@ -847,7 +847,7 @@ } } } elseif { $element ne "" } { - set return_val [list] + set return_val {} foreach child_url $child_urls { array unset site_node if {![catch {array set site_node [nsv_get site_nodes $child_url]}]} { @@ -1357,7 +1357,7 @@ } if { [llength $filters] > 0 } { - set return_val [list] + set return_val {} foreach child_url $child_urls { array unset site_node if {![catch {array set site_node [:get -url $child_url]}]} { @@ -1379,7 +1379,7 @@ } } } elseif { $element ne "" } { - set return_val [list] + set return_val {} foreach child_url $child_urls { array unset site_node if {![catch {array set site_node [:get -url $child_url]}]} { Index: openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl,v diff -u -r1.49 -r1.50 --- openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl 23 Apr 2018 07:17:58 -0000 1.49 +++ openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl 25 Apr 2018 19:23:26 -0000 1.50 @@ -63,8 +63,8 @@ @author Lars Pind (lars@pinds.com) @creation-date 24 July 2000 } { - set ::ad_page_contract_complaints [list] - set ::ad_page_contract_errorkeys [list] + set ::ad_page_contract_complaints {} + set ::ad_page_contract_errorkeys {} set ::ad_page_contract_context $context } @@ -136,7 +136,7 @@ @author Lars Pind (lars@pinds.com) @creation-date 25 July 2000 } { - array set ::ad_page_contract_error_string [list] + array set ::ad_page_contract_error_string {} foreach { errorkeys text } $errorstrings { foreach errorkey $errorkeys { @@ -541,7 +541,7 @@ if { [llength $args] == 0 } { - set query [list] + set query {} } else { set valid_args { validate errors return_errors properties } ;# add type later @@ -553,7 +553,7 @@ } else { # otherwise, accept a -query argument lappend valid_args query - set query [list] + set query {} } ad_arg_parser $valid_args $args @@ -599,16 +599,16 @@ # array apc_flags($name): contains a list of the flags that apply # - set apc_formals [list] - array set apc_formal [list] - array set apc_default_value [list] + set apc_formals {} + array set apc_formal {} + array set apc_default_value {} - array set apc_internal_filter [list] - array set apc_filters [list] - array set apc_post_filters [list] - array set apc_filter_parameters [list] + array set apc_internal_filter {} + array set apc_filters {} + array set apc_post_filters {} + array set apc_filter_parameters {} - array set apc_flags [list] + array set apc_flags {} foreach element $query { set element_len [llength $element] @@ -631,7 +631,7 @@ } set pre_flag_list [split [string tolower $flags] ,] - set flag_list [list] + set flag_list {} # find parameterized flags foreach flag $pre_flag_list { @@ -664,7 +664,7 @@ # Sort the flag list according to priority # - set flag_list_for_sorting [list] + set flag_list_for_sorting {} foreach flag $flag_list { lappend flag_list_for_sorting [list [ad_page_contract_filter_priority $flag] $flag] } @@ -676,9 +676,9 @@ # apc_flags($name) is for documentation only. # - set apc_flags($name) [list] - set apc_filters($name) [list] - set apc_post_filters($name) [list] + set apc_flags($name) {} + set apc_filters($name) {} + set apc_post_filters($name) {} foreach flag_entry $flag_list_sorted { set flag [lindex $flag_entry 1] @@ -769,10 +769,10 @@ # for the validation block. Once the block has executed, this entry # self destructs, i.e. unset apc_validation_blocks($name) - array set apc_validation_blocks [list] + array set apc_validation_blocks {} if { ![info exists validate] } { - set validate [list] + set validate {} } set validate_len [llength $validate] @@ -812,7 +812,7 @@ } incr i } else { - set requires [list] + set requires {} } set code [lindex $validate $i] set apc_validation_blocks($name) [list $requires $code] @@ -846,7 +846,7 @@ # This is the array in which we store the signature variables as we come across them # Whenever we see a variable named foo:sig, we record it here as apc_signatures(foo). - array set apc_signatures [list] + array set apc_signatures {} for { set form_counter_i 0 } { $form_counter_i < $form_size } { incr form_counter_i } { Index: openacs-4/packages/acs-tcl/tcl/util-diff-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/util-diff-procs.tcl,v diff -u -r1.5 -r1.6 --- openacs-4/packages/acs-tcl/tcl/util-diff-procs.tcl 7 Aug 2017 23:48:00 -0000 1.5 +++ openacs-4/packages/acs-tcl/tcl/util-diff-procs.tcl 25 Apr 2018 19:23:26 -0000 1.6 @@ -115,7 +115,7 @@ package require struct::list set frag $old - set old_list [list] + set old_list {} while {$frag ne ""} { if {![regexp "(\[^<]*)(<(/?)(\[^ \r\n\t>]+)(\[^>]*)>)?(.*)" $frag match pretag fulltag close tag tagbody frag]} { # we should never get here, the regexp should match anything @@ -126,7 +126,7 @@ } if {$pretag ne ""} { set pretag [string map {\n " "} $pretag] - set pretag2 [list] + set pretag2 {} foreach element [split $pretag " "] { if {[string trim $element] ne ""} { lappend pretag2 [string trim $element] @@ -142,7 +142,7 @@ } set frag $new - set new_list [list] + set new_list {} while {$frag ne ""} { if {![regexp "(\[^<]*)(<(/?)(\[^ \r\n\t>]+)(\[^>]*)>)?(.*)" $frag match pretag fulltag close tag tagbody frag]} { # we should never get here, the regexp should match anything @@ -152,7 +152,7 @@ } if {$pretag ne ""} { set pretag [string map {\n " "} $pretag] - set pretag2 [list] + set pretag2 {} foreach element [split $pretag " "] { if {[string trim $element] ne ""} { lappend pretag2 [string trim $element] Index: openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl,v diff -u -r1.154 -r1.155 --- openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl 9 Apr 2018 20:11:54 -0000 1.154 +++ openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl 25 Apr 2018 19:23:26 -0000 1.155 @@ -70,7 +70,7 @@ # To avoid having the full path of the file included in the archive, # we must first cd to the source directory. zip doesn't have an option # to do this without building a little script... - set zip_cmd [list] + set zip_cmd {} lappend zip_cmd "cd $in_path" lappend zip_cmd "${zip} -r \"${destination}\" \"${filename}\"" set zip_cmd [join $zip_cmd " && "] @@ -681,7 +681,7 @@ # 'noprocessing_vars' is yet another container of variables, # only this one doesn't have the values subst'ed # and we don't try to find :multiple and :array flags in the namespec - set noprocessing_vars [list] + set noprocessing_vars {} if { $entire_form_p } { set the_form [ns_getform] @@ -705,13 +705,13 @@ # 2. if they're in vars, but not in exclude or override, use those # There'll always be an entry here if the variable is to be exported - array set exp_precedence_type [list] + array set exp_precedence_type {} # This contains entries of the form exp_flag(name:flag) e.g., exp_flag(foo:multiple) - array set exp_flag [list] + array set exp_flag {} # This contains the value if provided, otherwise we'll pull it out of the caller's environment - array set exp_value [list] + array set exp_value {} foreach precedence_type { override exclude vars noprocessing_vars } { foreach var_spec [set $precedence_type] { @@ -767,7 +767,7 @@ if { [array exists upvar_variable] } { if { $no_empty_p } { # If the no_empty_p flag is set, remove empty string values first - set exp_value($name) [list] + set exp_value($name) {} foreach { key value } [array get upvar_variable] { if { $value ne "" } { lappend exp_value($name) $key $value @@ -788,7 +788,7 @@ # no_empty_p flag set, remove empty strings if { [info exists exp_flag($name:multiple)] } { # This is a list, remove empty entries - set exp_value($name) [list] + set exp_value($name) {} foreach elm $upvar_variable { if { $elm ne "" } { lappend exp_value($name) $elm @@ -871,7 +871,7 @@ set export_string {} if { $url_p } { - set export_list [list] + set export_list {} for { set i 0 } { $i < $export_size } { incr i } { lappend export_list [ad_urlencode_query [ns_set key $export_set $i]]=[ad_urlencode_query [ns_set value $export_set $i]] } @@ -985,7 +985,7 @@ set setid [ns_getform] } - set return_list [list] + set return_list {} if { $setid ne "" } { set set_size [ns_set size $setid] set set_counter_i 0 @@ -1022,7 +1022,7 @@ @see export_vars } { - set params [list] + set params {} set the_form [ns_getform] if { $the_form ne "" } { for {set i 0} {$i<[ns_set size $the_form]} {incr i} { @@ -1422,7 +1422,7 @@ nsv_set ad_procs . $procs ns_mutex unlock [nsv_get ad_procs mutex] - set my_args [list] + set my_args {} if { $thread == "t" } { lappend my_args "-thread" } @@ -2219,7 +2219,7 @@ return [list] } - set sorted_list1 [list] + set sorted_list1 {} foreach elm [lsort $list1] { if { [llength $sorted_list1] == 0 || [lindex $sorted_list1 end] ne $elm } { lappend sorted_list1 $elm @@ -2230,7 +2230,7 @@ set len1 [llength $sorted_list1] set len2 [llength $sorted_list2] - set missing_elms [list] + set missing_elms {} # Loop over list1 and list2 in sort order, comparing the elements @@ -2326,7 +2326,7 @@ @author Lars Pind (lars@pinds.com) } { - set keys [list] + set keys {} set size [ns_set size $set_id] for { set i 0 } { $i < $size } { incr i } { set key [ns_set key $set_id $i] @@ -2671,7 +2671,7 @@ @return An array of equivalent keys and values as the ns_set specified. } { - set result [list] + set result {} for {set i 0} {$i < [ns_set size $set]} {incr i} { lappend result [ns_set key $set $i] @@ -2733,7 +2733,7 @@ @author Ola Hansson (ola@polyxena.net) @creation-date September 27, 2002 } { - set result [list] + set result {} foreach ns_set $list_of_ns_sets { lappend result [util_ns_set_to_list -set $ns_set] @@ -3344,7 +3344,7 @@ Returns a random permutation of the list. } { set len [llength $list] - set result [list] + set result {} while { [llength $list] > 0 } { set index [randomRange [expr {[llength $list] - 1}]] lappend result [lindex $list $index] @@ -3594,11 +3594,11 @@ @return list of lists (filename and full_path) of all files found. } { # Use the examined_files array to track files that we've examined. - array set examined_files [list] + array set examined_files {} # A list of files that we will return (in the order in which we # examined them). - set files [list] + set files {} # A list of files that we still need to examine. set files_to_examine [list $path] @@ -3608,7 +3608,7 @@ # add contained files to $new_files_to_examine (which will become # $files_to_examine in the next iteration). while { [incr max_depth -1] > -2 && [llength $files_to_examine] != 0 } { - set new_files_to_examine [list] + set new_files_to_examine {} foreach file $files_to_examine { # Only examine the file if we haven't already. (This is just a safeguard # in case, e.g., Tcl decides to play funny games with symbolic links so Index: openacs-4/packages/acs-tcl/tcl/whos-online-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/whos-online-procs.tcl,v diff -u -r1.5 -r1.6 --- openacs-4/packages/acs-tcl/tcl/whos-online-procs.tcl 7 Aug 2017 23:48:00 -0000 1.5 +++ openacs-4/packages/acs-tcl/tcl/whos-online-procs.tcl 25 Apr 2018 19:23:26 -0000 1.6 @@ -32,7 +32,7 @@ @author Bjoern Kiesbye } { array set last_hit [nsv_array get last_hit] - set onliners_out [list] + set onliners_out {} set interval 1 set oldtime [expr {[ns_time] - [interval]}] @@ -135,7 +135,7 @@ @author Bjoern Kiesbye } { array set last_hit [nsv_array get last_hit] - set onliners [list] + set onliners {} set oldtime [expr {[ns_time] - [interval]}] for { set search [array startsearch last_hit] } { [array anymore last_hit $search] } {} { Index: openacs-4/packages/acs-tcl/tcl/test/file-test-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/test/file-test-procs.tcl,v diff -u -r1.11 -r1.12 --- openacs-4/packages/acs-tcl/tcl/test/file-test-procs.tcl 7 Aug 2017 23:48:00 -0000 1.11 +++ openacs-4/packages/acs-tcl/tcl/test/file-test-procs.tcl 25 Apr 2018 19:23:26 -0000 1.12 @@ -138,7 +138,7 @@ # build list of files for each db type, sort, check strict ordering. foreach db_type {postgresql oracle} { - set upgrades [list] + set upgrades {} foreach file $files { # DRB: Ignore old upgrade scripts that aren't in the proper place. We # still have old ACS 3 -> ACS 4 upgrade scripts lying around, and Index: openacs-4/packages/acs-templating/tcl/date-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-templating/tcl/date-procs.tcl,v diff -u -r1.55 -r1.56 --- openacs-4/packages/acs-templating/tcl/date-procs.tcl 7 Apr 2018 19:37:20 -0000 1.55 +++ openacs-4/packages/acs-templating/tcl/date-procs.tcl 25 Apr 2018 19:23:26 -0000 1.56 @@ -143,7 +143,7 @@ } { set now [clock format [clock seconds] -format "%Y %m %d"] - set today [list] + set today {} foreach v $now { # trim leading zeros to avoid octal problem @@ -157,7 +157,7 @@ Create a new Date object for the current date and time } { set now [clock format [clock seconds] -format "%Y %m %d %H %M %S"] - set today [list] + set today {} foreach v $now { lappend today [util::trim_leading_zeros $v] @@ -340,7 +340,7 @@ # Return a date in format "YYYY MM DD HH24 MI SS" # For use with karl's non-working form builder API set clipped_date [lrange $date 0 5] - set ret [list] + set ret {} set pad "0000" foreach fragment $clipped_date { lappend ret "[string range $pad [string length $fragment] end]$fragment" @@ -351,7 +351,7 @@ linear_date_no_time { # Return a date in format "YYYY MM DD" set clipped_date [lrange $date 0 2] - set ret [list] + set ret {} set pad "0000" foreach fragment $clipped_date { lappend ret "[string range $pad [string length $fragment] end]$fragment" @@ -367,7 +367,7 @@ # not a terribly efficient thing to do. set clipped_date [lrange $date 0 2] - set date_list [list] + set date_list {} set pad "0000" foreach fragment $clipped_date { lappend date_list "[string range $pad [string length $fragment] end]$fragment" @@ -489,7 +489,7 @@ } clock { set old_date [clock format $value -format "%Y %m %d %H %M %S"] - set new_date [list] + set new_date {} foreach field $old_date { lappend new_date [util::trim_leading_zeros $field] } @@ -498,7 +498,7 @@ } sql_date { set old_format [lindex $date 6] - set new_date [list] + set new_date {} foreach fragment $value { lappend new_date [util::trim_leading_zeros $fragment] } @@ -568,7 +568,7 @@ @author Walter McGinnis (wtem@olywa.net) @creation-date 2002-01-06 } { - set now [list] + set now {} foreach v [clock format [clock seconds] -format "%Y %m %d %H %M %S"] { lappend now [util::trim_leading_zeros $v] } @@ -603,7 +603,7 @@ @author Walter McGinnis (wtem@olywa.net) @creation-date 2002-01-06 } { - set now [list] + set now {} foreach v [clock format [clock seconds] -format "%Y %m %d %H %M %S"] { lappend now [util::trim_leading_zeros $v] } @@ -727,7 +727,7 @@ unpack $date - set error_msg [list] + set error_msg {} foreach {field exp} { year "YYYY|YY" month "MM|MON|MONTH" day "DD" hours "HH24|HH12" minutes "MI" seconds "SS" } { @@ -1036,7 +1036,7 @@ # of tokens set format_string $element(format) - set tokens [list] + set tokens {} if {[info exists attributes(id)]} { set id_attr_name $attributes(id) Index: openacs-4/packages/acs-templating/tcl/doc-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-templating/tcl/doc-procs.tcl,v diff -u -r1.9 -r1.10 --- openacs-4/packages/acs-templating/tcl/doc-procs.tcl 23 Apr 2018 18:24:56 -0000 1.9 +++ openacs-4/packages/acs-templating/tcl/doc-procs.tcl 25 Apr 2018 19:23:26 -0000 1.10 @@ -38,7 +38,7 @@ # regular expression for match directive comments set direxp {^\#[\s]*@([a-zA-Z0-9\-_]+)[\s]+(.*)$} - set directives [list] + set directives {} foreach line $lines { Index: openacs-4/packages/acs-templating/tcl/doc-tcl-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-templating/tcl/doc-tcl-procs.tcl,v diff -u -r1.14 -r1.15 --- openacs-4/packages/acs-templating/tcl/doc-tcl-procs.tcl 4 Apr 2018 18:51:56 -0000 1.14 +++ openacs-4/packages/acs-templating/tcl/doc-tcl-procs.tcl 25 Apr 2018 19:23:26 -0000 1.15 @@ -90,7 +90,7 @@ @see doc::util::text_divider } { - set indices_list [list] + set indices_list {} set last_index -1 while { [regexp -indices $marker $text marker_idx] } { @@ -119,7 +119,7 @@ upvar $text_ref text set indices_list [doc::util::find_marker_indices $text $marker] - set result_list [list] + set result_list {} # first check for no markers present if { $indices_list eq "end" } { @@ -289,9 +289,9 @@ # if we wanted to include the source text for the procedure as well: # set proc_info [list [list proc_name $proc_name] [list source $source_text]] - set proc_param [list] - set proc_option [list] - set proc_see [list] + set proc_param {} + set proc_option {} + set proc_see {} set directives [lsort -index 0 [template::parse_directives $comment_text]] @@ -566,9 +566,9 @@ # with respect to namespaces in the same order as the list result upvar namespace_list namespace_list - set namespace_list [list] + set namespace_list {} - set result [list] + set result {} foreach dir $dir_list { Index: openacs-4/packages/acs-templating/tcl/element-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-templating/tcl/element-procs.tcl,v diff -u -r1.34 -r1.35 --- openacs-4/packages/acs-templating/tcl/element-procs.tcl 7 Aug 2017 23:48:01 -0000 1.34 +++ openacs-4/packages/acs-templating/tcl/element-procs.tcl 25 Apr 2018 19:23:26 -0000 1.35 @@ -431,7 +431,7 @@ # if the element is optional and the value is an empty string, then ignore if { $is_optional && [lindex $values 0] eq "" } { - set values [list] + set values {} # also clobber the value(s) for a submit widget if {$element(widget) eq "submit"} { @@ -487,10 +487,10 @@ } else { - set element(validate) [list] + set element(validate) {} } - set v_errors [list] + set v_errors {} foreach value $values { @@ -605,7 +605,7 @@ set values [ns_querygetall $element(id)] # QUIRK: ns_querygetall returns a single-element list {{}} for no values - if { [string equal $values {{}}] } { set values [list] } + if { [string equal $values {{}}] } { set values {} } } else { set values [template::data::transform::$datatype element] @@ -758,7 +758,7 @@ # breaks eg ad_form. # if { [string equal opts(value) {}] } { - set opts(values) [list] + set opts(values) {} } else { set opts(values) [list $opts(value)] } Index: openacs-4/packages/acs-templating/tcl/form-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-templating/tcl/form-procs.tcl,v diff -u -r1.48 -r1.49 --- openacs-4/packages/acs-templating/tcl/form-procs.tcl 9 Apr 2018 18:58:32 -0000 1.48 +++ openacs-4/packages/acs-templating/tcl/form-procs.tcl 25 Apr 2018 19:23:26 -0000 1.49 @@ -141,7 +141,7 @@ template::util::get_opts $args - set elements [list] + set elements {} # check whether this form is being submitted upvar #$level $id:submission submission @@ -785,7 +785,7 @@ set elements $properties(element_names) if { $no_api_p } { - set elements_no_api [list] + set elements_no_api {} foreach element $elements { if { ![regexp {^__} $element] } { lappend elements_no_api $element @@ -830,7 +830,7 @@ get_reference set exp [join $args "|"] - set values [list] + set values {} foreach element_name $properties(element_names) { if { [regexp $exp $element_name match] } { Index: openacs-4/packages/acs-templating/tcl/list-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-templating/tcl/list-procs.tcl,v diff -u -r1.77 -r1.78 --- openacs-4/packages/acs-templating/tcl/list-procs.tcl 25 Apr 2018 08:42:17 -0000 1.77 +++ openacs-4/packages/acs-templating/tcl/list-procs.tcl 25 Apr 2018 19:23:26 -0000 1.78 @@ -750,7 +750,7 @@ if { [llength $list_properties(from_clauses)] == 0 } { return {} } - set trimmed_from_clauses [list] + set trimmed_from_clauses {} set result {} @@ -911,9 +911,9 @@ set __groupby $list_properties(groupby) # Output header row - set __cols [list] - set __csv_cols [list] - set __csv_labels [list] + set __cols {} + set __csv_cols {} + set __csv_labels {} foreach __element_name $list_properties(elements) { template::list::element::get_reference -list_name $name -element_name $__element_name @@ -943,7 +943,7 @@ } if {$__groupby eq "" || $group_lastnum_p} { - set __cols [list] + set __cols {} foreach __element_name $__csv_cols { if {![string match "*___*_group" $__element_name]} { @@ -993,7 +993,7 @@ if { [llength $ids] == 0 } { return NULL } - set quoted_ids [list] + set quoted_ids {} foreach one_id $ids { lappend quoted_ids "'[DoubleApos $one_id]'" } @@ -1093,7 +1093,7 @@ template::list::orderby::get_reference -list_name $name -orderby_name $list_properties(orderby_selected_name) - set result [list] + set result {} if {$list_properties(orderby_selected_direction) eq "desc"} { lappend result "-decreasing" } @@ -1411,7 +1411,7 @@ # However, for now, it's just commented out with an if 0 ... block. if 0 { set num_pages 11 - set pages [list] + set pages {} for { set i [expr {$current_page - $num_pages}] } { $i < $current_page + $num_pages } { incr i } { if { $i > 0 && $i <= $paginator(page_count) } { lappend pages $i @@ -1580,7 +1580,7 @@ get_reference -name $name if {[info exists filter_names]} { - set filter_refs [list] + set filter_refs {} foreach filter_name $filter_names { lappend filter_refs ${name}:filter:${filter_name}:properties } @@ -2113,7 +2113,7 @@ # Create the orderby filter, if specified if { $element_properties(orderby) ne "" || $element_properties(orderby_asc) ne "" || $element_properties(orderby_desc) ne "" } { - set orderby_spec [list] + set orderby_spec {} foreach elm { orderby orderby_asc orderby_desc default_direction label } { if { $element_properties($elm) ne "" } { lappend orderby_spec $elm $element_properties($elm) @@ -3200,15 +3200,15 @@ # Get an upvar'd reference to list_properties get_reference -name $name - set filter_names_options_tmp [list] - set filter_names_options [list] - set filter_hidden_filters [list] - set filter_key_filters [list] + set filter_names_options_tmp {} + set filter_names_options {} + set filter_hidden_filters {} + set filter_key_filters {} set filter_exclude_from_key [list orderby groupby format page __list_view] if {[llength $filter_exclude_from_key_extra]} { set filter_exclude_from_key [concat $filter_exclude_from_key $filter_exclude_from_key_extra] } - set filter_hidden_filters_url_vars [list] + set filter_hidden_filters_url_vars {} # loop through all the filters in this list foreach filter_ref $list_properties(filter_refs) { upvar #$level $filter_ref filter_properties @@ -3280,7 +3280,7 @@ # the filter from the client property if its # specified in clear_one set __old_client_property_filters [ad_get_client_property acs-templating $__list_filter_form_client_property_key] - set __client_property_filters [list] + set __client_property_filters {} foreach {__ref __value} $__old_client_property_filters { if {[set ${__ref}(name)] ne $clear_one} { @@ -3351,7 +3351,7 @@ } if {![template::element::exists $filters_form_name $filter_properties(name)]} { # extract options - set options [list] + set options {} foreach \ elm $filter_properties(values) \ @@ -3414,7 +3414,7 @@ # still has to process the values to generate a valid # where clause template::list::get_reference -name $name - set templist [list] + set templist {} foreach {f_ref f_value} $__client_property_filters { upvar \#[template::adp_level] $f_ref filter_properties set filter_properties(value) [set $filter_properties(name)] Index: openacs-4/packages/acs-templating/tcl/paginator-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-templating/tcl/paginator-procs.tcl,v diff -u -r1.27 -r1.28 --- openacs-4/packages/acs-templating/tcl/paginator-procs.tcl 7 Apr 2018 19:37:20 -0000 1.27 +++ openacs-4/packages/acs-templating/tcl/paginator-procs.tcl 25 Apr 2018 19:23:26 -0000 1.28 @@ -192,7 +192,7 @@ # perform the query in the calling scope so bind variables have effect upvar 2 __paginator_ids ids - set ids [list] + set ids {} set full_statement_name [uplevel 2 "db_qd_get_fullname $statement_name"] @@ -260,7 +260,7 @@ set i 0 set page_size $properties(pagesize) - set context_ids [list] + set context_ids {} set row_ids "" foreach row $ids { @@ -463,7 +463,7 @@ if { $end > $page_count } { set end $page_count } - set pages [list] + set pages {} for { set i $start } { $i <= $end } { incr i } { lappend pages $i @@ -504,7 +504,7 @@ if { $end > $page_count } { set end $page_count) } - set pages [list] + set pages {} for { set i $start } { $i <= $end } { incr i $group_size } { lappend pages $i @@ -750,7 +750,7 @@ # DEDS: quote the ids so that we are not # necessarily limited to integer keys - set quoted_ids [list] + set quoted_ids {} foreach one_id $ids { lappend quoted_ids "'[DoubleApos $one_id]'" } Index: openacs-4/packages/acs-templating/tcl/query-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-templating/tcl/query-procs.tcl,v diff -u -r1.42 -r1.43 --- openacs-4/packages/acs-templating/tcl/query-procs.tcl 25 Apr 2018 08:42:17 -0000 1.42 +++ openacs-4/packages/acs-templating/tcl/query-procs.tcl 25 Apr 2018 19:23:26 -0000 1.43 @@ -341,7 +341,7 @@ } # build the values on which to group - set group_values [list] + set group_values {} foreach group $groups { lappend group_values [ns_set get $row $group] } @@ -671,7 +671,7 @@ pop { upvar $multirow_level_up $name:rowcount rowcount $name:columns columns - set r_list [list] + set r_list {} if {$rowcount > 0} { upvar $multirow_level_up $name:$rowcount row for { set i 0 } { $i < [llength $columns] } { incr i } { @@ -918,7 +918,7 @@ set sort_cols [lrange $args $i end] - set sort_list [list] + set sort_list {} for { set i 1 } { $i <= $rowcount } { incr i } { upvar $multirow_level_up $name:$i row @@ -1002,7 +1002,7 @@ } get_query { - set keyvalues [list] + set keyvalues {} for { set i 0 } { $i < [ns_set size $params] } { incr i } { set key [ns_set key $params $i] set value [ns_set value $params $i] Index: openacs-4/packages/acs-templating/tcl/spellcheck-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-templating/tcl/spellcheck-procs.tcl,v diff -u -r1.24 -r1.25 --- openacs-4/packages/acs-templating/tcl/spellcheck-procs.tcl 5 Dec 2017 15:37:18 -0000 1.24 +++ openacs-4/packages/acs-templating/tcl/spellcheck-procs.tcl 25 Apr 2018 19:23:26 -0000 1.25 @@ -142,7 +142,7 @@ } { set sorted_list [lsort -dictionary $the_list] - set new_list [list] + set new_list {} set old_element "XXinitial_conditionXX" foreach list_element $sorted_list { @@ -277,7 +277,7 @@ upvar $error_num_ref error_num set error_num 0 - set errors [list] + set errors {} set processed_text "" Index: openacs-4/packages/acs-templating/tcl/util-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-templating/tcl/util-procs.tcl,v diff -u -r1.36 -r1.37 --- openacs-4/packages/acs-templating/tcl/util-procs.tcl 23 Apr 2018 21:32:46 -0000 1.36 +++ openacs-4/packages/acs-templating/tcl/util-procs.tcl 25 Apr 2018 19:23:26 -0000 1.37 @@ -73,7 +73,7 @@ upvar $array_ref arr - set ret [list] + set ret {} foreach {key value} [array get arr] { lappend ret "-$key" $value } @@ -165,7 +165,7 @@ upvar $listref inlist if { ! [info exists inlist] } { - set inlist [list] + set inlist {} } # inlist represents the top level of the data structure into which @@ -181,7 +181,7 @@ if { [info exists values($next)] } { set next_list $values($next) } else { - set next_list [list] + set next_list {} } # the number of additional arguments after next determines how many @@ -228,7 +228,7 @@ @return A list in the form { key value key value key value ... } } { - set result [list] + set result {} for { set i 0 } { $i < [ns_set size $set] } { incr i } { @@ -364,7 +364,7 @@ upvar $level $name:rowcount rowcount - set rows [list] + set rows {} for { set i 1 } { $i <= $rowcount } { incr i } { @@ -594,7 +594,7 @@ Return a list of numbers, {1 2 3 ... n} } { - set ret [list] + set ret {} for {set i $start_at} { $i <= $last_number } {incr i} { lappend ret $i } Index: openacs-4/packages/acs-templating/tcl/widget-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-templating/tcl/widget-procs.tcl,v diff -u -r1.59 -r1.60 --- openacs-4/packages/acs-templating/tcl/widget-procs.tcl 23 Apr 2018 16:58:39 -0000 1.59 +++ openacs-4/packages/acs-templating/tcl/widget-procs.tcl 25 Apr 2018 19:23:26 -0000 1.60 @@ -173,7 +173,7 @@ } else { # we need to return a select list - set options [list] + set options {} if { [llength $persons] > 0 } { set options $persons @@ -662,7 +662,7 @@ set output {} if { $mode ne "edit" } { - set selected_list [list] + set selected_list {} foreach option $options_list { lassign $option label value Index: openacs-4/packages/acs-templating/tcl/wizard-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-templating/tcl/wizard-procs.tcl,v diff -u -r1.15 -r1.16 --- openacs-4/packages/acs-templating/tcl/wizard-procs.tcl 25 Apr 2018 08:42:17 -0000 1.15 +++ openacs-4/packages/acs-templating/tcl/wizard-procs.tcl 25 Apr 2018 19:23:26 -0000 1.16 @@ -93,7 +93,7 @@ template::util::get_opts $args - set steps [list] + set steps {} set rowcount 0 if { [info exists opts(name)] } { set wizard_name $opts(name) @@ -416,7 +416,7 @@ get_reference upvar 2 wizard_submit_buttons buttons - set buttons [list] + set buttons {} set param_level [template::adp_level] upvar #$param_level wizard:params params @@ -611,7 +611,7 @@ append url "&wizard_visitedstep${one_wizard}=[ns_queryget wizard_visitedstep${one_wizard}]" } - set multiple_listed [list] + set multiple_listed {} # check for passthrough parameters Index: openacs-4/packages/notifications/tcl/delivery-method-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/notifications/tcl/delivery-method-procs.tcl,v diff -u -r1.14 -r1.15 --- openacs-4/packages/notifications/tcl/delivery-method-procs.tcl 7 Aug 2017 23:48:13 -0000 1.14 +++ openacs-4/packages/notifications/tcl/delivery-method-procs.tcl 25 Apr 2018 19:23:27 -0000 1.15 @@ -69,7 +69,7 @@ set impl_key [get_impl_key -delivery_method_id $delivery_method_id] # Prepare the arguments - set args [list] + set args {} # ns_log Notice "NOTIF-DELIV-METHOD: about to call acs_sc on $impl_key" Index: openacs-4/packages/notifications/tcl/notification-email-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/notifications/tcl/notification-email-procs.tcl,v diff -u -r1.40 -r1.41 --- openacs-4/packages/notifications/tcl/notification-email-procs.tcl 24 Apr 2018 18:42:41 -0000 1.40 +++ openacs-4/packages/notifications/tcl/notification-email-procs.tcl 25 Apr 2018 19:23:27 -0000 1.41 @@ -139,7 +139,7 @@ set content [ad_html_qualify_links $content] # Use this to build up extra mail headers - set extra_headers [list] + set extra_headers {} # This should disable most auto-replies. lappend extra_headers [list "Precedence" "list"] @@ -235,7 +235,7 @@ return {} } - set list_of_reply_ids [list] + set list_of_reply_ids {} set new_messages_p 0 foreach msg $messages { @@ -253,7 +253,7 @@ set end_of_headers_p 0 set i 0 set line [lindex $file $i] - set headers [list] + set headers {} set orig_headers "" # walk through the headers and extract each one Index: openacs-4/packages/notifications/tcl/notification-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/notifications/tcl/notification-procs.tcl,v diff -u -r1.20 -r1.21 --- openacs-4/packages/notifications/tcl/notification-procs.tcl 24 Apr 2018 14:28:56 -0000 1.20 +++ openacs-4/packages/notifications/tcl/notification-procs.tcl 25 Apr 2018 19:23:27 -0000 1.21 @@ -61,7 +61,7 @@ set intervals [db_list_of_lists select_intervals {}] if { $localized_p } { # build pretty names for intervals - set intervals_pretty [list] + set intervals_pretty {} foreach elm $intervals { lassign $elm elm_name elm_id lappend intervals_pretty [list [_ notifications.${elm_name}] $elm_id] @@ -220,7 +220,7 @@ } array set default_request $default_request_data - array set request [list] + array set request {} # Start with the existing requests for the original object_id db_foreach select_notification_requests {} -column_array row { Index: openacs-4/packages/search/tcl/search-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/search/tcl/search-procs.tcl,v diff -u -r1.49 -r1.50 --- openacs-4/packages/search/tcl/search-procs.tcl 7 Aug 2017 23:48:29 -0000 1.49 +++ openacs-4/packages/search/tcl/search-procs.tcl 25 Apr 2018 19:23:27 -0000 1.50 @@ -441,7 +441,7 @@ } { List of names of extra args implemented } { - set names [list] + set names {} foreach procname [info procs ::callback::search::extra_arg::impl::*] { lappend names [namespace tail $procname] } @@ -469,7 +469,7 @@ } { List of extra_args to pass to search::search callback } { - set extra_args [list] + set extra_args {} foreach name [extra_args_names] { upvar $name local_$name ns_log debug "extra_args name = '${name}' exists [info exists local_${name}]"