Index: openacs-4/packages/acs-admin/www/apm/version-i18n-process-2.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-admin/www/apm/version-i18n-process-2.tcl,v diff -u -r1.20 -r1.21 --- openacs-4/packages/acs-admin/www/apm/version-i18n-process-2.tcl 7 Aug 2017 23:47:45 -0000 1.20 +++ openacs-4/packages/acs-admin/www/apm/version-i18n-process-2.tcl 7 Apr 2018 19:41:47 -0000 1.21 @@ -32,7 +32,7 @@ set message_key_list [list] for { set counter 1 } { $counter <= $number_of_keys } { incr counter } { if { [info exists replace_p($counter)] } { - if { ([info exists message_keys($counter)] && $message_keys($counter) ne "") } { + if { [info exists message_keys($counter)] && $message_keys($counter) ne "" } { lappend message_key_list $message_keys($counter) } else { ad_return_complaint 1 "
  • Message key number $counter is empty. Cannot replace text with empty key
  • " Index: openacs-4/packages/acs-admin/www/apm/version-parameters.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-admin/www/apm/version-parameters.tcl,v diff -u -r1.12 -r1.13 --- openacs-4/packages/acs-admin/www/apm/version-parameters.tcl 7 Aug 2017 23:47:45 -0000 1.12 +++ openacs-4/packages/acs-admin/www/apm/version-parameters.tcl 7 Apr 2018 19:41:47 -0000 1.13 @@ -43,7 +43,7 @@ #DRB: sql_clauses must not contain RDBMS-specific query clauses. set sql_clauses "" -if { ([info exists dimensional_list] && $dimensional_list ne "") } { +if { $dimensional_list ne "" } { append sql_clauses [ad_dimensional_sql $dimensional_list] lappend elements_list section_name { label "Section" Index: openacs-4/packages/acs-admin/www/auth/authority.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-admin/www/auth/authority.tcl,v diff -u -r1.24 -r1.25 --- openacs-4/packages/acs-admin/www/auth/authority.tcl 19 Jan 2018 12:57:28 -0000 1.24 +++ openacs-4/packages/acs-admin/www/auth/authority.tcl 7 Apr 2018 19:41:47 -0000 1.25 @@ -282,8 +282,8 @@ } set run_time [util::interval_pretty -seconds $run_time_seconds] } - if { ([info exists get_doc_impl_id] && $get_doc_impl_id ne "") - && ([info exists process_doc_impl_id] && $process_doc_impl_id ne "") } { + if { [info exists get_doc_impl_id] && $get_doc_impl_id ne "" + && [info exists process_doc_impl_id] && $process_doc_impl_id ne "" } { set batch_sync_run_url [export_vars -base batch-job-run { authority_id }] template::add_confirm_handler \ -id batch-sync-run \ @@ -319,9 +319,9 @@ foreach element_name [auth::authority::get_sc_impl_columns] { # Only offer link if there is an implementation chosen and that implementation has # parameters to configure - if { ([info exists element_array($element_name)] && $element_array($element_name) ne "") && - [auth::driver::get_parameters -impl_id $element_array($element_name)] ne ""} { - + if { [info exists element_array($element_name)] && $element_array($element_name) ne "" + && [auth::driver::get_parameters -impl_id $element_array($element_name)] ne "" + } { set configure_url [export_vars -base authority-parameters { authority_id }] break } Index: openacs-4/packages/acs-admin/www/users/complex-search.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-admin/www/users/complex-search.tcl,v diff -u -r1.17 -r1.18 --- openacs-4/packages/acs-admin/www/users/complex-search.tcl 15 Nov 2017 15:37:37 -0000 1.17 +++ openacs-4/packages/acs-admin/www/users/complex-search.tcl 7 Apr 2018 19:41:47 -0000 1.18 @@ -123,7 +123,7 @@ set criteria:[set rowcount](data) "Email contains '$email'" } -if { ([info exists ip] && $ip ne "") } { +if { $ip ne "" } { lappend where_clause "creation_ip = :ip" incr rowcount set criteria:[set rowcount](data) "Creation IP is $ip"