Index: openacs-4/packages/acs-lang/tcl/lang-util-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-lang/tcl/lang-util-procs.tcl,v diff -u -r1.49 -r1.50 --- openacs-4/packages/acs-lang/tcl/lang-util-procs.tcl 7 Aug 2017 23:47:56 -0000 1.49 +++ openacs-4/packages/acs-lang/tcl/lang-util-procs.tcl 7 Apr 2018 17:51:33 -0000 1.50 @@ -21,7 +21,7 @@ ad_proc -public lang::util::lang_sort { field - {locale {}} + {locale ""} } { Each locale can have a different alphabetical sort order. You can test this proc with the following data: @@ -760,14 +760,14 @@ } { foreach lm $list { upvar $lm foreign_var - if { ([info exists foreign_var] && $foreign_var ne "") } { + if { [info exists foreign_var] && $foreign_var ne "" } { set foreign_var "\[$foreign_var\]" } } } ad_proc -public lang::util::convert_to_i18n { - {-locale} + {-locale ""} {-package_key "acs-translations"} {-message_key ""} {-prefix ""} @@ -794,7 +794,7 @@ # Register the language keys lang::message::register en_US $package_key $message_key $text - if {([info exists locale] && $locale ne "")} { + if {$locale ne ""} { lang::message::register $locale $package_key $message_key $text } Index: openacs-4/packages/acs-service-contract/tcl/implementation-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-service-contract/tcl/implementation-procs.tcl,v diff -u -r1.15 -r1.16 --- openacs-4/packages/acs-service-contract/tcl/implementation-procs.tcl 7 Aug 2017 23:47:57 -0000 1.15 +++ openacs-4/packages/acs-service-contract/tcl/implementation-procs.tcl 7 Apr 2018 17:54:17 -0000 1.16 @@ -132,7 +132,7 @@ ad_proc -public acs_sc::impl::get_id { {-owner:required} {-name:required} - -contract + {-contract ""} } { Retrieves the ID for a service contract. If the contract is specified then the ID is retrieved for the specified contract, otherwise all @@ -147,7 +147,7 @@ a service contract, if the contract is not specified. } { - if {([info exists contract] && $contract ne "")} { + if {($contract ne ""} { return [db_string select_impl_id_with_contract {}] } else { return [db_string select_impl_id {}] Index: openacs-4/packages/dotlrn/tcl/club-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn/tcl/club-procs.tcl,v diff -u -r1.30 -r1.31 --- openacs-4/packages/dotlrn/tcl/club-procs.tcl 7 Aug 2017 23:48:09 -0000 1.30 +++ openacs-4/packages/dotlrn/tcl/club-procs.tcl 7 Apr 2018 18:00:33 -0000 1.31 @@ -187,7 +187,7 @@ } { upvar create_club_p create_club_p - if {([info exists create_club_p] && $create_club_p ne "") + if {[info exists create_club_p] && $create_club_p ne "" && $create_club_p == "t"} { # Create the new club and create a link between it and # the new contact. Index: openacs-4/packages/dotlrn/tcl/community-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn/tcl/community-procs.tcl,v diff -u -r1.220 -r1.221 --- openacs-4/packages/dotlrn/tcl/community-procs.tcl 30 Mar 2018 10:23:34 -0000 1.220 +++ openacs-4/packages/dotlrn/tcl/community-procs.tcl 7 Apr 2018 18:00:33 -0000 1.221 @@ -2319,10 +2319,10 @@ # bother to create the welcome message in the first place (will be spam filtered...) MalteS if { ([info exists subject] && $subject ne "") || $override_subject ne "" } { ns_log Debug "DAVEB override email '${override_email}' override_subject '${override_subject}'" - if {([info exists override_email] && $override_email ne "")} { + if {$override_email ne ""} { set email $override_email } - if {([info exists override_subject] && $override_subject ne "")} { + if {$override_subject ne ""} { set subject $override_subject } if {[info exists email] && "" ne [string trim $email] } { Index: openacs-4/packages/dotlrn/www/members.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn/www/members.tcl,v diff -u -r1.37 -r1.38 --- openacs-4/packages/dotlrn/www/members.tcl 19 Jan 2018 14:38:45 -0000 1.37 +++ openacs-4/packages/dotlrn/www/members.tcl 7 Apr 2018 18:00:33 -0000 1.38 @@ -242,7 +242,8 @@ } -if {([info exists reset] && $reset ne "") && ([info exists reltype] && $reltype ne "")} { +if {[info exists reset] && $reset ne "" + && [info exists reltype] && $reltype ne ""} { set result "" db_multirow reset_members select_members {} { rp_form_put user_id $member_id Index: openacs-4/packages/dotlrn/www/spam.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn/www/spam.tcl,v diff -u -r1.34 -r1.35 --- openacs-4/packages/dotlrn/www/spam.tcl 19 Jan 2018 14:38:45 -0000 1.34 +++ openacs-4/packages/dotlrn/www/spam.tcl 7 Apr 2018 18:00:33 -0000 1.35 @@ -56,7 +56,7 @@ } if { $recipients_p == 0} { - if {([info exists community_id] && $community_id ne "")} { + if {$community_id ne ""} { # This is call using the old URL reference ad_returnredirect "spam-recipients?referer=$referer" ad_script_abort