Index: openacs-4/packages/acs-developer-support/acs-developer-support.info
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-developer-support/acs-developer-support.info,v
diff -u -r1.14 -r1.15
--- openacs-4/packages/acs-developer-support/acs-developer-support.info	13 Dec 2003 15:03:00 -0000	1.14
+++ openacs-4/packages/acs-developer-support/acs-developer-support.info	4 May 2004 20:51:37 -0000	1.15
@@ -16,16 +16,18 @@
         <description format="text/html">Developer support stores timing and other logged information for requests 
         to support debugging and tuning and supports user switching and a Tcl Sell to invoke arbitrary tcl code on the server.
         </description>
+        <maturity>0</maturity>
 
         <provides url="acs-developer-support" version="5.0d3"/>
         <requires url="acs-kernel" version="4.6.2"/>
 
         <callbacks>
         </callbacks>
         <parameters>
-            <parameter datatype="string"  min_n_values="1"  max_n_values="1"  name="DatabaseEnabledP"  default="0" description="Remember information about every database request?" section_name="developer-support"/>
+            <parameter datatype="string"  min_n_values="1"  max_n_values="1"  name="AdpRevealEnabledP"  default="0" description="Will put a frame around each ADP file in the page, with an identifying title and hyperlink to api-doc." section_name="developer-support"/>
             <parameter datatype="string"  min_n_values="1"  max_n_values="1"  name="DataLifetime"  default="900" description="Number of seconds to keep connection data" section_name="developer-support"/>
             <parameter datatype="string"  min_n_values="1"  max_n_values="1"  name="DataSweepInterval"  default="900" description="Number of seconds between sweeping for old data" section_name="developer-support"/>
+            <parameter datatype="string"  min_n_values="1"  max_n_values="1"  name="DatabaseEnabledP"  default="0" description="Remember information about every database request?" section_name="developer-support"/>
             <parameter datatype="string"  min_n_values="1"  max_n_values="1"  name="EnabledIPs"  default="*" description="remember information for which client hosts?" section_name="developer-support"/>
             <parameter datatype="string"  min_n_values="1"  max_n_values="1"  name="EnabledOnStartupP"  default="1" description="Remember information about connections, for developers' benefit?" section_name="developer-support"/>
             <parameter datatype="string"  min_n_values="1"  max_n_values="1"  name="PackageWatchList"  description="A space separated list of keys for packages that you are developing on and that will have full watches (automatic reloading of tcl libraries and xql files) activated on every server startup.
Index: openacs-4/packages/acs-developer-support/lib/adp-reveal.adp
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-developer-support/lib/Attic/adp-reveal.adp,v
diff -u
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ openacs-4/packages/acs-developer-support/lib/adp-reveal.adp	4 May 2004 20:51:37 -0000	1.1
@@ -0,0 +1,6 @@
+<div class="@ds_adp_box_class@">
+  <span class="@ds_adp_file_class@"><a href="/api-doc/content-page-view?source_p=1&path=@apidoc_path@" style="text-decoration: none;">@stub_path@</a></span>
+  <div class="@ds_adp_output_class@">
+    <slave>
+  </div>
+</div>
Index: openacs-4/packages/acs-developer-support/lib/adp-reveal.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-developer-support/lib/Attic/adp-reveal.tcl,v
diff -u
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ openacs-4/packages/acs-developer-support/lib/adp-reveal.tcl	4 May 2004 20:51:37 -0000	1.1
@@ -0,0 +1,5 @@
+set ds_adp_box_class [ds_adp_box_class]
+set ds_adp_file_class [ds_adp_file_class]
+set apidoc_path [string range $ds_adp_stub [string length [acs_root_dir]] end].$ds_adp_template_extension
+set stub_path [join [split $ds_adp_stub /] " / "]
+set ds_adp_output_class [ds_adp_output_class]
Index: openacs-4/packages/acs-developer-support/lib/toolbar.adp
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-developer-support/lib/toolbar.adp,v
diff -u -r1.9 -r1.10
--- openacs-4/packages/acs-developer-support/lib/toolbar.adp	17 Mar 2004 13:17:12 -0000	1.9
+++ openacs-4/packages/acs-developer-support/lib/toolbar.adp	4 May 2004 20:51:37 -0000	1.10
@@ -10,6 +10,7 @@
           <li><a href="@user_switching_toggle_url@" class="@user_switching_on@" title="User switching">USR</a></li>
           <li><a href="@db_toggle_url@" class="@db_on@" title="Database statistics">DB</a></li>
           <li><a href="@translator_toggle_url@" class="@translator_on@" title="Translator mode">TRN</a></li>
+          <li><a href="@adp_toggle_url@" class="@adp_on@" title="ADP Reveal mode">ADP</a></li>
         </ul>
       </td>
 
Index: openacs-4/packages/acs-developer-support/lib/toolbar.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-developer-support/lib/toolbar.tcl,v
diff -u -r1.4 -r1.5
--- openacs-4/packages/acs-developer-support/lib/toolbar.tcl	11 Jan 2004 16:37:03 -0000	1.4
+++ openacs-4/packages/acs-developer-support/lib/toolbar.tcl	4 May 2004 20:51:37 -0000	1.5
@@ -25,6 +25,10 @@
     set translator_toggle_url [export_vars -base "/acs-lang/admin/translator-mode-toggle" { { return_url [ad_return_url] } }]
     set translator_on [ad_decode $translator_p 1 "on" "off"]
 
+    set adp_p [ds_adp_reveal_enabled_p]
+    set adp_toggle_url {javascript:void(d=document);void(el=d.getElementsByTagName('span'));for(i=0;i<el.length;i++){if(el[i].className=='developer-support-adp-file-on'){void(el[i].className='developer-support-adp-file-off')}else{if(el[i].className=='developer-support-adp-file-off'){void(el[i].className='developer-support-adp-file-on')}}};void(el=d.getElementsByTagName('div'));for(i=0;i<el.length;i++){if(el[i].className=='developer-support-adp-box-on'){void(el[i].className='developer-support-adp-box-off')}else{if(el[i].className=='developer-support-adp-box-off'){void(el[i].className='developer-support-adp-box-on')}};if(el[i].className=='developer-support-adp-output-on'){void(el[i].className='developer-support-adp-output-off')}else{if(el[i].className=='developer-support-adp-output-off'){void(el[i].className='developer-support-adp-output-on')}};}}
+    set adp_on [ad_decode $adp_p 1 "on" "off"]
+
     set oacs_shell_url "${ds_url}shell"
 
     set auto_test_url [site_node::get_package_url -package_key acs-automated-testing]
Index: openacs-4/packages/acs-developer-support/tcl/acs-developer-support-init.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-developer-support/tcl/acs-developer-support-init.tcl,v
diff -u -r1.4 -r1.5
--- openacs-4/packages/acs-developer-support/tcl/acs-developer-support-init.tcl	11 Dec 2003 21:39:50 -0000	1.4
+++ openacs-4/packages/acs-developer-support/tcl/acs-developer-support-init.tcl	4 May 2004 20:51:38 -0000	1.5
@@ -27,6 +27,7 @@
 
 
     nsv_set ds_properties database_enabled_p [ad_parameter -package_id [ds_instance_id] DatabaseEnabledP developer-support 0]
+    nsv_set ds_properties adp_reveal_enabled_p [ad_parameter -package_id [ds_instance_id] AdpRevealEnabledP developer-support 0]
     ds_set_user_switching_enabled [ad_parameter -package_id [ds_instance_id] UserSwitchingEnabledP acs-developer-support 0]
 }
 
Index: openacs-4/packages/acs-developer-support/tcl/acs-developer-support-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-developer-support/tcl/acs-developer-support-procs.tcl,v
diff -u -r1.29 -r1.30
--- openacs-4/packages/acs-developer-support/tcl/acs-developer-support-procs.tcl	20 Apr 2004 21:12:39 -0000	1.29
+++ openacs-4/packages/acs-developer-support/tcl/acs-developer-support-procs.tcl	4 May 2004 20:51:38 -0000	1.30
@@ -81,7 +81,36 @@
     return [nsv_get ds_properties database_enabled_p]
 }
 
+ad_proc -public ds_adp_reveal_enabled_p {} { 
+    Returns true if developer-support adp revealing facilities are enabled. 
+} {
+    return [nsv_get ds_properties adp_reveal_enabled_p]
+}
 
+ad_proc -public ds_adp_box_class {} {
+    if { [ds_adp_reveal_enabled_p] } {
+        return developer-support-adp-box-on
+    } else {
+        return developer-support-adp-box-off
+    }
+}
+
+ad_proc -public ds_adp_file_class {} {
+    if { [ds_adp_reveal_enabled_p] } {
+        return developer-support-adp-file-on
+    } else {
+        return developer-support-adp-file-off
+    }
+}
+
+ad_proc -public ds_adp_output_class {} {
+    if { [ds_adp_reveal_enabled_p] } {
+        return developer-support-adp-output-on
+    } else {
+        return developer-support-adp-output-off
+    }
+}
+
 ad_proc -public ds_lookup_administrator_p { user_id } { } {
     return 1
 }
@@ -460,6 +489,16 @@
     nsv_set ds_properties database_enabled_p $enabled_p
 }
 
+ad_proc -public ds_set_adp_reveal_enabled { enabled_p } {
+    Enables/disables database statistics in a safe manner.
+
+    @author Lars Pind (lars@pinds.com)
+    @creation-date 31 August 2000
+} {
+    ns_log Notice "Developer-support adp reveal stats [ad_decode $enabled_p 1 "enabled" "disabled"]"
+    nsv_set ds_properties adp_reveal_enabled_p $enabled_p
+}
+
 ad_proc -private ds_replace_get_user_procs { enabled_p } {
     Replace the ad_get_user procs with our own versions
 } {
Index: openacs-4/packages/acs-developer-support/www/index.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-developer-support/www/index.tcl,v
diff -u -r1.11 -r1.12
--- openacs-4/packages/acs-developer-support/www/index.tcl	1 Apr 2004 15:04:38 -0000	1.11
+++ openacs-4/packages/acs-developer-support/www/index.tcl	4 May 2004 20:51:38 -0000	1.12
@@ -15,6 +15,7 @@
 set enabled_p [nsv_get ds_properties enabled_p]
 set user_switching_enabled_p [nsv_get ds_properties user_switching_enabled_p]
 set database_enabled_p [nsv_get ds_properties database_enabled_p]
+set adp_reveal_enabled_p [nsv_get ds_properties adp_reveal_enabled_p]
 
 set package_id [ad_conn package_id]
 
@@ -76,6 +77,11 @@
     "on (<a href=\"set-database-enabled?enabled_p=0\">turn it off</a>)" \
     "off (<a href=\"set-database-enabled?enabled_p=1\">turn it on</a>)"]
 
+<li>ADP reveal is currently
+[ad_decode $adp_reveal_enabled_p 1 \
+    "on (<a href=\"set-adp-reveal-enabled?enabled_p=0\">turn it off</a>)" \
+    "off (<a href=\"set-adp-reveal-enabled?enabled_p=1\">turn it on</a>)"]
+
 <p>
 <li> Help on <a href=\"doc/editlocal\">edit and code links</a>.
 </ul>
Index: openacs-4/packages/acs-developer-support/www/set-adp-reveal-enabled.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-developer-support/www/Attic/set-adp-reveal-enabled.tcl,v
diff -u
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ openacs-4/packages/acs-developer-support/www/set-adp-reveal-enabled.tcl	4 May 2004 20:51:38 -0000	1.1
@@ -0,0 +1,15 @@
+ad_page_contract {
+    
+    @author Lars Pind (lars@pinds.com)
+    @creation-date 2003-10-28
+    @cvs-id $Id: set-adp-reveal-enabled.tcl,v 1.1 2004/05/04 20:51:38 andrewg Exp $
+} {
+    enabled_p
+    {return_url "."}
+}
+
+ds_require_permission [ad_conn package_id] "admin"
+
+ds_set_adp_reveal_enabled $enabled_p
+
+ad_returnredirect $return_url
Index: openacs-4/packages/acs-developer-support/www/resources/acs-developer-support.css
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-developer-support/www/resources/acs-developer-support.css,v
diff -u -r1.2 -r1.3
--- openacs-4/packages/acs-developer-support/www/resources/acs-developer-support.css	29 Mar 2004 21:02:35 -0000	1.2
+++ openacs-4/packages/acs-developer-support/www/resources/acs-developer-support.css	4 May 2004 20:51:38 -0000	1.3
@@ -54,9 +54,42 @@
   display: inline;
 }
 
+/* ADP Reveal mode */
 
+div.developer-support-adp-box-on {
+  background-color: #fcc;
+  border-style: solid;
+  border-color: #f33;
+  border-width: 1px 1px 1px 1px;
+}
 
+div.developer-support-adp-box-off {
+  background-color: inherit;
+  border-width: 0px;
+}
 
+span.developer-support-adp-file-on {
+  font-size: 80%;
+}
+
+span.developer-support-adp-file-off {
+  display: none;
+}
+
+div.developer-support-adp-output-on {
+  background-color: #fff;
+  border-style: solid;
+  border-color: #777;
+  border-width: 1px 0px 0px 0px;
+  padding: 3px;
+}
+
+div.developer-support-adp-output-off {
+  background-color: inherit;
+  border-width: 0px;
+  padding: 0px;
+}
+
 /* Developer-support footer */
 
 .developer-support-footer {