Index: openacs-4/packages/acs-subsite/www/admin/site-map/parameter-set.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-subsite/www/admin/site-map/Attic/parameter-set.tcl,v
diff -u -r1.9 -r1.10
--- openacs-4/packages/acs-subsite/www/admin/site-map/parameter-set.tcl	10 Jan 2007 21:22:08 -0000	1.9
+++ openacs-4/packages/acs-subsite/www/admin/site-map/parameter-set.tcl	27 Oct 2014 16:39:56 -0000	1.10
@@ -12,7 +12,7 @@
     {return_url "."}
 }
 
-ad_require_permission $package_id admin
+permission::require_permission -object_id $package_id -privilege admin
 
 db_1row package_info {}
 
@@ -31,7 +31,7 @@
 set dimensional_list [apm_parameter_section_slider $package_key]
 set additional_sql ""
 
-if {[exists_and_not_null dimensional_list] } {
+if {([info exists dimensional_list] && $dimensional_list ne "") } {
     lappend table_def [list section_name "Section:"]
     append additional_sql [ad_dimensional_sql $dimensional_list]
     ns_log Notice [ad_dimensional_sql $dimensional_list]
@@ -47,17 +47,18 @@
 lappend table_def [list attr_value "Value" no_sort \
 	{<td>
 	   <input name=params.$parameter_id value=\"$attr_value\" size=50>
-	    <font color=red><strong>[if { ![empty_string_p [ad_parameter_from_file $parameter_name [uplevel set package_key]]] } { uplevel set display_warning_p 1 } ; ad_parameter_from_file $parameter_name [uplevel set package_key]]</strong></font>
+	    <font color=red><strong>[if { [ad_parameter_from_file $parameter_name [uplevel set package_key]] ne "" } { uplevel set display_warning_p 1 } ; ad_parameter_from_file $parameter_name [uplevel set package_key]]</strong></font>
 	    </td>}]
 
 append additional_sql [ad_order_by_from_sort_spec $orderby $table_def]
 
-set body "[ad_header "Parameters for $instance_name"]
-<h2>Parameters for $instance_name</h2>
-[ad_context_bar [list "index" "Site Map"] "$instance_name Parameters"]
-<hr>
-"
+set title "Parameters for $instance_name"
+set context [list [list "index" "Site Map"] "$instance_name Parameters"]
 
+set body [subst {<h2>Parameters for $instance_name</h2>
+    <hr>
+}]
+
 if { $dimensional_list ne "" } {
     append body "[ad_dimensional $dimensional_list]<p>"
 }
@@ -66,6 +67,8 @@
 
 ns_log Notice "table_sql = $table_sql"
 
+#vguerra: This is the only call to ad_table within core, but 
+#this page is not linked from anywhere anymore, probably we remove it later on.
 set table [ad_table -Torderby $orderby \
      -bind [ad_tcl_vars_to_ns_set package_id] \
      -Tmissing_text "No parameters registered in this section." \
@@ -76,23 +79,22 @@
 
 
 if { $display_warning_p } {
-    append body "
-Note text in red below the parameter entry fields indicates the value of this
-parameter is being overridden by an entry in the OpenACS parameter file.  The
-use of the parameter file is discouraged but some sites need it to provide
-instance-specific values for parameters independent of the apm_parameter
-tables.
-<hr>
-"
+    append body {
+	Note text in red below the parameter entry fields indicates the value of this
+	parameter is being overridden by an entry in the OpenACS parameter file.  The
+	use of the parameter file is discouraged but some sites need it to provide
+	instance-specific values for parameters independent of the apm_parameter
+	tables.
+	<hr>
+    }
 }
 
+append body [subst {
+    <blockquote>
+    <form method=post action=parameter-set-2>
+    [export_vars -form {package_key package_id instance_name return_url}]
+    $table
+    </blockquote>
+    </form>
+}]
 
-ns_return 200 text/html "$body
-<blockquote>
-<form method=post action=parameter-set-2>
-[export_form_vars package_key package_id instance_name return_url]
-$table
-</blockquote>
-</form>
-[ad_footer]
-"