nsf.c

Clone Tools
  • last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
improved comment

improved spelling

  1. … 2 more files in changeset.
Bug fix: potential crash and swallowed error

The change fixes 2 bugs:

- When a non-existing method was called in a situation where

* a filter with guards is registered, and

* all guards are failing, and

* the method to be called after the filter does not exist

nsf was crashing

- There was no code to produce the proper error message in such situations

  1. … 1 more file in changeset.
improved spelling

  1. … 18 more files in changeset.
nsf:parseargs: honor "required" settings

The previous version was accepting e.g.

nsf::parseargs -asdict {

{-state:wordchar,required}

{-revision_id:integer,required}

{-return_url:localurl "."}

} {}

i.e. passing empty argument list where the first two arguments are required.

Now, the error is flagged properly

provide clean compilation for current Tcl9

  1. … 1 more file in changeset.
Provided a Tcl_DupInternalRepProc() function for Tcl_ObjType "nsfParam"

Recent versions of Tcl9 call Tcl_DupInternalRepProc() for Tcl_ObjType

"nsfParam", which was a placeholder function before, leading to a

Tcl_Abort(). The provided implementation provides now a basic logic

for "duplicating" internal representations of parameter lists based on

refcounts (somewhat similar to ProcBodyDup), but it has to be tested

further, with a proper test case.

The call of the Tcl_DupInternalRepProc function happens so far during

the startup of NaviServer compiled with Tcl9. It might be necessary to

overthink the competing logics of the "canDelete" member and the

reference count. For now, the intention is to get the NaviServer +

Tcl9 regression test stop from aborting.

cleanup after TIP 660

  1. … 2 more files in changeset.
Fixed warnings detected with branch "disabletcl8api"

The Tcl9 native interface is based on "Tcl_Size" instead of "int", but

the default mode hides these differences via some macro-magic. Typical

such cases are API calls like:

Tcl_ListObjLength(interp, methodObj, &length);

Tcl_ListObjGetElements(interp, methodObj, &oc, &ov)

The macro-magic queries the size of the provided parameters and uses

the old or new interface depending on it (while hiding some more

potential problems, a compiler can detect). The branch

"disabletcl8api" removes the macro-magic and reveals the potential

problem areas, where the code is still depending on the old 32bit

interface.

This commit fixes such cases and the collateral damage.

  1. … 4 more files in changeset.
Provide support for TIP 627 (Tcl 8.7a6+ and Tcl 9)

TIP 627 introduces support for > 2^31 elements in object vectors

(e.g., number of words in a single Tcl command). For details, see

https://core.tcl-lang.org/tips/doc/trunk/tip/627.md

To provide also backwards compatibility, this change uses the macros

TCL_COMMAND_OBJPROC, TCL_CREATEOBJCOMMAND, TCL_NRCALLOBJPROC,

TCL_NRCREATECOMMAND, TCL_OBJCMDPROC_T, and TCL_OBJC_T.

  1. … 21 more files in changeset.
updated copyright notice

improve spelling

  1. … 10 more files in changeset.
New feature: added support for return value checker for nsf::proc

One can now specify "-returns ...." in nsf::proc commands the same way

as in nx/XOTcl2 methods.

nsf::proc ... /procName/ /arguments/ ?-returns /valueconstraint/? /body/

When return value checkers are defined, these are returned by the

usual introspection interface.

% nsf::proc ::foo {-a:integer} -returns integer {return 1}

% nsf::cmd::info definition ::foo

::nsf::proc ::foo -a:integer -returns integer {return 1}

% nsf::cmd::info returns ::foo

integer

The regression test was extended to cover these cases.

  1. … 5 more files in changeset.
Fix bug, where Tcl's "string is" checker modified result, when used as a return value checker

The new code saves and restores the original result value.

The regression test was extended.

Many thanks to Antonio Pisano for pointing out this issue.

  1. … 1 more file in changeset.
generalize handling of isTYPE calls by defining CHARTTYPE

The macro was developed earlier on NaviServer, and is used

in nsf for "upper", "space" and "alpha" character checkers

  1. … 1 more file in changeset.
Provide an initializer for the new size_t field of Tcl_ObjType (Tcl 9)

  1. … 1 more file in changeset.
reduce warnings for other compilers

reduce warnings for clang

clang has no "-Wmaybe-uninitialized" flag

address the maybe-uninitialized warnings

I do not really like the approach based on pragmas, but i do even

less like the warnings, when compiled with -pedantic

reduced compiler warnings when compiling against Tcl 8.6* with TIDY settings

  1. … 1 more file in changeset.
Deactive block for double-checking chached data for Tcl commands

Leave the code for potential future debugging purposes

Improve cleanness of compilation under gcc-11+ and "-pedantic" + -Wextra"

  1. … 1 more file in changeset.
Added support for compiling with Tcl 9.0 (Many Thanks to Jan Nijtmans for first steps)

This version compiles cleanly at least with Tcl 8.6.* and Tcl 9.0 (fossil trunk),

having -pedantic and -Wextra defined.

  1. … 20 more files in changeset.
cleanup: avoid memory leak in cases the Tcl_DictObjPut fails

added option "-asdict" to nsf::parseargs

The new option makes it easier to process the parsed argument in different

contexts

  1. … 3 more files in changeset.
Bug fix: include alias to object in "info methods -path"

Previously, it was not possible to define an alias to an object for

NaviServer, since it was not returned by "info methods -path" and

was therefore not included in the blueprint.

Extended regression test.

  1. … 4 more files in changeset.
improve function description

remove realtive costly asserts when not in development mode

  1. … 1 more file in changeset.
* nsf.c (ObjectDispatch): Fix another invalid read of a cached cmd structure (NsfColonCommandContext)

* nsf.c (NsfUnsetTrace, VolatileMethod): Plug a post-mortem memleak related to volatile objects (The Tcl_Obj carrying an auto-qualified object name was not cleaned up properly during interp shutdown because the matching decrement operations used to be disabled during shutdown.)