• last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
make check more robust

harden page_contract

Format code in a way to avoid false positives where a column name is taken as a deprecated proc

    • -9
    • +6
    /openacs-4/packages/forums/tcl/forums-procs.tcl
Cleanup deprecated api from test

Go ahead and reimplement also lc_time_utc_to_local

Reimplement lc_time_local_to_utc using lc_time_tz_convert

Improve test for lc_time_local_to_utc, showing that its behavior is inconsitent with respect to invalid input

harden page contract

perm-include checks already that privs are not empty

Use UTF-8 emoji HTML entities instead of static images to convert smileys in the forums package

This has the advantage of not requiring a request to serve the images. It also avoids the need to hardcode the image size, as they will be basically treated as fonts.

Whitespace cleanup

Increase proc coverage, deprecate proc in the process

Test cornercase behavior

Whitespace changes

Make Service Contract implementations private

Hardcode the word "Page" in the message keys as the German localization does

Many thanks to Markus Moser for reporting the inconsistency

Deprecate forum::new_questions_allow and forum::new_questions_deny, one should use forum::edit, which will also track the change, or just inline the query instead

    • -3
    • +11
    /openacs-4/packages/forums/tcl/forums-procs.tcl
Deprecate forum::new_questions_allowed_p and replace occurrences

    • -2
    • +8
    /openacs-4/packages/forums/tcl/forums-procs.tcl
Increase proc coverage

Make faq::notification_delivery::do_notification private

    • -1
    • +1
    /openacs-4/packages/faq/tcl/q-and-a-procs.tcl
Use better idioms to cleanup the user

Provide an api to create a new FAQ, so that Create+Read of an FAQ can be tested

    • -0
    • +23
    /openacs-4/packages/faq/tcl/faq-procs-oracle.xql
    • -0
    • +33
    /openacs-4/packages/faq/tcl/faq-procs.tcl
    • -19
    • +4
    /openacs-4/packages/faq/www/admin/faq-new-2.tcl
file faq-procs-oracle.xql was initially added on branch oacs-5-10.

    • -0
    • +0
    /openacs-4/packages/faq/tcl/faq-procs-oracle.xql
file faq-procs-postgresql.xql was initially added on branch oacs-5-10.

    • -0
    • +0
    /openacs-4/packages/faq/tcl/faq-procs-postgresql.xql
Go straight to the database skipping the many trivial stored procedures, this reduces divergency between Oracle and Postgres

feed_parser::test::parse_feed is also used by the news-aggregator package, make it public again, document this and claim its coverage

Make test api private

Deprecate feed_parser::sort_result, trivial wrapper over lreverse used only internally

Deprecate trivial wrapper of HTTP client api

Return after a response was given to the client

Many thanks to Markus Moser

    • -0
    • +1
    /openacs-4/packages/caldav/tcl/caldav-procs.tcl
Move api in a namespace to comply with automated tests