• last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
fixed typo

Harden page contract

Whitespace changes

Cleanup obsolete variable

Use adp:icon feature to generate a style-aware icon on every theme

Don't customize the notification widget in the Boostrap 5 theme: modern adp:icon functionality makes this obsolete

Don't customize the notification widget in the Boostrap 3 theme: modern adp:icon functionality makes this obsolete

more fixups fr bootstrap5

    • -1
    • +7
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
update bootstrap version number to 5.3.1

Reimplement the news admin index page to use the template system and behave consistently with the rest of the graphics

One reason to have custom markup here was the bulk-actions pointing to the same URL differentiated only via URL parameters. This limitation has been overcome in the previous commit.

    • -62
    • +1
    /openacs-4/packages/news/www/admin/index.adp
    • -21
    • +103
    /openacs-4/packages/news/www/admin/index.tcl
template::list bulk-actions feature:

allow to have URL parameters specified in the bulk-action URL, so that the same URL can be used to serve multiple bulk actions differentiated via different flags. The URL parameters override completely every attribute with the same name specified on the form.

Be Bootstrap 5 friendly

bootstrap5 bulkactions: move "ul" element to one level higher

Many thanks to Monika Andergassen for the change

bootstrap5 dropt down menu item: add "disabled" class to the anchor element as well

Many thanks to Monika Andergassen for the suggestion

use for bootstrap5 for select input form-select instead of form-control

Many thanks to Monika Andergassen for noting

    • -1
    • +4
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
fix indentation

Space the save button a bit

Truncate timestamp to the seconds

Apply the Boostrap classes also to the other buttons for consistency

Be Bootstrap5 friendly on the buttons formerly known as "default"

Fix typo

Modernize JavaScript:

- Be specific about the scope and lifetime of variables via const and let

- Always prefer "for" loops to iterators

- Cleanup obsolete wrappers

- Use single and double quotes consistently

- Use the equals operator consistently

Prefer modal implementation from acs-templating to the various approaches used so far

Add acknowledgment

Fix navigation

Provide a zero-dependency Modal implementation

This uses CSS and little JavaScript. The goal is to provide a Modal implementation that is independend from frameworks such as Boostrap. This is actually very possible in modern CSS and JavaScript.

Documentation with examples is included.

file modal.adp was initially added on branch oacs-5-10.

file modal.js was initially added on branch oacs-5-10.

file modal.css was initially added on branch oacs-5-10.

replaced complex and error-prone test with a more sane version

Actually, this test should be in acs-tcl, since all kernel behavior is already

there, and the directory "tcl" was left intentionally empty.