• last updated 9 hours ago
Constraints: committers
Constraints: files
Constraints: dates
improve spelling

Avoid calling depreacted content_item__new/17, call content_item__new/21 instead

file upgrade-5.10.0d1-5.10.0d2.sql was initially added on branch oacs-5-10.

We cannot use bind variables here, as the query is not executed at this time, but later at bulk mail sweeping

    • -1
    • +1
Provide a public general-comments solution to empty messages from a specific package: other xowiki-like packages downstream would otherwise need to call a xowiki private api

Deprecate spam::interpolate in favor of 'string map'

Deprecate acs_mail_lite::message_interpolate in favor of 'string map'

Deprecate bulk_mail::interpolate in favor of 'string map'

Formatting changes

Reduce divergency between oracle and postgres codebase

Whitespace cleanup

Make api public as other packages might need to retrieve the portlet name

Flush also the threaded cache whenever we flush the permission cache, so that one does not need to call this private api directly

Reinstate get_portal_id_not_cached as private, replace occurrences with public api

Reinstate get_portal_id_not_cached as private, flush the cache before calling public api instead

    • -1
    • +1
Fix api:

upstream dotlrn mounts dotlrn-forums at /dotlrn/forums/, but testcase dotlrn_forums__applet_portlet (dotlrn-forums) deletes such node and replaces it with a new one at /dotlrn/applets/forums/. As site_node::get_package_url does not get flushed, the api will expect to find the mounted instance at the old URL, which now resolves to the parent dotlrn instead! Fix this by not relying on the cache to retrieve the applet node id.

improve test coverage

small performance improvement

Provide a cached public api, reinstate uncached api as private, replace occurrences

Do not invoke service contract implementations directly, use the public interface

    • -13
    • +18
Replace deprecated api

- Rework acs-api-browser.callgraph__bad_calls automated test so that acs-service-contract calling contract implementation is considered OK

- Reinstate authentication service contracts as private

- Move test authority implementation to acs-authentication to remove intra-package dependency

acs-api-browser.callgraph__bad_call still fails because proc acs-tcl.install::xml::action::create-user calls private acs-authentication.auth::local::registration::Register... to be continued

file test-authority-procs.tcl was initially added on branch oacs-5-10.

Reinstate apis as public, as they hold the current definition of an all-day event

avoid setting of unneeded function, reduce access to nsvs

    • -3
    • +2
provide a flushing interface to apm_package_id cache to avoid the need to call the uncached code directly

whitespace changes: break overlong lines

Reinstate proc as private, remove dependency to such proc in external package

    • -1
    • +2
make clear from the name that db_qd_prepare_queryfile_content is intended to be used in different packages

Whitespace cleanup

    • -13
    • +13