• last updated 16 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Reduce divergency between oracle and postgres codebase

Reduce divergency between oracle and postgres codebase

Reduce divergency between oracle and postgres codebase

Reduce divergency between Oracle and Postgres codebase

Align fs_objects view definition in Oracle with the one in Postgres

file upgrade-5.10.d2-5.10.d3.sql was initially added on branch oacs-5-10.

Use api and portable idioms

Add ad_include_contract definition (fixes automated tests)

improve spelling

    • -1
    • +1
    /openacs-4/packages/dotlrn/dotlrn.info
Use "package defined" stored procedure instead of legacy nomenclature

Replace legacy acs_permission__permission_p with acs_permission.permission_p

Add ad_page_contract (fixes automated tests)

Note that this include might be obsolete

Use cached api

Add ad_include_contract (fixes automated tests)

Add ad_page_contract to pages (fixes automated tests)

Add ad_include_contract (fixes automated test)

Relax cleanup of parenthesis: remove them only when they don't match, like it used to be in older versions of the code

Fixes automated tests (that were refreshed to latest syntax and labelled with the proc they are testing)

Update test case for lang::util::default_locale_from_lang

Trim padding from column to be sure

Redefine ad_locales.language table column as varchar to avoid Oracle idiosyncrasies when comparing a char(n) with other string datatypes when using bind variables (following insightful LARS's remark)

char(n) in Oracle are automatically padded to be n characters long. Apparently, comparing char(n) -> char(n) is "blanks insensitive", while comparing char(n) -> varchar2(n) will account for such automatically inserted blanks. When using bind variables, one should carefully specify the type to use to avoid surprises with char(n) (for this we should touch the oracle driver), normalize the value via trim/pad all the time or replace every char(n) datatype with varchar2. ...are there other places where this is happening?

file upgrade-5.10.0d2-5.10.0d3.sql was initially added on branch oacs-5-10.

fix for issue #3380

Respect production_mode in cases, where pages are created via www-create-new

and a name is provided via query parameter.

Fix message key + bump version number

Rewrite the query to leverage transparent variable quoting, replace count with quicker existance check, bring sql inline

Add remarks about "correct" usage of ad_decode in proc doc

Replace ad_decode idioms, improve legibility

Replace ad_decode idioms

Replace ad_decode idiom

Replace ad_decode idioms