• last updated 13 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Whitespace cleanup

Provide a minimal documentation to public procs

Exploit new api where appropriate

Apply new user api when appropriate

Move the author into the proper ad_proc documentation block

Rework of this tests

- use dict idioms instead of array, so we don't have to unset all the time

- use new user api when appropriate

- fix test when we try to reuse the username of somebody who was previously banned.

This is no longer possible and is now reflected in the test

Deprecate 'person::update_bio' in favor of 'person::update'

Deprecate 'person::name_flush', unnecessary and used nowhere...

Prefer 'person::name' to 'acs_user::get_element ... -name'

Deprecate 'acs_user::get_element' in favor of 'acs_user::get'

Prefer 'person::name' to 'acs_user::get_element ... -name' + Fix arguments: user_id -> person_id

    • -2
    • +2
    /openacs-4/packages/dotlrn/www/dotlrn-master.tcl
    • -2
    • +2
    /openacs-4/packages/views/lib/views-chunk.tcl
Prefer 'person::name' to 'acs_user::get_element ... -name'

    • -2
    • +2
    /openacs-4/packages/dotlrn/www/dotlrn-master.tcl
    • -2
    • +2
    /openacs-4/packages/views/lib/views-chunk.tcl
Recommend and use 'person::name' instead of 'acs_user::get_element ... -name' in deprecated proc

    • -4
    • +4
    /openacs-4/packages/dotlrn/tcl/dotlrn-procs.tcl
Put get_by_username in the proper cache, handle cases when we delete a user that was not in the cache (in this case we could not retrieve authority and username after deletion)

Prefer 'person::name' to 'acs_user::get_element ... -name'

Remove hotfix and exploit new api, that won't fail on the guest user

Fix typo

Unify person update api, exploit cache better and remove unneded queries

No need to check as now person::name won't fail

Fix expression

Remove leftover files

Parties api had procs defined in both acs-subsite and acs-tcl and sometimes duplicated

- move all party:: api into acs-tcl/tcl/community-core-procs

- remove duplicated definitions

- move leftover deprecated proc to deprecated-procs.tcl

set lang::system::get_locales to per-thead cache as indicated

Use finer grained api for user name

    • -3
    • +5
    /openacs-4/packages/chat/tcl/chat-procs.tcl
Use finer grained api for person information and consider that new api won't fail when no person exists

Use finer grained api in different if branches

Use finer grained person:: api to retrieve the name

    • -1
    • +1
    /openacs-4/packages/forums/www/user-history.adp
    • -5
    • +3
    /openacs-4/packages/forums/www/user-history.tcl
Use new fine grained api for the screen name

fix typo

cache system locales in a per-thread cache