• last updated 9 hours ago
Constraints: committers
Constraints: files
Constraints: dates
Reuse person API instead of querying by hand

Modernize idiom

Restore previous behavior: when a person is not found by email, just return empty string instead of an error

Reduce code duplication when retrieving person info

TODO centralize caching

provide compatibility with AOLserver

make timeout cnd cache size configurable

follow usual naming conventions

    • -0
    • +23
Pass to a ns_cache implementation to avoid race conditions

Implement acs_user:: cache through nsv, instead of the util_memoize cache. Note that now this information won't expire anymore unless explicitly flushed.

Remove unnecessary backslashes, remove leftover usages of get_from_username_not_cached cache, minimize catch wrapping

Reuse acs_user::get_by_username to retrieve user_id in order to reduce query duplication and cache entries for acs_user::get, simplify idiom

Repair broken link: refer to page 'object' instead of to page 'list'

Fix missing variable substitution

Dont require role at the ends of relationships as this is not required in the data model and standard relationships (e.g. membership_rel, admin_rel) lack these roles as well

Fix page for deleting roles

minor changes for consistency

improve documentation

add workflow instance in test workflow

strengthen page contracts a little.

Add missing brace

Transform page_contract into include_contract, and add 'session_id' required parameter for the 'find_assessment' query

Create 'ad_include_contract' for includelet

    • -140
    • +156
Fix typo

Fix typo

Rework adp boolean expressions

  1. … 11 more files in changeset.
Prefer literal in adp expressions + Whitespace changes

Brace and rework expressions + Whitespace changes

perform proper boolean test (variable ends with "_p")

Revert unintended replacement

Prefer literal in adp axpressions + Whitespace changes

  1. … 15 more files in changeset.
Exploit users cache, simplify SQL

Shorten expression, exploit cache