• last updated 9 hours ago
Constraints: committers
Constraints: files
Constraints: dates
Add missing change in the data model from previous commit

Portrait management reform and correction

Moved logics to create a portrait in a proc in order to reuse it in other places

such as picture retrieval services (e.g. Bach picture retrieval at WU). Turns out

we were not doing our homeworks here: when the portrait is created into CR, a

cr_child_rel is created. When the portrait was erased though, this was not cleaned

up propely, leaving dangling acs_objects with no reference in cr_child_rels table.

On busy sites, this can grow in the ten thousands order of magnitude. Changes include

also fix for this behavior and tuples cleanup.

avoid errors, when connection is already closed

fix more spelling issues

remove spurious "expr" in "expr"

simplfy expressions (no need for backslash), standardize writing of RFC

fix spelling

Apply pachtes #960, #961, #962 and #963 from Ben Brink, bump version number to 5.10.0d3 such that changes in .info file get picked up

provide templated error pages for subsite. without this, error pages for host-node-mapped subsites are a pain

CVS: ----------------------------------------------------------------------

    • -0
    • +5
    • -0
    • +4
    • -0
    • +5
    • -0
    • +5
fix for bug #3338

fix ad_form definition (moved redirect in after_submit block, ad_return_template at the end of template outside the ad_form) (thanks to Felix Moedritscher)

Improve HTML

modernize Tcl code

prefer ad_try over catch, simplify expression

fix typos

Protect Tcl's file operations against leading dashes in file names

change "fetch first 1 row only" to "limit 1" to generic xql file, since Oracle started to support fetch first only with version 12c

merge with changes from https://github.com/tekbasse/acs-mail-lite/tree/master/tcl

in essence, these changes provide support for handling email with attachments based on nsIMAP.

see https://openacs.org/forums/message-view?message_id=5378972 for more background

    • -0
    • +2434
    • -0
    • +877
  1. … 57 more files in changeset.
Add ad_script_abort (thanks to Felix Moedritscher)

Use ad_script_abort after ns_return

    • -2
    • +2
Consistently use ad_script_abort after ad_returnredirect

Fix bad handler type error, use ad_try/finally instead of else (Thanks to Felix Moedritscher)

    • -2
    • +2
Fixed package version numbering

Added missing index creation statment; Fixed typo in index name

remove obsolete comment (basic hastore support was moved to xowiki)

    • -12
    • +0
Make sure to add hkey when db has hstore defined

    • -1
    • +19
Corrected table name

add return_url to to add_url on view-one-day-display

Add custom delimiter to csv (Thanks to Monika Andergassen)

provide more feedback when tdom parsing fails